b75d8dc564
The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h> #include <asm/u-boot.h> void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: <smpl> @@ typedef bd_t; @@ -bd_t +struct bd_info </smpl> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> |
||
|---|---|---|
| .. | ||
| cyrus.c | ||
| cyrus.h | ||
| ddr.c | ||
| eth.c | ||
| Kconfig | ||
| law.c | ||
| MAINTAINERS | ||
| Makefile | ||
| pbi.cfg | ||
| pci.c | ||
| rcw_p5020_v2.cfg | ||
| rcw_p5040.cfg | ||
| README | ||
| tlb.c | ||
Rebuilding u-boot for Cyrus The Cyrus defconfigs are Cyrus_P5020_defconfig and Cyrus_P5040_defconfig. They currently disable size optimization in order to avoid a relocation bug in some versions of GCC. As the output size is a constant, the size optimization is not currently important. Cyrus boots off a microSD card in a slot on the motherboard. This requires that the u-boot is built for the Pre-Boot Loader on the P5020/P5040. In order to reflash u-boot, you must download u-boot.pbl, then write it onto the card. To do that from u-boot: > tftp 1000000 u-boot.pbl > mmc write 1000000 8 672 If you want to do this via a card reader in linux: > dd if=u-boot.pbl of=/dev/sdX bs=512 oseek=8