leandrof/u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

miiphy: leverage current_mii cache more

Browse Source 
For code that uses miiphy_{read,write}, every call invokes a full look up
of the mii list.  There is already a "current_mii" cache that is used by
some code, but have the miiphy_{read,write} function use it as well.  This
does increase the code size slightly, but I think it's worth it.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Signed-off-by: Ben Warren <biggerbadderben@gmail.com>
This commit is contained in:
Mike Frysinger 2010-07-27 18:35:10 -04:00 committed by Ben Warren
parent 0daac97801
commit ede16ea32d
1 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
common/miiphyutil.c
View File

@ -162,6 +162,20 @@ const char *miiphy_get_current_dev(void)
return NULL; return NULL;
} }
static struct mii_dev *miiphy_get_active_dev(const char *devname)
{
/* If the current mii is the one we want, return it */
if (current_mii)
if (strcmp(current_mii->name, devname) == 0)
return current_mii;
/* Otherwise, set the active one to the one we want */
if (miiphy_set_current_dev(devname))
return NULL;
else
return current_mii;
}
/***************************************************************************** /*****************************************************************************
* *
* Read to variable <value> from the PHY attached to device <devname>, * Read to variable <value> from the PHY attached to device <devname>,
@ -175,7 +189,7 @@ int miiphy_read(const char *devname, unsigned char addr, unsigned char reg,
{ {
struct mii_dev *dev; struct mii_dev *dev;
dev = miiphy_get_dev_by_name(devname, 0); dev = miiphy_get_active_dev(devname);
if (dev) if (dev)
return dev->read(devname, addr, reg, value); return dev->read(devname, addr, reg, value);
@ -195,7 +209,7 @@ int miiphy_write(const char *devname, unsigned char addr, unsigned char reg,
{ {
struct mii_dev *dev; struct mii_dev *dev;
dev = miiphy_get_dev_by_name(devname, 0); dev = miiphy_get_active_dev(devname);
if (dev) if (dev)
return dev->write(devname, addr, reg, value); return dev->write(devname, addr, reg, value);