leandrof/u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix checkpatch.pl complaints in cmd_cache.c

Browse Source 
Old code that is not compliant.

Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
This commit is contained in:
Joe Hershberger 2012-10-03 10:56:16 +00:00 committed by Tom Rini
parent 8cab08e804
commit e9455fcc45
1 changed files with 26 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

47
common/cmd_cache.c
View File

@ -36,21 +36,24 @@ void __weak invalidate_icache_all(void)
puts("No arch specific invalidate_icache_all available!\n");
}
int do_icache ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
int do_icache(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
{
switch (argc) {
case 2: /* on / off */
switch (parse_argv(argv[1])) {
case 0: icache_disable();
case 0:
icache_disable();
break;
case 1: icache_enable ();
case 1:
icache_enable();
break;
case 2: invalidate_icache_all();
case 2:
invalidate_icache_all();
break;
}
/* FALL TROUGH */
case 1: /* get status */
printf ("Instruction Cache is %s\n",
printf("Instruction Cache is %s\n",
icache_status() ? "ON" : "OFF");
return 0;
default:
@ -65,40 +68,42 @@ void __weak flush_dcache_all(void)
/* please define arch specific flush_dcache_all */
}
int do_dcache ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
int do_dcache(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
{
switch (argc) {
case 2: /* on / off */
case 2: /* on / off */
switch (parse_argv(argv[1])) {
case 0: dcache_disable();
case 0:
dcache_disable();
break;
case 1: dcache_enable ();
case 1:
dcache_enable();
break;
case 2: flush_dcache_all();
case 2:
flush_dcache_all();
break;
}
/* FALL TROUGH */
break;
case 1: /* get status */
printf ("Data (writethrough) Cache is %s\n",
printf("Data (writethrough) Cache is %s\n",
dcache_status() ? "ON" : "OFF");
return 0;
default:
return CMD_RET_USAGE;
}
return 0;
}
static int parse_argv(const char *s)
{
if (strcmp(s, "flush") == 0) {
return (2);
} else if (strcmp(s, "on") == 0) {
return (1);
} else if (strcmp(s, "off") == 0) {
return (0);
}
return (-1);
if (strcmp(s, "flush") == 0)
return 2;
else if (strcmp(s, "on") == 0)
return 1;
else if (strcmp(s, "off") == 0)
return 0;
return -1;
}