leandrof/u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

efi_loader: size of secure boot variables

Browse Source 
The variables SetupMode, AuditMode, DeployedMode are explicitly defined as
UINT8 in the UEFI specification. The type of SecureBoot is UINT8 in EDK2.

Use variable name secure_boot instead of sec_boot for the value of the
UEFI variable SecureBoot.

Avoid abbreviations in function descriptions.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
This commit is contained in:
Heinrich Schuchardt 2020-06-24 12:38:00 +02:00
parent 915f15ac57
commit d80dd9e785
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/efi_loader/efi_variable.c
View File

@ -185,17 +185,17 @@ static const char *parse_attr(const char *str, u32 *attrp, u64 *timep)
/** /**
* efi_set_secure_state - modify secure boot state variables * efi_set_secure_state - modify secure boot state variables
* @sec_boot: value of SecureBoot * @secure_boot: value of SecureBoot
* @setup_mode: value of SetupMode * @setup_mode: value of SetupMode
* @audit_mode: value of AuditMode * @audit_mode: value of AuditMode
* @deployed_mode: value of DeployedMode * @deployed_mode: value of DeployedMode
* *
* Modify secure boot stat-related variables as indicated. * Modify secure boot status related variables as indicated.
* *
* Return: status code * Return: status code
*/ */
static efi_status_t efi_set_secure_state(int sec_boot, int setup_mode, static efi_status_t efi_set_secure_state(u8 secure_boot, u8 setup_mode,
int audit_mode, int deployed_mode) u8 audit_mode, u8 deployed_mode)
{ {
u32 attributes; u32 attributes;
efi_status_t ret; efi_status_t ret;
@ -204,8 +204,8 @@ static efi_status_t efi_set_secure_state(int sec_boot, int setup_mode,
EFI_VARIABLE_RUNTIME_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS |
READ_ONLY; READ_ONLY;
ret = efi_set_variable_common(L"SecureBoot", &efi_global_variable_guid, ret = efi_set_variable_common(L"SecureBoot", &efi_global_variable_guid,
attributes, sizeof(sec_boot), &sec_boot, attributes, sizeof(secure_boot),
false); &secure_boot, false);
if (ret != EFI_SUCCESS) if (ret != EFI_SUCCESS)
goto err; goto err;