leandrof/u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

i2c: mxc_i2c: Remove i2c_idle_bus from probe

Browse Source 
i2c_idle_bus is already used in i2c_init_transfer. So before each transfer
if the bus is not ready, the i2c_idle_bus will be used to force idle.
It is unnecessary to call it again in probe.

We found a issue when enabling i2c mux with the mxc_i2c. The mxc_i2c is probed
after mux probing. However, at this moment the mux is still in idle state not
select any port. So if we call i2c_idle_bus in probe, it will fail and cause
mxc_i2c probe failed.

Signed-off-by: Ye Li <ye.li@nxp.com>
This commit is contained in:
Ye Li 2019-07-10 10:24:15 +00:00 committed by Heiko Schocher
parent 42cc3125c4
commit d7d864017d
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/i2c/mxc_i2c.c
View File

@ -917,13 +917,6 @@ static int mxc_i2c_probe(struct udevice *bus)
} }
} }
ret = i2c_idle_bus(i2c_bus);
if (ret < 0) {
/* Disable clk */
enable_i2c_clk(0, bus->seq);
return ret;
}
/* /*
* Pinmux settings are in board file now, until pinmux is supported, * Pinmux settings are in board file now, until pinmux is supported,
* we can set pinmux here in probe function. * we can set pinmux here in probe function.