leandrof/u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

env: Use better name for variable in env_get_f()

Browse Source 
The `nxt` variable actually points to the terminating null-byte of the
current env var, and the next env var is at `nxt + 1`, not `nxt`. So a
better name for this variable is `end`.

Signed-off-by: Marek Behún <marek.behun@nic.cz>
Reviewed-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Marek Behún 2021-10-17 17:36:32 +02:00 committed by Simon Glass
parent eff73b2eed
commit d1bca8d2a1
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
cmd/nvedit.c
View File

@ -726,19 +726,19 @@ static const char *env_match(const char *p, const char *s1)
*/
int env_get_f(const char *name, char *buf, unsigned len)
{
const char *env, *p, *nxt;
const char *env, *p, *end;
if (gd->env_valid == ENV_INVALID)
env = (const char *)default_environment;
else
env = (const char *)gd->env_addr;
for (p = env; *p != '\0'; p = nxt + 1) {
for (p = env; *p != '\0'; p = end + 1) {
const char *value;
int n;
for (nxt = p; *nxt != '\0'; ++nxt)
if (nxt - env >= CONFIG_ENV_SIZE)
for (end = p; *end != '\0'; ++end)
if (end - env >= CONFIG_ENV_SIZE)
return -1;
value = env_match(p, name);