leandrof/u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

net: ravb: Do not shut down clock in start callback

Browse Source 
Do not stop the clock in the start callback in case of failure, keep
them running to also keep the PHY running. The failure could be ie.
PHY failing to negotiate link and if the clock get shut down, another
attempt at bringing the link up would fail. The clock right now are
started in probe function and stopped in remove function, which is
the correct behavior.

Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
Cc: Joe Hershberger <joe.hershberger@ni.com>
This commit is contained in:
Marek Vasut 2018-06-18 09:35:45 +02:00
parent 24417edfff
commit c4a8d9ca04
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/net/ravb.c
View File

@ -437,7 +437,7 @@ static int ravb_start(struct udevice *dev)
ret = ravb_reset(dev);
if (ret)
goto err;
return ret;
ravb_base_desc_init(eth);
ravb_tx_desc_init(eth);
@ -445,16 +445,12 @@ static int ravb_start(struct udevice *dev)
ret = ravb_config(dev);
if (ret)
goto err;
return ret;
/* Setting the control will start the AVB-DMAC process. */
writel(CCC_OPC_OPERATION, eth->iobase + RAVB_REG_CCC);
return 0;
err:
clk_disable(&eth->clk);
return ret;
}
static void ravb_stop(struct udevice *dev)