leandrof/u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

net: pcnet: Fix init on big endian 64 bit

Browse Source 
If dev->iobase is 64 bits wide then writing the value of the BAR into a
pointer to iobase will not work on big endian systems, where the BAR
value will incorrectly get written to the upper 32 bits of the 64 bit
variable. Fix this by reading the BAR into a u32, matching the type
expected by pci_read_config_dword.

Signed-off-by: Paul Burton <paul.burton@imgtec.com>
This commit is contained in:
Paul Burton 2016-05-26 17:32:29 +01:00 committed by Daniel Schwierzeck
parent 442d2e0149
commit bed1ca322d
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/net/pcnet.c
View File

@ -155,6 +155,7 @@ int pcnet_initialize(bd_t *bis)
struct eth_device *dev; struct eth_device *dev;
u16 command, status; u16 command, status;
int dev_nr = 0; int dev_nr = 0;
u32 bar;
PCNET_DEBUG1("\npcnet_initialize...\n"); PCNET_DEBUG1("\npcnet_initialize...\n");
@ -182,9 +183,8 @@ int pcnet_initialize(bd_t *bis)
/* /*
* Setup the PCI device. * Setup the PCI device.
*/ */
pci_read_config_dword(devbusfn, PCI_BASE_ADDRESS_0, pci_read_config_dword(devbusfn, PCI_BASE_ADDRESS_0, &bar);
(unsigned int *)&dev->iobase); dev->iobase = pci_io_to_phys(devbusfn, bar);
dev->iobase = pci_io_to_phys(devbusfn, dev->iobase);
dev->iobase &= ~0xf; dev->iobase &= ~0xf;
PCNET_DEBUG1("%s: devbusfn=0x%x iobase=0x%lx: ", PCNET_DEBUG1("%s: devbusfn=0x%x iobase=0x%lx: ",