leandrof/u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tools: moveconfig: simplify show_failed_boards() and show more info

Browse Source 
Since commit 1d085568b3 ("tools: moveconfig: display log atomically
in more readable format"), the function color_text() is clever enough
to exclude LF from escape sequences.  Exploit it for removing the
"for" loops from Slots.show_failed_boards().

Also, display "(the list has been saved in moveconfig.failed)" if
there are failed boards.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Joe Hershberger <joe.hershberger@ni.com>
This commit is contained in:
Masahiro Yamada 2016-06-15 14:33:53 +09:00
parent f432c33f27
commit 96dccd9767
1 changed files with 12 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
tools/moveconfig.py
View File

@ -860,21 +860,22 @@ class Slots:
def show_failed_boards(self):
"""Display all of the failed boards (defconfigs)."""
failed_boards = []
boards = []
output_file = 'moveconfig.failed'
for slot in self.slots:
failed_boards += slot.get_failed_boards()
boards += slot.get_failed_boards()
if len(failed_boards) > 0:
msg = [ "The following boards were not processed due to error:" ]
msg += failed_boards
for line in msg:
print >> sys.stderr, color_text(self.options.color,
COLOR_LIGHT_RED, line)
if boards:
boards = '\n'.join(boards) + '\n'
msg = "The following boards were not processed due to error:\n"
msg += boards
msg += "(the list has been saved in %s)\n" % output_file
print >> sys.stderr, color_text(self.options.color, COLOR_LIGHT_RED,
msg)
with open('moveconfig.failed', 'w') as f:
for board in failed_boards:
f.write(board + '\n')
with open(output_file, 'w') as f:
f.write(boards)
class ReferenceSource: