leandrof/u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

efi_selftest: remove todo in device path test

Browse Source 
The installation of UninstallProtocol is functional now.
So we do not expect errors when calling it.

Call UninstallProtocol with correct level of indirection
for parameter handle.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Signed-off-by: Alexander Graf <agraf@suse.de>
This commit is contained in:
Heinrich Schuchardt 2018-01-11 08:16:07 +01:00 committed by Alexander Graf
parent 77425e73b8
commit 8d7cf39090
1 changed files with 25 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
lib/efi_selftest/efi_selftest_devicepath.c
View File

@ -192,31 +192,41 @@ static int teardown(void)
{
efi_status_t ret;
ret = boottime->uninstall_protocol_interface(&handle1,
ret = boottime->uninstall_protocol_interface(handle1,
&guid_device_path,
dp1);
if (ret != EFI_SUCCESS)
efi_st_todo("UninstallProtocolInterface failed\n");
ret = boottime->uninstall_protocol_interface(&handle1,
if (ret != EFI_SUCCESS) {
efi_st_error("UninstallProtocolInterface failed\n");
return EFI_ST_FAILURE;
}
ret = boottime->uninstall_protocol_interface(handle1,
&guid_protocol,
&interface);
if (ret != EFI_SUCCESS)
efi_st_todo("UninstallProtocolInterface failed\n");
ret = boottime->uninstall_protocol_interface(&handle2,
if (ret != EFI_SUCCESS) {
efi_st_error("UninstallProtocolInterface failed\n");
return EFI_ST_FAILURE;
}
ret = boottime->uninstall_protocol_interface(handle2,
&guid_device_path,
dp2);
if (ret != EFI_SUCCESS)
efi_st_todo("UninstallProtocolInterface failed\n");
ret = boottime->uninstall_protocol_interface(&handle2,
if (ret != EFI_SUCCESS) {
efi_st_error("UninstallProtocolInterface failed\n");
return EFI_ST_FAILURE;
}
ret = boottime->uninstall_protocol_interface(handle2,
&guid_protocol,
&interface);
if (ret != EFI_SUCCESS)
efi_st_todo("UninstallProtocolInterface failed\n");
ret = boottime->uninstall_protocol_interface(&handle3,
if (ret != EFI_SUCCESS) {
efi_st_error("UninstallProtocolInterface failed\n");
return EFI_ST_FAILURE;
}
ret = boottime->uninstall_protocol_interface(handle3,
&guid_device_path,
dp3);
if (ret != EFI_SUCCESS)
efi_st_todo("UninstallProtocolInterface failed\n");
if (ret != EFI_SUCCESS) {
efi_st_error("UninstallProtocolInterface failed\n");
return EFI_ST_FAILURE;
}
if (dp1) {
ret = boottime->free_pool(dp1);
if (ret != EFI_SUCCESS) {