leandrof/u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fw_printenv: Fix crash due to incorrect size for malloc'ed string.

Browse Source 
Using sizeof gives the size of the pointer only, not the string. This
could easily lead to crashes when using -l argument.

Signed-off-by: Kristian Amlie <kristian.amlie@northern.tech>
This commit is contained in:
Kristian Amlie 2018-04-04 10:09:57 +02:00 committed by Tom Rini
parent 2f8ffb0655
commit 8a0b827b1a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/env/fw_env_main.c vendored
View File

@ -239,7 +239,7 @@ int main(int argc, char *argv[])
argv += optind; argv += optind;
if (env_opts.lockname) { if (env_opts.lockname) {
lockname = malloc(sizeof(env_opts.lockname) + lockname = malloc(strlen(env_opts.lockname) +
sizeof(CMD_PRINTENV) + 10); sizeof(CMD_PRINTENV) + 10);
if (!lockname) { if (!lockname) {
fprintf(stderr, "Unable allocate memory"); fprintf(stderr, "Unable allocate memory");