leandrof/u-boot
1
0
Fork 1
Code Issues Pull Requests Packages Projects Releases Wiki Activity

net: smc911x: Invert the logic in smc911x_miiphy_{read,write}()

Browse Source 
Invert the logic in the aforementioned functions to reduce indent,
no functional change.

Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
Cc: Joe Hershberger <joe.hershberger@ni.com>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
This commit is contained in:
Marek Vasut 2020-03-15 15:43:20 +01:00 committed by marex
parent 49af0cb5a6
commit 6f6cf0083f
1 changed files with 16 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
drivers/net/smc911x.c
View File

@ -216,24 +216,29 @@ static int smc911x_recv(struct eth_device *dev)
static int smc911x_miiphy_read(struct mii_dev *bus, int phy, int devad,
int reg)
{
u16 val = 0;
struct eth_device *dev = eth_get_dev_by_name(bus->name);
if (dev) {
int retval = smc911x_eth_phy_read(dev, phy, reg, &val);
if (retval < 0)
return retval;
return val;
}
return -ENODEV;
u16 val = 0;
int ret;
if (!dev)
return -ENODEV;
ret = smc911x_eth_phy_read(dev, phy, reg, &val);
if (ret < 0)
return ret;
return val;
}
/* wrapper for smc911x_eth_phy_write */
static int smc911x_miiphy_write(struct mii_dev *bus, int phy, int devad,
int reg, u16 val)
{
struct eth_device *dev = eth_get_dev_by_name(bus->name);
if (dev)
return smc911x_eth_phy_write(dev, phy, reg, val);
return -ENODEV;
if (!dev)
return -ENODEV;
return smc911x_eth_phy_write(dev, phy, reg, val);
}
#endif