leandrof/u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

powerpc/mpc8xxx: Fix bug for extended DDR timing

Browse Source 
Faster DDR3 timing requires parameters exceeding previously defined
range. Extended parameters are fixed. Added some debug messages.

Signed-off-by: York Sun <yorksun@freescale.com>
Signed-off-by: Andy Fleming <afleming@freescale.com>
This commit is contained in:
York Sun 2012-08-17 08:22:40 +00:00 committed by Andy Fleming
parent a4c66509f1
commit 45064adcae
2 changed files with 42 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
arch/powerpc/cpu/mpc8xxx/ddr/ctrl_regs.c
View File

@ -313,29 +313,41 @@ static void set_timing_cfg_0(fsl_ddr_cfg_regs_t *ddr,
/* DDR SDRAM Timing Configuration 3 (TIMING_CFG_3) */ /* DDR SDRAM Timing Configuration 3 (TIMING_CFG_3) */
static void set_timing_cfg_3(fsl_ddr_cfg_regs_t *ddr, static void set_timing_cfg_3(fsl_ddr_cfg_regs_t *ddr,
const memctl_options_t *popts,
const common_timing_params_t *common_dimm, const common_timing_params_t *common_dimm,
unsigned int cas_latency) unsigned int cas_latency)
{ {
/* Extended precharge to activate interval (tRP) */
unsigned int ext_pretoact = 0;
/* Extended Activate to precharge interval (tRAS) */ /* Extended Activate to precharge interval (tRAS) */
unsigned int ext_acttopre = 0; unsigned int ext_acttopre = 0;
unsigned int ext_refrec; /* Extended refresh recovery time (tRFC) */ /* Extended activate to read/write interval (tRCD) */
unsigned int ext_caslat = 0; /* Extended MCAS latency from READ cmd */ unsigned int ext_acttorw = 0;
unsigned int cntl_adj = 0; /* Control Adjust */ /* Extended refresh recovery time (tRFC) */
unsigned int ext_refrec;
/* If the tRAS > 19 MCLK, we use the ext mode */ /* Extended MCAS latency from READ cmd */
if (picos_to_mclk(common_dimm->tRAS_ps) > 0x13) unsigned int ext_caslat = 0;
ext_acttopre = 1; /* Extended last data to precharge interval (tWR) */
unsigned int ext_wrrec = 0;
/* Control Adjust */
unsigned int cntl_adj = 0;
ext_pretoact = picos_to_mclk(common_dimm->tRP_ps) >> 4;
ext_acttopre = picos_to_mclk(common_dimm->tRAS_ps) >> 4;
ext_acttorw = picos_to_mclk(common_dimm->tRCD_ps) >> 4;
ext_caslat = (2 * cas_latency - 1) >> 4;
ext_refrec = (picos_to_mclk(common_dimm->tRFC_ps) - 8) >> 4; ext_refrec = (picos_to_mclk(common_dimm->tRFC_ps) - 8) >> 4;
/* ext_wrrec only deals with 16 clock and above, or 14 with OTF */
/* If the CAS latency more than 8, use the ext mode */ ext_wrrec = (picos_to_mclk(common_dimm->tWR_ps) +
if (cas_latency > 8) (popts->OTF_burst_chop_en ? 2 : 0)) >> 4;
ext_caslat = 1;
ddr->timing_cfg_3 = (0 ddr->timing_cfg_3 = (0
| ((ext_acttopre & 0x1) << 24) | ((ext_pretoact & 0x1) << 28)
| ((ext_refrec & 0xF) << 16) | ((ext_acttopre & 0x2) << 24)
| ((ext_caslat & 0x1) << 12) | ((ext_acttorw & 0x1) << 22)
| ((ext_refrec & 0x1F) << 16)
| ((ext_caslat & 0x3) << 12)
| ((ext_wrrec & 0x1) << 8)
| ((cntl_adj & 0x7) << 0) | ((cntl_adj & 0x7) << 0)
); );
debug("FSLDDR: timing_cfg_3 = 0x%08x\n", ddr->timing_cfg_3); debug("FSLDDR: timing_cfg_3 = 0x%08x\n", ddr->timing_cfg_3);
@ -397,15 +409,16 @@ static void set_timing_cfg_1(fsl_ddr_cfg_regs_t *ddr,
* we need set extend bit for it at * we need set extend bit for it at
* TIMING_CFG_3[EXT_CASLAT] * TIMING_CFG_3[EXT_CASLAT]
*/ */
if (cas_latency > 8)
cas_latency -= 8;
caslat_ctrl = 2 * cas_latency - 1; caslat_ctrl = 2 * cas_latency - 1;
#endif #endif
refrec_ctrl = picos_to_mclk(common_dimm->tRFC_ps) - 8; refrec_ctrl = picos_to_mclk(common_dimm->tRFC_ps) - 8;
wrrec_mclk = picos_to_mclk(common_dimm->tWR_ps); wrrec_mclk = picos_to_mclk(common_dimm->tWR_ps);
wrrec_mclk = wrrec_table[wrrec_mclk - 1]; if (wrrec_mclk > 16)
printf("Error: WRREC doesn't support more than 16 clocks\n");
else
wrrec_mclk = wrrec_table[wrrec_mclk - 1];
if (popts->OTF_burst_chop_en) if (popts->OTF_burst_chop_en)
wrrec_mclk += 2; wrrec_mclk += 2;
@ -1550,7 +1563,7 @@ compute_fsl_memctl_config_regs(const memctl_options_t *popts,
set_timing_cfg_0(ddr, popts); set_timing_cfg_0(ddr, popts);
#endif #endif
set_timing_cfg_3(ddr, common_dimm, cas_latency); set_timing_cfg_3(ddr, popts, common_dimm, cas_latency);
set_timing_cfg_1(ddr, popts, common_dimm, cas_latency); set_timing_cfg_1(ddr, popts, common_dimm, cas_latency);
set_timing_cfg_2(ddr, popts, common_dimm, set_timing_cfg_2(ddr, popts, common_dimm,
cas_latency, additive_latency); cas_latency, additive_latency);

12
arch/powerpc/cpu/mpc8xxx/ddr/lc_common_dimm_params.c
View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2008-2011 Freescale Semiconductor, Inc. * Copyright 2008-2012 Freescale Semiconductor, Inc.
* *
* This program is free software; you can redistribute it and/or * This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License * modify it under the terms of the GNU General Public License
@ -491,5 +491,15 @@ compute_lowest_common_dimm_parameters(const dimm_params_t *dimm_params,
*/ */
outpdimm->additive_latency = additive_latency; outpdimm->additive_latency = additive_latency;
debug("tCKmin_ps = %u\n", outpdimm->tCKmin_X_ps);
debug("tRCD_ps = %u\n", outpdimm->tRCD_ps);
debug("tRP_ps = %u\n", outpdimm->tRP_ps);
debug("tRAS_ps = %u\n", outpdimm->tRAS_ps);
debug("tWR_ps = %u\n", outpdimm->tWR_ps);
debug("tWTR_ps = %u\n", outpdimm->tWTR_ps);
debug("tRFC_ps = %u\n", outpdimm->tRFC_ps);
debug("tRRD_ps = %u\n", outpdimm->tRRD_ps);
debug("tRC_ps = %u\n", outpdimm->tRC_ps);
return 0; return 0;
} }