The check for a valid ptr in ddb_io->dma isn't really necessary since only
devices that do data transport using DMA are supported by the driver, and
all previous initialisation code (through input_init(), output_init() and
dma_init(), has_dma is always true as it's set in ddb_probe() during
driver load) guarantees the ptr is set.
As a side effect, this silences these sparse warnings (albeit them being
false positives as ddb_io->dma won't change in these functions so the
condition always equals to the same result):
drivers/media/pci/ddbridge/ddbridge-core.c:495:9: warning: context imbalance in 'ddb_output_start' - different lock contexts for basic block
drivers/media/pci/ddbridge/ddbridge-core.c:510:9: warning: context imbalance in 'ddb_output_stop' - different lock contexts for basic block
drivers/media/pci/ddbridge/ddbridge-core.c:525:9: warning: context imbalance in 'ddb_input_stop' - different lock contexts for basic block
drivers/media/pci/ddbridge/ddbridge-core.c:560:9: warning: context imbalance in 'ddb_input_start' - different lock contexts for basic block
Signed-off-by: Daniel Scheller <d.scheller@gmx.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
|
||
|---|---|---|
| .. | ||
| ddbridge-ci.c | ||
| ddbridge-ci.h | ||
| ddbridge-core.c | ||
| ddbridge-hw.c | ||
| ddbridge-hw.h | ||
| ddbridge-i2c.c | ||
| ddbridge-i2c.h | ||
| ddbridge-io.h | ||
| ddbridge-main.c | ||
| ddbridge-max.c | ||
| ddbridge-max.h | ||
| ddbridge-regs.h | ||
| ddbridge.h | ||
| Kconfig | ||
| Makefile | ||