196f9bc050
The test runs several test cases and is supposed to return an error in
case at least one of them failed.
Currently, the check of the return value of each test case is in the
wrong place, which can result in the wrong return value. For example:
# TESTS='tc_police' ./resource_scale.sh
TEST: 'tc_police' [default] 968 [FAIL]
tc police offload count failed
Error: mlxsw_spectrum: Failed to allocate policer index.
We have an error talking to the kernel
Command failed /tmp/tmp.i7Oc5HwmXY:969
TEST: 'tc_police' [default] overflow 969 [ OK ]
...
TEST: 'tc_police' [ipv4_max] overflow 969 [ OK ]
$ echo $?
0
Fix this by moving the check to be done after each test case.
Fixes: 059b18e21c ("selftests: mlxsw: Return correct error code in resource scale test")
Signed-off-by: Amit Cohen <amcohen@nvidia.com>
Reviewed-by: Petr Machata <petrm@nvidia.com>
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
60 lines
1.3 KiB
Bash
Executable File
60 lines
1.3 KiB
Bash
Executable File
#!/bin/bash
|
|
# SPDX-License-Identifier: GPL-2.0
|
|
|
|
lib_dir=$(dirname $0)/../../../../net/forwarding
|
|
|
|
NUM_NETIFS=6
|
|
source $lib_dir/lib.sh
|
|
source $lib_dir/tc_common.sh
|
|
source devlink_lib_spectrum.sh
|
|
|
|
current_test=""
|
|
|
|
cleanup()
|
|
{
|
|
pre_cleanup
|
|
if [ ! -z $current_test ]; then
|
|
${current_test}_cleanup
|
|
fi
|
|
devlink_sp_size_kvd_to_default
|
|
}
|
|
|
|
devlink_sp_read_kvd_defaults
|
|
trap cleanup EXIT
|
|
|
|
ALL_TESTS="router tc_flower mirror_gre tc_police port rif_mac_profile"
|
|
for current_test in ${TESTS:-$ALL_TESTS}; do
|
|
RET_FIN=0
|
|
source ${current_test}_scale.sh
|
|
|
|
num_netifs_var=${current_test^^}_NUM_NETIFS
|
|
num_netifs=${!num_netifs_var:-$NUM_NETIFS}
|
|
|
|
for profile in $KVD_PROFILES; do
|
|
RET=0
|
|
devlink_sp_resource_kvd_profile_set $profile
|
|
if [[ $RET -gt 0 ]]; then
|
|
log_test "'$current_test' [$profile] setting"
|
|
continue
|
|
fi
|
|
|
|
for should_fail in 0 1; do
|
|
RET=0
|
|
target=$(${current_test}_get_target "$should_fail")
|
|
${current_test}_setup_prepare
|
|
setup_wait $num_netifs
|
|
${current_test}_test "$target" "$should_fail"
|
|
${current_test}_cleanup
|
|
if [[ "$should_fail" -eq 0 ]]; then
|
|
log_test "'$current_test' [$profile] $target"
|
|
else
|
|
log_test "'$current_test' [$profile] overflow $target"
|
|
fi
|
|
RET_FIN=$(( RET_FIN || RET ))
|
|
done
|
|
done
|
|
done
|
|
current_test=""
|
|
|
|
exit "$RET_FIN"
|