leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
f485da3c11
linux/arch/powerpc/include/asm/book3s/64
History
Christophe Leroy aec982603a powerpc/fixmap: Fix VM debug warning on unmap 
Unmapping a fixmap entry is done by calling __set_fixmap()
with FIXMAP_PAGE_CLEAR as flags.

Today, powerpc __set_fixmap() calls map_kernel_page().

map_kernel_page() is not happy when called a second time
for the same page.

	WARNING: CPU: 0 PID: 1 at arch/powerpc/mm/pgtable.c:194 set_pte_at+0xc/0x1e8
	CPU: 0 PID: 1 Comm: swapper Not tainted 5.16.0-rc3-s3k-dev-01993-g350ff07feb7d-dirty #682
	NIP:  c0017cd4 LR: c00187f0 CTR: 00000010
	REGS: e1011d50 TRAP: 0700   Not tainted  (5.16.0-rc3-s3k-dev-01993-g350ff07feb7d-dirty)
	MSR:  00029032 <EE,ME,IR,DR,RI>  CR: 42000208  XER: 00000000

	GPR00: c0165fec e1011e10 c14c0000 c0ee2550 ff800000 c0f3d000 00000000 c001686c
	GPR08: 00001000 b00045a9 00000001 c0f58460 c0f50000 00000000 c0007e10 00000000
	GPR16: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
	GPR24: 00000000 00000000 c0ee2550 00000000 c0f57000 00000ff8 00000000 ff800000
	NIP [c0017cd4] set_pte_at+0xc/0x1e8
	LR [c00187f0] map_kernel_page+0x9c/0x100
	Call Trace:
	[e1011e10] [c0736c68] vsnprintf+0x358/0x6c8 (unreliable)
	[e1011e30] [c0165fec] __set_fixmap+0x30/0x44
	[e1011e40] [c0c13bdc] early_iounmap+0x11c/0x170
	[e1011e70] [c0c06cb0] ioremap_legacy_serial_console+0x88/0xc0
	[e1011e90] [c0c03634] do_one_initcall+0x80/0x178
	[e1011ef0] [c0c0385c] kernel_init_freeable+0xb4/0x250
	[e1011f20] [c0007e34] kernel_init+0x24/0x140
	[e1011f30] [c0016268] ret_from_kernel_thread+0x5c/0x64
	Instruction dump:
	7fe3fb78 48019689 80010014 7c630034 83e1000c 5463d97e 7c0803a6 38210010
	4e800020 81250000 712a0001 41820008 <0fe00000> 9421ffe0 93e1001c 48000030

Implement unmap_kernel_page() which clears an existing pte.

Reported-by: Maxime Bizon <mbizon@freebox.fr>
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Tested-by: Maxime Bizon <mbizon@freebox.fr>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/b0b752f6f6ecc60653e873f385c6f0dce4e9ab6a.1638789098.git.christophe.leroy@csgroup.eu
2022-01-24 17:29:05 +11:00
..
hash-4k.h powerpc/mm/book3s: Split radix and hash MAX_PHYSMEM limit 2020-09-15 22:13:22 +10:00
hash-64k.h powerpc/mm/book3s: Split radix and hash MAX_PHYSMEM limit 2020-09-15 22:13:22 +10:00
hash-pkey.h powerpc/book3s64/kuap: Use Key 3 for kernel mapping with hash translation 2020-12-04 01:01:25 +11:00
hash.h powerpc/64s: Always define arch unmapped area calls 2021-12-09 22:40:24 +11:00
hugetlb.h hugetlb: allow to free gigantic pages regardless of the configuration 2019-05-14 09:47:47 -07:00
kexec.h powerpc/book3s64/kexec: Clear CIABR on kexec 2020-12-07 23:26:01 +11:00
kup.h powerpc/kuap: Prepare for supporting KUAP on BOOK3E/64 2021-12-09 22:41:19 +11:00
mmu-hash.h powerpc/64s: Move hash MMU support code under CONFIG_PPC_64S_HASH_MMU 2021-12-09 22:41:13 +11:00
mmu.h powerpc/pseries: Add __init attribute to eligible functions 2021-12-23 22:33:15 +11:00
pgalloc.h powerpc/mm/radix: Fix PTE/PMD fragment count for early page table mappings 2020-07-20 22:57:56 +10:00
pgtable-4k.h powerpc/mm: remove pmd_huge/pud_huge stubs and include hugetlb.h 2019-12-01 12:59:08 -08:00
pgtable-64k.h powerpc/mm: remove pmd_huge/pud_huge stubs and include hugetlb.h 2019-12-01 12:59:08 -08:00
pgtable.h powerpc/fixmap: Fix VM debug warning on unmap 2022-01-24 17:29:05 +11:00
pkeys.h powerpc/kuap: Allow kernel thread to access userspace after kthread_use_mm 2021-02-06 23:13:04 +11:00
radix-4k.h powerpc/book3s/radix-4k.h: delete duplicated word 2020-07-27 00:01:31 +10:00
radix-64k.h powerpc/mm/64: Document the sizes of/sizes mapped by Pxx_INDEX_SIZE 2019-04-20 22:02:11 +10:00
radix.h powerpc/s64: Clarify that radix lacks DEBUG_PAGEALLOC 2021-10-22 15:22:02 +11:00
slice.h powerpc/mm: define subarch SLB_ADDR_LIMIT_DEFAULT 2019-05-03 01:20:23 +10:00
tlbflush-hash.h powerpc/64s: Move hash MMU support code under CONFIG_PPC_64S_HASH_MMU 2021-12-09 22:41:13 +11:00
tlbflush-radix.h powerpc/book3s64/mm: update flush_tlb_range to flush page walk cache 2021-07-08 11:48:23 -07:00
tlbflush.h powerpc/pseries: Stop selecting PPC_HASH_MMU_NATIVE 2021-12-02 22:57:23 +11:00