Tejas Upadhyay
b8d8436840
drm/i915/gt: Hold RPM wakelock during PXP suspend
selftest --r live shows failure in suspend tests when
RPM wakelock is not acquired during suspend.
This changes addresses below error :
<4> [154.177535] RPM wakelock ref not held during HW access
<4> [154.177575] WARNING: CPU: 4 PID: 5772 at
drivers/gpu/drm/i915/intel_runtime_pm.h:113
fwtable_write32+0x240/0x320 [i915]
<4> [154.177974] Modules linked in: i915(+) vgem drm_shmem_helper
fuse snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic
ledtrig_audio mei_hdcp mei_pxp x86_pkg_temp_thermal coretemp
crct10dif_pclmul crc32_pclmul ghash_clmulni_intel snd_intel_dspcfg
snd_hda_codec snd_hwdep igc snd_hda_core ttm mei_me ptp
snd_pcm prime_numbers mei i2c_i801 pps_core i2c_smbus intel_lpss_pci
btusb btrtl btbcm btintel bluetooth ecdh_generic ecc [last unloaded: i915]
<4> [154.178143] CPU: 4 PID: 5772 Comm: i915_selftest Tainted: G
U 5.15.0-rc6-CI-Patchwork_21432+ #1
<4> [154.178154] Hardware name: ASUS System Product Name/TUF GAMING
Z590-PLUS WIFI, BIOS 0811 04/06/2021
<4> [154.178160] RIP: 0010:fwtable_write32+0x240/0x320 [i915]
<4> [154.178604] Code: 15 7b e1 0f 0b e9 34 fe ff ff 80 3d a9 89 31
00 00 0f 85 31 fe ff ff 48 c7 c7 88 9e 4f a0 c6 05 95 89 31 00 01 e8
c0 15 7b e1 <0f> 0b e9 17 fe ff ff 8b 05 0f 83 58 e2 85 c0 0f 85 8d
00 00 00 48
<4> [154.178614] RSP: 0018:ffffc900016279f0 EFLAGS: 00010286
<4> [154.178626] RAX: 0000000000000000 RBX: ffff888204fe0ee0
RCX: 0000000000000001
<4> [154.178634] RDX: 0000000080000001 RSI: ffffffff823142b5
RDI: 00000000ffffffff
<4> [154.178641] RBP: 00000000000320f0 R08: 0000000000000000
R09: c0000000ffffcd5a
<4> [154.178647] R10: 00000000000f8c90 R11: ffffc90001627808
R12: 0000000000000000
<4> [154.178654] R13: 0000000040000000 R14: ffffffffa04d12e0
R15: 0000000000000000
<4> [154.178660] FS: 00007f7390aa4c00(0000) GS:ffff88844f000000(0000)
knlGS:0000000000000000
<4> [154.178669] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
<4> [154.178675] CR2: 000055bc40595028 CR3: 0000000204474005
CR4: 0000000000770ee0
<4> [154.178682] PKRU: 55555554
<4> [154.178687] Call Trace:
<4> [154.178706] intel_pxp_fini_hw+0x23/0x30 [i915]
<4> [154.179284] intel_pxp_suspend+0x1f/0x30 [i915]
<4> [154.179807] live_gt_resume+0x5b/0x90 [i915]
Changes since V2 :
- Remove boolean in intel_pxp_runtime_preapre for
non-pxp configs. Solves build error
Changes since V2 :
- Open-code intel_pxp_runtime_suspend - Daniele
- Remove boolean in intel_pxp_runtime_preapre - Daniele
Changes since V1 :
- split the HW access parts in gt_suspend_late - Daniele
- Remove default PXP configs
Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Fixes: 0cfab4cb3c ("drm/i915/pxp: Enable PXP power management")
Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20211117060321.3729343-1-tejaskumarx.surendrakumar.upadhyay@intel.com
(cherry picked from commit d22d446f7a)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
2021-11-24 09:07:18 -05:00
..
2021-11-17 08:46:47 -05:00
2021-11-12 12:11:07 -08:00
2021-11-24 09:07:18 -05:00
2021-11-01 16:38:12 -04:00
2021-11-24 09:07:18 -05:00
2021-10-20 08:55:05 +01:00
2021-06-06 11:19:51 +02:00
2020-12-23 21:58:00 +00:00
2021-05-05 11:36:23 +01:00
2021-07-28 16:45:57 +02:00
2021-07-28 16:45:57 +02:00
2021-08-20 09:40:22 +01:00
2021-08-20 09:40:22 +01:00
2021-07-21 11:49:36 -04:00
2021-10-07 11:04:05 -07:00
2021-07-27 17:32:06 -07:00
2021-10-22 06:30:34 +10:00
2021-10-14 18:04:17 +03:00
2021-10-11 18:09:39 +10:00
2021-07-22 10:07:23 -07:00
2021-09-30 16:19:45 +02:00
2021-06-17 14:22:59 +01:00
2021-08-20 09:39:41 +01:00
2021-09-20 08:06:36 -07:00
2021-06-17 14:22:59 +01:00
2021-08-05 11:34:00 +02:00
2021-09-20 21:42:10 -07:00
2021-05-22 07:17:05 +02:00
2021-09-29 09:28:39 +03:00
2021-08-20 10:28:31 +03:00
2021-03-24 11:39:59 +01:00
2021-03-24 11:39:59 +01:00
2021-01-12 19:03:40 +02:00
2021-01-12 19:03:40 +02:00
2021-06-02 15:06:10 +03:00
2021-08-26 10:50:19 +03:00
2021-06-09 10:52:03 -07:00
2021-09-30 15:04:45 -07:00
2021-10-11 18:09:39 +10:00
2021-08-26 10:50:19 +03:00
2021-02-09 13:26:29 +02:00
2021-08-12 11:20:17 +10:00
2021-07-22 12:05:17 +02:00
2021-08-03 16:05:40 -07:00
2021-07-22 12:05:17 +02:00
2021-03-24 19:30:34 +01:00
2021-10-15 10:37:31 -07:00
2021-11-17 08:46:47 -05:00
2021-11-05 13:50:15 +10:00
2021-10-15 10:45:51 -07:00
2021-06-16 16:33:26 +01:00
2021-06-16 16:33:26 +01:00
2021-07-27 17:32:27 -07:00
2021-07-28 17:18:56 +02:00
2021-07-28 17:18:56 +02:00
2021-03-24 11:39:46 +01:00
2021-06-07 00:59:48 -07:00
2021-07-16 21:47:39 +02:00
2021-07-16 21:47:39 +02:00
2021-06-06 11:19:51 +02:00
2021-02-02 13:58:42 +02:00
2021-10-14 12:22:55 +03:00
2021-11-02 16:47:49 -07:00
2021-08-20 09:40:22 +01:00
2021-06-30 13:24:29 +01:00
2021-01-07 21:37:14 +00:00
2021-11-02 16:47:49 -07:00
2021-06-07 00:59:48 -07:00
2021-09-23 17:36:01 +03:00
2021-11-09 10:11:53 -08:00
2021-10-15 10:45:50 -07:00
2021-07-30 10:19:48 -07:00
2021-10-04 13:10:22 -04:00
2021-10-19 10:45:52 +03:00
2020-11-10 14:37:56 +08:00
2020-11-10 14:37:56 +08:00
2021-08-20 09:40:23 +01:00
2021-08-20 09:40:23 +01:00
2021-07-30 10:19:18 -07:00
2021-07-22 09:28:58 -07:00
2021-10-14 18:04:17 +03:00
2021-10-14 18:04:17 +03:00
2021-11-01 16:38:58 -04:00
2021-09-29 08:53:57 +03:00
2021-06-30 13:24:29 +01:00
2021-06-16 16:48:02 +01:00
2021-11-09 10:02:50 -08:00
2021-08-20 10:28:49 +03:00
2021-10-14 18:05:04 +03:00
2021-10-14 18:05:04 +03:00
2021-08-06 09:03:10 -07:00
2021-07-22 10:18:06 -07:00
2021-10-11 18:09:39 +10:00
2021-10-11 18:09:39 +10:00
2021-10-15 10:37:26 -07:00
2021-07-30 10:19:18 -07:00
2021-11-02 16:47:49 -07:00
2021-07-06 10:10:07 +02:00
2021-03-26 01:01:27 +01:00
2021-10-14 18:05:04 +03:00
2021-03-26 09:24:31 +01:00
2021-10-14 12:22:55 +03:00
2021-10-14 12:22:55 +03:00