linux/drivers
Benjamin Herrenschmidt f3ca4834ac fsi/fsi-master-gpio: Delay sampling of FSI data input
Most SoC GPIO implementations, including the Aspeed one, have
synchronizers on the GPIO inputs. This means that the value
read from a GPIO is a couple of clocks old, from whatever clock
source feeds those synchronizers.

In practice, this means that in no-delay mode, we are using a
value that can potentially be a bit too old and too close to
the clock edge establishing the data on the other side of the link.

The voltage converters we use on some systems make this worse
and sensitive to things like voltage fluctuations etc... This is,
we believe, the cause of occasional CRC errors encountered during
heavy activity on the LPC bus.

This is fixed by introducing a dummy GPIO read before the actual
data read. It slows down SBEFIFO by about 15% (less than any delay
primitive) and the end result is so far solid.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Reviewed-by: Christopher Bostic <cbostic@linux.vnet.ibm.com>
Tested-by: Joel Stanley <joel@jms.id.au>
2018-06-12 14:04:59 +10:00
..
accessibility
acpi libnvdimm for 4.18 2018-06-08 17:21:52 -07:00
amba Merge branch 'for-linus' of git://git.armlinux.org.uk/~rmk/linux-arm 2018-06-06 13:49:25 -07:00
android
ata SCSI misc on 20180610 2018-06-10 13:01:12 -07:00
atm
auxdisplay
base arm64 updates for 4.18: 2018-06-08 11:10:58 -07:00
bcma dma-mapping updates for 4.18: 2018-06-04 10:58:12 -07:00
block for-linus-20180608 2018-06-08 13:36:19 -07:00
bluetooth
bus ARM: SoC driver updates 2018-06-11 18:15:22 -07:00
cdrom
char Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc 2018-06-09 11:14:30 -07:00
clk This time we have a good set of changes to the core framework that do some 2018-06-09 12:06:24 -07:00
clocksource This time we have a good set of changes to the core framework that do some 2018-06-09 12:06:24 -07:00
connector Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next 2018-06-06 18:39:49 -07:00
cpufreq ARM: SoC driver updates 2018-06-11 18:15:22 -07:00
cpuidle powerpc updates for 4.18 2018-06-07 10:23:33 -07:00
crypto Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6 2018-06-05 15:51:21 -07:00
dax libnvdimm for 4.18 2018-06-08 17:21:52 -07:00
dca
devfreq
dio
dma dmaengine updates for 4.18-rc1 2018-06-08 11:02:21 -07:00
dma-buf
edac
eisa
extcon
firewire treewide: Use struct_size() for kmalloc()-family 2018-06-06 11:15:43 -07:00
firmware ARM: SoC: late updates 2018-06-11 18:19:45 -07:00
fmc
fpga
fsi fsi/fsi-master-gpio: Delay sampling of FSI data input 2018-06-12 14:04:59 +10:00
gpio This is the bulk of GPIO changes for the v4.18 development 2018-06-08 10:31:52 -07:00
gpu msm next, i915, vc4, v3d fixes 2018-06-11 07:17:36 -07:00
hid Merge branch 'for-4.18/wacom' into for-linus 2018-06-08 10:28:24 +02:00
hsi
hv SCSI misc on 20180610 2018-06-10 13:01:12 -07:00
hwmon powerpc updates for 4.18 2018-06-07 10:23:33 -07:00
hwspinlock hwspinlock updates for v4.18 2018-06-11 12:09:19 -07:00
hwtracing Char/Misc driver patches for 4.18-rc1 2018-06-05 16:20:22 -07:00
i2c USB/PHY patches for 4.18-rc1 2018-06-05 16:14:12 -07:00
ide ide: don't enable/disable interrupts in force threaded-IRQ mode 2018-06-05 16:26:47 -04:00
idle
iio Staging/IIO patches for 4.18-rc1 2018-06-09 10:32:39 -07:00
infiniband 4.18 Merge window pull request 2018-06-07 13:04:07 -07:00
input - New Device Support 2018-06-11 07:20:17 -07:00
iommu Revert "iommu/amd_iommu: Use CONFIG_DMA_DIRECT_OPS=y and dma_direct_{alloc,free}()" 2018-06-11 12:22:12 -07:00
ipack
irqchip irqchip/ls-scfg-msi: Map MSIs in the iommu 2018-06-06 12:05:19 +02:00
isdn Merge branch 'work.aio-1' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs 2018-06-04 13:57:43 -07:00
leds
lightnvm lightnvm: pblk: fix resource leak of invalid_bitmap 2018-06-05 09:20:27 -06:00
macintosh powerpc updates for 4.18 2018-06-07 10:23:33 -07:00
mailbox - Remove HAS_DMA config dependencies 2018-06-07 13:35:59 -07:00
mcb
md Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/shli/md 2018-06-09 12:01:36 -07:00
media ARM: SoC platform updates 2018-06-11 17:49:09 -07:00
memory
memstick
message SCSI misc on 20180610 2018-06-10 13:01:12 -07:00
mfd - New Device Support 2018-06-11 07:20:17 -07:00
misc pci-v4.18-changes 2018-06-07 12:45:58 -07:00
mmc MMC core: 2018-06-05 16:11:43 -07:00
mtd ARM: SoC platform updates 2018-06-11 17:49:09 -07:00
mux
net Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net 2018-06-10 19:25:23 -07:00
nfc NFC: pn533: don't send USB data off of the stack 2018-05-31 12:43:14 +02:00
ntb
nubus Char/Misc driver patches for 4.18-rc1 2018-06-05 16:20:22 -07:00
nvdimm Merge branch 'for-4.18/mcsafe' into libnvdimm-for-next 2018-06-08 15:16:44 -07:00
nvme for-linus-20180608 2018-06-08 13:36:19 -07:00
nvmem
of ARM: SoC: late updates 2018-06-11 18:19:45 -07:00
opp
oprofile
parisc dma-mapping updates for 4.18: 2018-06-04 10:58:12 -07:00
parport
pci pci-v4.18-changes 2018-06-07 12:45:58 -07:00
pcmcia
perf
phy Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next 2018-06-06 18:39:49 -07:00
pinctrl This time we have a good set of changes to the core framework that do some 2018-06-09 12:06:24 -07:00
platform - New Device Support 2018-06-11 07:20:17 -07:00
pnp media updates for v4.18-rc1 2018-06-07 12:34:37 -07:00
power power supply and reset changes for the v4.18 series 2018-06-09 12:11:09 -07:00
powercap
pps
ps3
ptp
pwm pwm: stm32: Initialize raw local variables 2018-06-04 07:13:40 +01:00
rapidio
ras
regulator regulator: Updates for v4.18 2018-06-08 13:08:57 -07:00
remoteproc
reset ARM: SoC driver updates 2018-06-11 18:15:22 -07:00
rpmsg rpmsg: smd: do not use mananged resources for endpoints and channels 2018-06-04 12:35:03 -07:00
rtc - New Device Support 2018-06-11 07:20:17 -07:00
s390 SCSI misc on 20180610 2018-06-10 13:01:12 -07:00
sbus
scsi SCSI misc on 20180610 2018-06-10 13:01:12 -07:00
sfi
sh
siox
slimbus
sn
soc ARM: SoC: late updates 2018-06-11 18:19:45 -07:00
soundwire Char/Misc driver patches for 4.18-rc1 2018-06-05 16:20:22 -07:00
spi Power management updates for 4.18-rc1 2018-06-05 09:38:39 -07:00
spmi
ssb
staging - Core Frameworks 2018-06-11 07:23:19 -07:00
target SCSI misc on 20180610 2018-06-10 13:01:12 -07:00
tc
tee
thermal - Introduce arithmetic overflow test helper functions (Rasmus) 2018-06-06 17:27:14 -07:00
thunderbolt
tty powerpc updates for 4.18 2018-06-07 10:23:33 -07:00
uio
usb - Introduce arithmetic overflow test helper functions (Rasmus) 2018-06-06 17:27:14 -07:00
uwb
vfio Merge branch 'work.aio-1' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs 2018-06-04 13:57:43 -07:00
vhost Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next 2018-06-06 18:39:49 -07:00
video - Core Frameworks 2018-06-11 07:23:19 -07:00
virt
virtio
visorbus
vlynq
vme
w1 Char/Misc driver patches for 4.18-rc1 2018-06-05 16:20:22 -07:00
watchdog watchdog: da9063: remove duplicated timeout_to_sel calls 2018-06-07 12:41:43 +02:00
xen xen: fixes and features for v4-18-rc1 2018-06-08 09:24:54 -07:00
zorro - Introduce arithmetic overflow test helper functions (Rasmus) 2018-06-06 17:27:14 -07:00
Kconfig
Makefile