linux/fs/ubifs
Eric Biggers f0d07a98a0 ubifs: don't trigger assertion on invalid no-key filename
If userspace provides an invalid fscrypt no-key filename which encodes a
hash value with any of the UBIFS node type bits set (i.e. the high 3
bits), gracefully report ENOENT rather than triggering ubifs_assert().

Test case with kvm-xfstests shell:

    . fs/ubifs/config
    . ~/xfstests/common/encrypt
    dev=$(__blkdev_to_ubi_volume /dev/vdc)
    ubiupdatevol $dev -t
    mount $dev /mnt -t ubifs
    mkdir /mnt/edir
    xfs_io -c set_encpolicy /mnt/edir
    rm /mnt/edir/_,,,,,DAAAAAAAAAAAAAAAAAAAAAAAAAA

With the bug, the following assertion fails on the 'rm' command:

    [   19.066048] UBIFS error (ubi0:0 pid 379): ubifs_assert_failed: UBIFS assert failed: !(hash & ~UBIFS_S_KEY_HASH_MASK), in fs/ubifs/key.h:170

Fixes: f4f61d2cc6 ("ubifs: Implement encrypted filenames")
Cc: <stable@vger.kernel.org> # v4.10+
Link: https://lore.kernel.org/r/20200120223201.241390-5-ebiggers@kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
2020-01-22 14:49:56 -08:00
..
auth.c ubifs: Fix memory leak in __ubifs_node_verify_hmac error path 2019-09-15 22:11:58 +02:00
budget.c ubifs: Limit the number of pages in shrink_liability 2019-08-22 17:25:33 +02:00
commit.c
compress.c ubifs: Add support for zstd compression. 2019-07-08 19:43:53 +02:00
crypto.c
debug.c ubifs: Remove obsolete TODO from dfs_file_write() 2019-11-17 22:15:28 +01:00
debug.h Driver Core and debugfs changes for 5.3-rc1 2019-07-12 12:24:03 -07:00
dir.c ubifs: don't trigger assertion on invalid no-key filename 2020-01-22 14:49:56 -08:00
file.c ubifs: use IS_ENCRYPTED() instead of ubifs_crypt_is_encrypted() 2020-01-20 10:43:46 -08:00
find.c
gc.c
io.c
ioctl.c ubifs: wire up new fscrypt ioctls 2019-08-12 19:18:50 -07:00
journal.c ubifs: use IS_ENCRYPTED() instead of ubifs_crypt_is_encrypted() 2020-01-20 10:43:46 -08:00
Kconfig fscrypt: Allow modular crypto algorithms 2019-12-31 10:33:51 -06:00
key.h
log.c ubifs: remove unnecessary check in ubifs_log_start_commit 2019-07-08 19:43:51 +02:00
lprops.c
lpt_commit.c
lpt.c
Makefile
master.c ubifs: support offline signed images 2019-07-08 19:43:52 +02:00
misc.c
misc.h
orphan.c ubifs: do_kill_orphans: Fix a memory leak bug 2019-11-17 22:22:54 +01:00
recovery.c ubifs: Fix typo of output in get_cs_sqnum 2019-07-08 19:43:43 +02:00
replay.c
sb.c ubifs: Fix type of sup->hash_algo 2019-11-17 22:22:53 +01:00
scan.c
shrinker.c
super.c Revert "ubifs: Fix memory leak bug in alloc_ubifs_info() error path" 2019-11-17 22:22:53 +01:00
tnc_commit.c ubifs: ubifs_tnc_start_commit: Fix OOB in layout_in_gaps 2019-11-17 22:22:54 +01:00
tnc_misc.c ubifs: Fix memory leak in read_znode() error path 2019-09-15 22:11:18 +02:00
tnc.c ubifs: Correctly use tnc_next() in search_dh_cookie() 2019-07-08 19:13:41 +02:00
ubifs-media.h ubifs: Add support for zstd compression. 2019-07-08 19:43:53 +02:00
ubifs.h ubifs: use IS_ENCRYPTED() instead of ubifs_crypt_is_encrypted() 2020-01-20 10:43:46 -08:00
xattr.c