Christophe Leroy ee0df19305 net: ucc_geth - fix Oops when changing number of buffers in the ring ... When changing the number of buffers in the RX ring while the interface is running, the following Oops is encountered due to the new number of buffers being taken into account immediately while their allocation is done when opening the device only. [ 69.882706] Unable to handle kernel paging request for data at address 0xf0000100 [ 69.890172] Faulting instruction address: 0xc033e164 [ 69.895122] Oops: Kernel access of bad area, sig: 11 [#1] [ 69.900494] BE PREEMPT CMPCPRO [ 69.907120] CPU: 0 PID: 0 Comm: swapper Not tainted 4.14.115-00006-g179ade8ce3-dirty #269 [ 69.915956] task: c0684310 task.stack: c06da000 [ 69.920470] NIP: c033e164 LR: c02e44d0 CTR: c02e41fc [ 69.925504] REGS: dfff1e20 TRAP: 0300 Not tainted (4.14.115-00006-g179ade8ce3-dirty) [ 69.934161] MSR: 00009032 <EE,ME,IR,DR,RI> CR: 22004428 XER: 20000000 [ 69.940869] DAR: f0000100 DSISR: 20000000 [ 69.940869] GPR00: c0352d70 dfff1ed0 c0684310 f00000a4 00000040 dfff1f68 00000000 0000001f [ 69.940869] GPR08: df53f410 1cc00040 00000021 c0781640 42004424 100c82b6 f00000a4 df53f5b0 [ 69.940869] GPR16: df53f6c0 c05daf84 00000040 00000000 00000040 c0782be4 00000000 00000001 [ 69.940869] GPR24: 00000000 df53f400 000001b0 df53f410 df53f000 0000003f df708220 1cc00044 [ 69.978348] NIP [c033e164] skb_put+0x0/0x5c [ 69.982528] LR [c02e44d0] ucc_geth_poll+0x2d4/0x3f8 [ 69.987384] Call Trace: [ 69.989830] [dfff1ed0] [c02e4554] ucc_geth_poll+0x358/0x3f8 (unreliable) [ 69.996522] [dfff1f20] [c0352d70] net_rx_action+0x248/0x30c [ 70.002099] [dfff1f80] [c04e93e4] __do_softirq+0xfc/0x310 [ 70.007492] [dfff1fe0] [c0021124] irq_exit+0xd0/0xd4 [ 70.012458] [dfff1ff0] [c000e7e0] call_do_irq+0x24/0x3c [ 70.017683] [c06dbe80] [c0006bac] do_IRQ+0x64/0xc4 [ 70.022474] [c06dbea0] [c001097c] ret_from_except+0x0/0x14 [ 70.027964] --- interrupt: 501 at rcu_idle_exit+0x84/0x90 [ 70.027964] LR = rcu_idle_exit+0x74/0x90 [ 70.037585] [c06dbf60] [20000000] 0x20000000 (unreliable) [ 70.042984] [c06dbf80] [c004bb0c] do_idle+0xb4/0x11c [ 70.047945] [c06dbfa0] [c004bd14] cpu_startup_entry+0x18/0x1c [ 70.053682] [c06dbfb0] [c05fb034] start_kernel+0x370/0x384 [ 70.059153] [c06dbff0] [00003438] 0x3438 [ 70.063062] Instruction dump: [ 70.066023] 38a00000 38800000 90010014 4bfff015 80010014 7c0803a6 3123ffff 7c691910 [ 70.073767] 38210010 4e800020 38600000 4e800020 <80e3005c> 80c30098 3107ffff 7d083910 [ 70.081690] ---[ end trace be7ccd9c1e1a9f12 ]--- This patch forbids the modification of the number of buffers in the ring while the interface is running. Fixes: ac421852b3 ("ucc_geth: add ethtool support") Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr> Signed-off-by: David S. Miller <davem@davemloft.net>		2019-05-05 10:33:01 -07:00
..
accessibility
acpi	Revert "ACPICA: Clear status of GPEs before enabling them"	2019-04-30 20:03:44 +02:00
amba	ARM: 8836/1: drivers: amba: Update component matching to use the CoreSight UCI values.	2019-02-26 11:23:49 +00:00
android	binder: fix race between munmap() and direct reclaim	2019-03-21 06:51:32 +01:00
ata	libata: fix using DMA buffers on stack	2019-03-28 08:16:04 -06:00
atm	firestream: fix spelling mistake "tramsitted" -> "transmitted"	2019-04-18 11:38:22 -07:00
auxdisplay	auxdisplay: charlcd: make backlight initial state configurable	2019-03-17 08:48:45 +01:00
base	mm/memory_hotplug: do not unlock after failing to take the device_hotplug_lock	2019-04-19 09:46:04 -07:00
bcma
block	zram: pass down the bvec we need to read into in the work struct	2019-04-26 09:18:05 -07:00
bluetooth	Bluetooth: btusb: request wake pin with NOAUTOEN	2019-04-09 17:38:24 -10:00
bus	ARM: SoC driver updates for 5.1	2019-03-06 09:41:12 -08:00
cdrom
char	ipmi: fix sleep-in-atomic in free_user at cleanup SRCU user->release_barrier	2019-04-17 10:29:27 -05:00
clk	clk: imx: Fix PLL_1416X not rounding rates	2019-04-12 14:21:43 -07:00
clocksource	clocksource/drivers/timer-ti-dm: Remove omap_dm_timer_set_load_start	2019-04-16 14:26:54 +02:00
connector	connector: fix unsafe usage of ->real_parent	2019-03-08 15:06:38 -08:00
cpufreq	cpufreq/intel_pstate: Load only on Intel hardware	2019-04-01 23:39:23 +02:00
cpuidle	cpuidle: governor: Add new governors to cpuidle_governors again	2019-03-12 23:46:55 +01:00
crypto	crypto: caam - fix copy of next buffer for xcbc and cmac	2019-03-28 13:54:32 +08:00
dax	device-dax for 5.1	2019-03-16 13:05:32 -07:00
dca
devfreq
dio
dma	dmaengine: mediatek-cqdma: fix wrong register usage in mtk_cqdma_start	2019-04-26 17:26:38 +05:30
dma-buf
edac	Merge branch 'ras-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2019-03-08 09:11:39 -08:00
eisa
extcon	extcon: ptn5150: fix COMPILE_TEST dependencies	2019-04-05 10:08:37 +09:00
firewire
firmware	memblock: drop memblock_alloc_*_nopanic() variants	2019-03-12 10:04:02 -07:00
fmc
fpga
fsi
gnss
gpio	gpio: Fix gpiochip_add_data_with_key() error path	2019-04-25 09:12:00 +02:00
gpu	drm/imx: fix DP CSC handling	2019-04-26 10:33:33 +10:00
hid	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input	2019-04-19 10:28:27 -07:00
hsi
hv	Char/Misc driver patches for 5.1-rc1	2019-03-06 14:18:59 -08:00
hwmon	hwmon: (ntc_thermistor) Fix temperature type reporting	2019-03-29 09:51:44 -07:00
hwspinlock
hwtracing	ARM updates for 5.1-rc1	2019-03-15 14:37:46 -07:00
i2c	gcc-9: don't warn about uninitialized variable	2019-05-01 11:07:40 -07:00
i3c	i3c: dw: Fix dw_i3c_master_disable controller by using correct mask	2019-04-10 12:46:20 +02:00
ide	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/ide	2019-03-11 09:34:00 -07:00
idle
iio	iio: core: fix a possible circular locking dependency	2019-03-31 11:11:31 +01:00
infiniband	rdma: fix build errors on s390 and MIPS due to bad ZERO_PAGE use	2019-04-29 09:48:53 -07:00
input	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input	2019-04-27 16:27:02 -07:00
interconnect
iommu	iommu/amd: Set exclusion range correctly	2019-04-12 12:59:45 +02:00
ipack
irqchip	A couple more MIPS fixes:	2019-04-22 11:54:47 -07:00
isdn	isdn: bas_gigaset: use usb_fill_int_urb() properly	2019-05-05 09:54:08 -07:00
leds	leds: trigger: netdev: use memcpy in device_name_store	2019-03-30 19:09:32 +01:00
lightnvm	lightnvm: pblk: fix crash in pblk_end_partial_read due to multipage bvecs	2019-04-10 12:17:01 -06:00
macintosh	treewide: add checks for the return value of memblock_alloc*()	2019-03-12 10:04:02 -07:00
mailbox	mailbox: imx: keep MU irq working during suspend/resume	2019-03-11 02:51:43 -05:00
mcb
md	dm integrity: fix deadlock with overlapping I/O	2019-04-05 18:49:08 -04:00
media	DMA mapping updates for 5.1	2019-03-10 11:54:48 -07:00
memory
memstick
message
mfd	mfd: sun6i-prcm: Allow to compile with COMPILE_TEST	2019-04-03 08:38:07 +01:00
misc	misc: fastrpc: add checked value for dma_set_mask	2019-04-02 17:56:54 +02:00
mmc	mmc: sdhci-omap: Don't finish_mrq() on a command error during tuning	2019-04-11 12:40:32 +02:00
mtd	mtd: rawnand: marvell: Clean the controller state before each operation	2019-04-25 23:21:51 +02:00
mux
net	net: ucc_geth - fix Oops when changing number of buffers in the ring	2019-05-05 10:33:01 -07:00
nfc	spi: ST ST95HF NFC: declare missing of table	2019-04-23 10:44:44 -07:00
ntb	Fixes for switchtec debugability and mapping table entries, NTB	2019-03-15 14:32:59 -07:00
nubus
nvdimm	libnvdimm/pmem: fix a possible OOB access when read and write pmem	2019-04-07 14:36:04 -07:00
nvme	nvmet: fix discover log page when offsets are used	2019-04-11 17:28:30 +02:00
nvmem	Char/Misc driver patches for 5.1-rc1	2019-03-06 14:18:59 -08:00
of	of_net: Fix residues after of_get_nvmem_mac_address removal	2019-04-19 11:58:30 -07:00
opp	PM / OPP: Update performance state when freq == old_freq	2019-03-12 09:45:56 +01:00
oprofile
parisc	Revert: parisc: Use F_EXTEND() macro in iosapic code	2019-04-06 19:07:55 +02:00
parport	Revert "parport: daisy: use new parport device model"	2019-03-25 14:49:00 -07:00
pci	PCI/LINK: Add Kconfig option (default off)	2019-05-02 08:34:32 -05:00
pcmcia
perf	arm64 updates for 5.1:	2019-03-10 10:17:23 -07:00
phy	phy: sun4i-usb: Support set_mode to USB_HOST for non-OTG PHYs	2019-03-26 16:48:55 +09:00
pinctrl	This is the bulk of pin control changes for the v5.1 kernel cycle.	2019-03-11 11:12:50 -07:00
platform	Here's more than a handful of clk driver fixes for changes that came in	2019-04-13 14:33:56 -07:00
pnp	ACPI/ACPICA: Trivial: fix spelling mistakes and fix whitespace formatting	2019-02-24 21:12:01 +01:00
power	Power Supply Fixes for 5.1 cycle	2019-05-01 14:57:23 -07:00
powercap
pps
ps3
ptp	Merge branch 'timers-2038-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2019-03-05 14:08:26 -08:00
pwm	pwm: atmel: Remove useless symbolic definitions	2019-03-04 12:52:49 +01:00
rapidio	rapidio/mport_cdev: mark expected switch fall-through	2019-03-07 18:32:02 -08:00
ras
regulator	regulator: mc13xxx: Constify regulator_ops variables	2019-03-04 00:01:08 +00:00
remoteproc	remoteproc updates for v5.1	2019-03-14 09:00:06 -07:00
reset	reset: meson-audio-arb: Fix missing .owner setting of reset_controller_dev	2019-03-25 16:22:10 +01:00
rpmsg
rtc	rtc: da9063: set uie_unsupported when relevant	2019-04-02 23:33:09 +02:00
s390	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-04-24 16:18:59 -07:00
sbus
scsi	SCSI fixes on 20190420	2019-04-20 12:52:23 -07:00
sfi
sh
siox
slimbus
sn
soc	This pull request brings in a build fix for arm64 with bcm2835	2019-03-18 10:31:24 -07:00
soundwire
spi	pci-v5.1-changes	2019-03-09 14:57:08 -08:00
spmi
ssb
staging	staging: comedi: ni_usb6501: Fix possible double-free of ->usb_rx_buf	2019-04-17 11:59:24 +02:00
target	SCSI misc on 20190315	2019-03-16 12:51:50 -07:00
tc
tee	ARM: SoC driver updates for 5.1	2019-03-06 09:41:12 -08:00
thermal	Merge branches 'fixes' and 'thermal-intel' into next	2019-03-18 22:37:44 +08:00
thunderbolt
tty	sc16is7xx: put err_spi and err_i2c into correct #ifdef	2019-04-19 14:09:23 +02:00
uio
usb	USB: yurex: Fix protection fault after device removal	2019-04-25 11:11:41 +02:00
uwb
vfio	vfio/type1: Limit DMA mappings per container	2019-04-03 12:43:05 -06:00
vhost	vhost: reject zero size iova range	2019-04-10 22:45:38 -07:00
video	fbdev changes for v5.1:	2019-03-15 14:22:59 -07:00
virt	virt: vbox: Implement passing requestor info to the host for VirtualBox 6.0.x	2019-03-28 01:55:18 +09:00
virtio	virtio: Honour 'may_reduce_num' in vring_create_virtqueue	2019-04-08 17:05:52 -04:00
visorbus
vlynq
vme
w1	USB: w1 ds2490: Fix bug caused by improper use of altsetting array	2019-04-25 11:11:41 +02:00
watchdog	linux-watchdog 5.1-rc1 tag	2019-03-11 11:22:15 -07:00
xen	xen: fixes for 5.1-rc4	2019-04-07 06:12:10 -10:00
zorro
Kconfig
Makefile	IOMMU Updates for Linux v5.1	2019-03-10 12:29:52 -07:00