linux/net/l2tp
Tom Parkin ebb4f5e6e4 l2tp: don't BUG_ON seqfile checks in l2tp_ppp
checkpatch advises that WARN_ON and recovery code are preferred over
BUG_ON which crashes the kernel.

l2tp_ppp has a BUG_ON check of struct seq_file's private pointer in
pppol2tp_seq_start prior to accessing data through that pointer.

Rather than crashing, we can simply bail out early and return NULL in
order to terminate the seq file processing in much the same way as we do
when reaching the end of tunnel/session instances to render.

Retain a WARN_ON to help trace possible bugs in this area.

Signed-off-by: Tom Parkin <tparkin@katalix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2020-07-24 17:19:14 -07:00
..
Kconfig treewide: replace '---help---' in Kconfig files with 'help' 2020-06-14 01:57:21 +09:00
l2tp_core.c l2tp: remove BUG_ON in l2tp_tunnel_closeall 2020-07-24 17:19:14 -07:00
l2tp_core.h l2tp: prefer using BIT macro 2020-07-22 18:08:39 -07:00
l2tp_debugfs.c l2tp: WARN_ON rather than BUG_ON in l2tp_dfs_seq_start 2020-07-24 17:19:14 -07:00
l2tp_eth.c l2tp: cleanup comments 2020-07-22 18:08:39 -07:00
l2tp_ip6.c l2tp: avoid multiple assignments 2020-07-24 17:19:14 -07:00
l2tp_ip.c l2tp: avoid multiple assignments 2020-07-24 17:19:14 -07:00
l2tp_netlink.c l2tp: cleanup netlink tunnel create address handling 2020-07-23 11:54:40 -07:00
l2tp_ppp.c l2tp: don't BUG_ON seqfile checks in l2tp_ppp 2020-07-24 17:19:14 -07:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00