leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
e8d368ad20
linux/drivers/firmware/efi/libstub
History
Masahiro Yamada e8d368ad20 efi/libstub: Refactor the cmd_stubcopy Makefile command 
It took me a while to understand what is going on in the nested
if-blocks.

Simplify it by removing unneeded code.

  - if_changed automatically adds 'set -e', so any failure in the
    series of commands makes it immediately fail as a whole.
    So, the outer if block is entirely redundant.

  - Since commit 9c2af1c737 ("kbuild: add .DELETE_ON_ERROR special target"),
    GNU Make automatically deletes the target on any failure
    in its recipe. The explicit 'rm -f $@' is redundant.

  - Surrounding commands with ( ) will spawn a subshell to execute them
    in it, but it is rarely useful to do so.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-efi@vger.kernel.org
Link: http://lkml.kernel.org/r/20190328193429.21373-2-ard.biesheuvel@linaro.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2019-03-29 07:34:59 +01:00
..
arm32-stub.c efi: Replace GPL license boilerplate with SPDX headers 2019-02-04 08:27:25 +01:00
arm64-stub.c efi: Replace GPL license boilerplate with SPDX headers 2019-02-04 08:27:25 +01:00
arm-stub.c Merge branch 'efi-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip 2019-03-06 07:13:56 -08:00
efi-stub-helper.c efi/arm/arm64: Allow SetVirtualAddressMap() to be omitted 2019-02-04 08:27:26 +01:00
efistub.h efi/arm/arm64: Allow SetVirtualAddressMap() to be omitted 2019-02-04 08:27:26 +01:00
fdt.c efi/arm/arm64: Allow SetVirtualAddressMap() to be omitted 2019-02-04 08:27:26 +01:00
gop.c efi: Replace GPL license boilerplate with SPDX headers 2019-02-04 08:27:25 +01:00
Makefile efi/libstub: Refactor the cmd_stubcopy Makefile command 2019-03-29 07:34:59 +01:00
random.c efi: Replace GPL license boilerplate with SPDX headers 2019-02-04 08:27:25 +01:00
secureboot.c efi: Replace GPL license boilerplate with SPDX headers 2019-02-04 08:27:25 +01:00
string.c License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
tpm.c efi: Replace GPL license boilerplate with SPDX headers 2019-02-04 08:27:25 +01:00