linux/net/8021q
Evgeniy Polyakov e7c243c925 [VLAN/BRIDGE]: Fix "skb_pull_rcsum - Fatal exception in interrupt"
I tried to preserve bridging code as it was before, but logic is quite
strange - I think we should free skb on error, since it is already
unshared and thus will just leak.

Herbert Xu states:

> +	if ((skb = skb_share_check(skb, GFP_ATOMIC)) == NULL)
> +		goto out;

If this happens it'll be a double-free on skb since we'll
return NF_DROP which makes the caller free it too.

We could return NF_STOLEN to prevent that but I'm not sure
whether that's correct netfilter semantics.  Patrick, could
you please make a call on this?

Patrick McHardy states:

NF_STOLEN should work fine here.

Signed-off-by: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>
2007-08-26 18:35:47 -07:00
..
Kconfig [NET]: move config options out to individual protocols 2005-07-11 21:13:56 -07:00
Makefile [VLAN]: Use rtnl_link API 2007-07-10 22:15:03 -07:00
vlan_dev.c [VLAN/BRIDGE]: Fix "skb_pull_rcsum - Fatal exception in interrupt" 2007-08-26 18:35:47 -07:00
vlan_netlink.c [RTNETLINK]: rtnl_link: allow specifying initial device address 2007-07-11 19:45:36 -07:00
vlan.c [8021Q]: vlan_ioctl_handler: fix return value 2007-07-24 15:37:11 -07:00
vlan.h [VLAN]: Fix promiscous/allmulti synchronization races 2007-07-14 18:52:56 -07:00
vlanproc.c [VLAN] net/8021q/vlanproc.c: fix check-after-use 2007-08-14 17:39:43 -07:00
vlanproc.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00