We don't need to hold onto mode_config.mutex any more to keep the fb objects around. And locking dev->struct_mutex is also not required, since omap_gem_describe only reads data anyway. And for a debug interface it's better to grab fewer locks in case the driver is deadlocked already ... The only thing we need is to hold onto mode_config.fb_lock to ensure the user-created fbs don't disappear. The fbcon fb doesn't need any protection, since it lives as long as the driver (and so the debugfs files) itself. And if the teardown/setup isn't following the right sequence grabbing locks won't prevent a NULL deref on priv->fbdev if the fb is not yet (or no longer) there. Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> Signed-off-by: Rob Clark <robdclark@gmail.com> |
||
---|---|---|
.. | ||
Kconfig | ||
Makefile | ||
omap_connector.c | ||
omap_crtc.c | ||
omap_debugfs.c | ||
omap_dmm_priv.h | ||
omap_dmm_tiler.c | ||
omap_dmm_tiler.h | ||
omap_drv.c | ||
omap_drv.h | ||
omap_encoder.c | ||
omap_fb.c | ||
omap_fbdev.c | ||
omap_gem_dmabuf.c | ||
omap_gem_helpers.c | ||
omap_gem.c | ||
omap_irq.c | ||
omap_plane.c | ||
tcm-sita.c | ||
tcm-sita.h | ||
tcm.h | ||
TODO |