linux/drivers/isdn/i4l
Matthias Goebl 7fde4d779b [ISDN]: i4l: Fix DLE handling for i4l-audio
The DLE handling in i4l-audio seems to be broken.

It produces spurious DLEs so asterisk 1.2.24 with chan_modem_i4l
gets irritated, the error message is:
"chan_modem_i4l.c:450 i4l_read: Value of escape is ^ (17)".
-> There shouldn't be a DLE-^.
If a spurious DLE-ETX occurs, the audio connection even dies.
I use a "AVM Fritz!PCI" isdn card.

I found two issues that only appear if ISDN_AUDIO_SKB_DLECOUNT(skb) > 0:
- The loop in isdn_tty.c:isdn_tty_try_read() doesn't escape a DLE if it's
  the last character.

- The loop in isdn_common.c:isdn_readbchan_tty() doesn't copy its characters,
  it only remembers the last one ("last = *p;").

  Compare it with the loop in isdn_common.c:isdn_readbchan(), that *does*
  copy them ("*cp++ = *p;") correctly.
  The special handling of the "last" character made it more difficult.
  I compared it to linux-2.4.19: There was no "last"-handling and both loops
  did escape and copy all characters correctly.

Signed-off-by: Matthias Goebl <matthias.goebl@goebl.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
2008-01-04 03:55:44 -08:00
..
isdn_audio.c [PATCH] getting rid of all casts of k[cmz]alloc() calls 2006-12-13 09:05:58 -08:00
isdn_audio.h [PATCH] drivers/isdn/i4l/: possible cleanups 2005-06-25 16:24:56 -07:00
isdn_bsdcomp.c [ISDN]: Get rid of some pointless allocation casts in common and bsd comp. 2007-08-26 18:35:46 -07:00
isdn_common.c [ISDN]: i4l: Fix DLE handling for i4l-audio 2008-01-04 03:55:44 -08:00
isdn_common.h [PATCH] TTY layer buffering revamp 2006-01-10 08:01:59 -08:00
isdn_concap.c [PATCH] drivers/isdn/i4l/: possible cleanups 2005-06-25 16:24:56 -07:00
isdn_concap.h [PATCH] drivers/isdn/i4l/: possible cleanups 2005-06-25 16:24:56 -07:00
isdn_net.c isdn: avoid copying overly-long strings 2007-11-26 19:08:18 -08:00
isdn_net.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
isdn_ppp.c [ISDN]: Remove local copy of device name to make sure renames work. 2007-10-15 12:26:37 -07:00
isdn_ppp.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
isdn_tty.c [ISDN]: i4l: Fix DLE handling for i4l-audio 2008-01-04 03:55:44 -08:00
isdn_tty.h Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
isdn_ttyfax.c [PATCH] drivers/isdn/i4l/: possible cleanups 2005-06-25 16:24:56 -07:00
isdn_ttyfax.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
isdn_v110.c [PATCH] isdn: replace kmalloc+memset with kzalloc 2006-12-08 08:29:01 -08:00
isdn_v110.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
isdn_x25iface.c [PATCH] SKB leak in drivers/isdn/i4l/isdn_x25iface.c 2006-06-29 10:26:21 -07:00
isdn_x25iface.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
Kconfig Use menuconfig objects - CONFIG_ISDN_I4L 2007-07-21 17:49:17 -07:00
Makefile Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00