linux/sound/soc/intel
Colin Ian King de5afce2a2
ASoC: Intel: bytcr_rt565: fix missing assignment to ret_val
Currently, the check that ret_val is not -ENOENT is always true and
the quirk bit BYT_RY5651_MCLK_EN is never being cleared because ret_val
is always zero at this point from a previous assignment earlier on.
I believe that ret_val should actually be assigned to the return from
devm_clk_get() as this can return -ENOENT (from a deeper call to
clk_get_sys) and that was the original intention to check this.

Detected by CoverityScan, CID#1460228 ("Logically dead code")

Fixes: 02c0a3b304 ("ASoC: Intel: bytcr_rt5651: add MCLK, quirks and cleanups")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
2018-05-03 10:23:54 +09:00
..
atom Merge branch 'topic/component-platform' of https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound into asoc-intel 2018-03-01 19:55:59 +00:00
baytrail ASoC: intel: baytrail: replace platform to component 2018-02-12 11:45:10 +00:00
boards ASoC: Intel: bytcr_rt565: fix missing assignment to ret_val 2018-05-03 10:23:54 +09:00
common ASoC: Intel: add nau8824 sound card 2018-03-01 16:48:46 +00:00
haswell ASoC: intel: haswell: replace platform to component 2018-02-12 11:45:11 +00:00
skylake ASoC: Intel: Skylake: Disable clock and power gating during FW/LIB download 2018-03-13 09:29:14 -07:00
Kconfig ASoC: Intel: atom: fix ACPI/PCI Kconfig 2018-04-12 15:46:34 +01:00
Makefile ASoC: Intel: Fix Kconfig with top-level selector 2018-01-08 16:18:48 +00:00