998c2034c6
Kbuild test robot reports the following problem on ARM:
for 'xen_setup_callback_vector' [-Wmissing-prototypes]
1664 | void xen_setup_callback_vector(void) {}
| ^~~~~~~~~~~~~~~~~~~~~~~~~
The problem is that xen_setup_callback_vector is a x86 only thing, its
definition is present in arch/x86/xen/xen-ops.h but not on ARM. In
events_base.c there is a stub for !CONFIG_XEN_PVHVM but it is not declared
as 'static'.
On x86 the situation is hardly better: drivers/xen/events/events_base.c
doesn't include 'xen-ops.h' from arch/x86/xen/, it includes its namesake
from include/xen/ which also results in a 'no previous prototype' warning.
Currently, xen_setup_callback_vector() has two call sites: one in
drivers/xen/events_base.c and another in arch/x86/xen/suspend_hvm.c. The
former is placed under #ifdef CONFIG_X86 and the later is only compiled
in when CONFIG_XEN_PVHVM.
Resolve the issue by moving xen_setup_callback_vector() declaration to
arch neutral 'include/xen/hvm.h' as the implementation lives in arch
neutral drivers/xen/events/events_base.c.
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Juergen Gross <jgross@suse.com>
Link: https://lkml.kernel.org/r/20200520161600.361895-1-vkuznets@redhat.com
68 lines
2.5 KiB
C
68 lines
2.5 KiB
C
/*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
* of this software and associated documentation files (the "Software"), to
|
|
* deal in the Software without restriction, including without limitation the
|
|
* rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
|
|
* sell copies of the Software, and to permit persons to whom the Software is
|
|
* furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
|
|
* DEALINGS IN THE SOFTWARE.
|
|
*/
|
|
|
|
#ifndef __XEN_PUBLIC_HVM_HVM_OP_H__
|
|
#define __XEN_PUBLIC_HVM_HVM_OP_H__
|
|
|
|
#include <xen/interface/xen.h>
|
|
|
|
/* Get/set subcommands: the second argument of the hypercall is a
|
|
* pointer to a xen_hvm_param struct. */
|
|
#define HVMOP_set_param 0
|
|
#define HVMOP_get_param 1
|
|
struct xen_hvm_param {
|
|
domid_t domid; /* IN */
|
|
uint32_t index; /* IN */
|
|
uint64_t value; /* IN/OUT */
|
|
};
|
|
DEFINE_GUEST_HANDLE_STRUCT(xen_hvm_param);
|
|
|
|
/* Hint from PV drivers for pagetable destruction. */
|
|
#define HVMOP_pagetable_dying 9
|
|
struct xen_hvm_pagetable_dying {
|
|
/* Domain with a pagetable about to be destroyed. */
|
|
domid_t domid;
|
|
/* guest physical address of the toplevel pagetable dying */
|
|
aligned_u64 gpa;
|
|
};
|
|
typedef struct xen_hvm_pagetable_dying xen_hvm_pagetable_dying_t;
|
|
DEFINE_GUEST_HANDLE_STRUCT(xen_hvm_pagetable_dying_t);
|
|
|
|
enum hvmmem_type_t {
|
|
HVMMEM_ram_rw, /* Normal read/write guest RAM */
|
|
HVMMEM_ram_ro, /* Read-only; writes are discarded */
|
|
HVMMEM_mmio_dm, /* Reads and write go to the device model */
|
|
};
|
|
|
|
#define HVMOP_get_mem_type 15
|
|
/* Return hvmmem_type_t for the specified pfn. */
|
|
struct xen_hvm_get_mem_type {
|
|
/* Domain to be queried. */
|
|
domid_t domid;
|
|
/* OUT variable. */
|
|
uint16_t mem_type;
|
|
uint16_t pad[2]; /* align next field on 8-byte boundary */
|
|
/* IN variable. */
|
|
uint64_t pfn;
|
|
};
|
|
DEFINE_GUEST_HANDLE_STRUCT(xen_hvm_get_mem_type);
|
|
|
|
#endif /* __XEN_PUBLIC_HVM_HVM_OP_H__ */
|