leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
cc9b499a1f71696054a2771aae504c53eecff31d
linux/net/tipc
History
Xin Long 42dec1dbe3 tipc: add NULL pointer check before calling kfree_rcu 
Unlike kfree(p), kfree_rcu(p, rcu) won't do NULL pointer check. When
tipc_nametbl_remove_publ returns NULL, the panic below happens:

   BUG: unable to handle kernel NULL pointer dereference at 0000000000000068
   RIP: 0010:__call_rcu+0x1d/0x290
   Call Trace:
    <IRQ>
    tipc_publ_notify+0xa9/0x170 [tipc]
    tipc_node_write_unlock+0x8d/0x100 [tipc]
    tipc_node_link_down+0xae/0x1d0 [tipc]
    tipc_node_check_dest+0x3ea/0x8f0 [tipc]
    ? tipc_disc_rcv+0x2c7/0x430 [tipc]
    tipc_disc_rcv+0x2c7/0x430 [tipc]
    ? tipc_rcv+0x6bb/0xf20 [tipc]
    tipc_rcv+0x6bb/0xf20 [tipc]
    ? ip_route_input_slow+0x9cf/0xb10
    tipc_udp_recv+0x195/0x1e0 [tipc]
    ? tipc_udp_is_known_peer+0x80/0x80 [tipc]
    udp_queue_rcv_skb+0x180/0x460
    udp_unicast_rcv_skb.isra.56+0x75/0x90
    __udp4_lib_rcv+0x4ce/0xb90
    ip_local_deliver_finish+0x11c/0x210
    ip_local_deliver+0x6b/0xe0
    ? ip_rcv_finish+0xa9/0x410
    ip_rcv+0x273/0x362

Fixes: 97ede29e80 ("tipc: convert name table read-write lock to RCU")
Reported-by: Li Shuang <shuali@redhat.com>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2019-09-05 09:58:49 +02:00
..
addr.c
tipc: initialise addr_trail_end when setting node addresses
2019-08-11 21:40:04 -07:00
addr.h
tipc: add 128-bit node identifier
2018-03-23 13:12:18 -04:00
bcast.c
tipc: rename function msg_get_wrapped() to msg_inner_hdr()
2019-06-25 13:42:54 -07:00
bcast.h
tipc: fix a null pointer deref
2019-03-21 09:56:55 -07:00
bearer.c
tipc: use rcu dereference functions properly
2019-07-07 13:18:53 -07:00
bearer.h
tipc: enable tracepoints in tipc
2018-12-19 11:49:24 -08:00
core.c
tipc: change to use register_pernet_device
2019-06-22 16:51:47 -07:00
core.h
tipc: introduce new capability flag for cluster
2019-03-19 13:56:17 -07:00
diag.c
tipc: switch to rhashtable iterator
2018-08-29 18:04:54 -07:00
discover.c
tipc: fix lockdep warning when reinitilaizing sockets
2018-11-17 22:01:31 -08:00
discover.h
tipc: some cleanups in the file discover.c
2018-03-23 13:12:17 -04:00
eth_media.c
tipc: make media address offset a common define
2015-02-27 18:18:48 -05:00
group.c
tipc: purge deferredq list for each grp member in tipc_group_delete
2019-06-16 20:42:05 -07:00
group.h
tipc: extend sock diag for group communication
2018-06-30 21:05:42 +09:00
ib_media.c
tipc: rename media/msg related definitions
2015-02-27 18:18:48 -05:00
Kconfig
docs: kbuild: convert docs to ReST and rename to *.rst
2019-06-14 14:21:21 -06:00
link.c
tipc: fix false detection of retransmit failures
2019-08-16 16:27:13 -07:00
link.h
tipc: fix missing Name entries due to half-failover
2019-05-04 00:59:51 -04:00
Makefile
tipc: enable tracepoints in tipc
2018-12-19 11:49:24 -08:00
monitor.c
netlink: make nla_nest_start() add NLA_F_NESTED flag
2019-04-27 17:03:44 -04:00
monitor.h
tipc: dump monitor attributes
2016-07-26 14:26:42 -07:00
msg.c
tipc: buffer overflow handling in listener socket
2018-09-29 11:24:22 -07:00
msg.h
tipc: fix false detection of retransmit failures
2019-08-16 16:27:13 -07:00
name_distr.c
tipc: add NULL pointer check before calling kfree_rcu
2019-09-05 09:58:49 +02:00
name_distr.h
tipc: permit overlapping service ranges in name table
2018-03-31 22:19:52 -04:00
name_table.c
netlink: make nla_nest_start() add NLA_F_NESTED flag
2019-04-27 17:03:44 -04:00
name_table.h
tipc: eliminate message disordering during binding table update
2018-10-22 19:29:12 -07:00
net.c
netlink: make validation more configurable for future strictness
2019-04-27 17:07:21 -04:00
net.h
tipc: fix lockdep warning when reinitilaizing sockets
2018-11-17 22:01:31 -08:00
netlink_compat.c
tipc: compat: allow tipc commands without arguments
2019-08-01 18:14:00 -04:00
netlink.c
tipc: fix missing indentation in source code
2019-06-24 07:29:45 -07:00
netlink.h
tipc: make cluster size threshold for monitoring configurable
2016-07-26 14:26:42 -07:00
node.c
tipc: initialize 'validated' field of received packets
2019-07-17 15:24:38 -07:00
node.h
tipc: improve TIPC throughput by Gap ACK blocks
2019-04-04 18:29:25 -07:00
socket.c
tipc: fix unitilized skb list crash
2019-07-30 14:39:36 -07:00
socket.h
tipc: add trace_events for tipc socket
2018-12-19 11:49:24 -08:00
subscr.c
tipc: fix unbalanced reference counter
2018-04-12 21:46:10 -04:00
subscr.h
tipc: fix modprobe tipc failed after switch order of device registration
2019-05-20 10:45:43 -07:00
sysctl.c
proc/sysctl: add shared variables for range check
2019-07-18 17:08:07 -07:00
topsrv.c
tipc: Fix a typo
2019-07-21 11:41:01 -07:00
topsrv.h
tipc: rename tipc_server to tipc_topsrv
2018-02-16 15:26:34 -05:00
trace.c
tipc: remove unneeded semicolon in trace.c
2019-01-17 22:04:43 -08:00
trace.h
tipc: add trace_events for tipc bearer
2018-12-19 11:49:25 -08:00
udp_media.c
tipc: use rcu dereference functions properly
2019-07-07 13:18:53 -07:00
udp_media.h
tipc: implement configuration of UDP media MTU
2018-04-20 11:04:05 -04:00