b9a1a74381
ARM64 allmodconfig produces a bunch of warnings when building the samsung ASoC code: sound/soc/samsung/dmaengine.c: In function 'samsung_asoc_init_dma_data': sound/soc/samsung/dmaengine.c:53:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] playback_data->filter_data = (void *)playback->channel; sound/soc/samsung/dmaengine.c:60:31: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] capture_data->filter_data = (void *)capture->channel; We could easily shut up the warning by adding an intermediate cast, but there is a bigger underlying problem: The use of IORESOURCE_DMA to pass data from platform code to device drivers is dubious to start with, as what we really want is a pointer that can be passed into a filter function. Note that on s3c64xx, the pl08x DMA data is already a pointer, but gets cast to resource_size_t so we can pass it as a resource, and it then gets converted back to a pointer. In contrast, the data we pass for s3c24xx is an index into a device specific table, and we artificially convert that into a pointer for the filter function. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Signed-off-by: Mark Brown <broonie@kernel.org>
82 lines
2.4 KiB
C
82 lines
2.4 KiB
C
/*
|
|
* dmaengine.c - Samsung dmaengine wrapper
|
|
*
|
|
* Author: Mark Brown <broonie@linaro.org>
|
|
* Copyright 2013 Linaro
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* version 2 as published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/amba/pl08x.h>
|
|
#include <linux/platform_data/dma-s3c24xx.h>
|
|
|
|
#include <sound/core.h>
|
|
#include <sound/pcm.h>
|
|
#include <sound/pcm_params.h>
|
|
#include <sound/dmaengine_pcm.h>
|
|
#include <sound/soc.h>
|
|
#include <sound/soc-dai.h>
|
|
|
|
#include "dma.h"
|
|
|
|
#ifdef CONFIG_ARCH_S3C64XX
|
|
#define filter_fn pl08x_filter_id
|
|
#elif defined(CONFIG_ARCH_S3C24XX)
|
|
#define filter_fn s3c24xx_dma_filter
|
|
#else
|
|
#define filter_fn NULL
|
|
#endif
|
|
|
|
static const struct snd_dmaengine_pcm_config samsung_dmaengine_pcm_config = {
|
|
.prepare_slave_config = snd_dmaengine_pcm_prepare_slave_config,
|
|
.compat_filter_fn = filter_fn,
|
|
};
|
|
|
|
void samsung_asoc_init_dma_data(struct snd_soc_dai *dai,
|
|
struct s3c_dma_params *playback,
|
|
struct s3c_dma_params *capture)
|
|
{
|
|
struct snd_dmaengine_dai_dma_data *playback_data = NULL;
|
|
struct snd_dmaengine_dai_dma_data *capture_data = NULL;
|
|
|
|
if (playback) {
|
|
playback_data = &playback->dma_data;
|
|
playback_data->filter_data = playback->slave;
|
|
playback_data->chan_name = playback->ch_name;
|
|
playback_data->addr = playback->dma_addr;
|
|
playback_data->addr_width = playback->dma_size;
|
|
}
|
|
if (capture) {
|
|
capture_data = &capture->dma_data;
|
|
capture_data->filter_data = capture->slave;
|
|
capture_data->chan_name = capture->ch_name;
|
|
capture_data->addr = capture->dma_addr;
|
|
capture_data->addr_width = capture->dma_size;
|
|
}
|
|
|
|
snd_soc_dai_init_dma_data(dai, playback_data, capture_data);
|
|
}
|
|
EXPORT_SYMBOL_GPL(samsung_asoc_init_dma_data);
|
|
|
|
int samsung_asoc_dma_platform_register(struct device *dev)
|
|
{
|
|
return devm_snd_dmaengine_pcm_register(dev,
|
|
&samsung_dmaengine_pcm_config,
|
|
SND_DMAENGINE_PCM_FLAG_CUSTOM_CHANNEL_NAME |
|
|
SND_DMAENGINE_PCM_FLAG_COMPAT);
|
|
}
|
|
EXPORT_SYMBOL_GPL(samsung_asoc_dma_platform_register);
|
|
|
|
MODULE_AUTHOR("Mark Brown <broonie@linaro.org>");
|
|
MODULE_DESCRIPTION("Samsung dmaengine ASoC driver");
|
|
MODULE_LICENSE("GPL");
|