Pull drm updates from Dave Airlie:
"Highlights:
- New driver for logicvc - which is a display IP core.
- EDID parser rework to add new extensions
- fbcon scrolling improvements
- i915 has some more DG2 work but not enabled by default, but should
have enough features for userspace to work now.
Otherwise it's lots of work all over the place. Detailed summary:
New driver:
- logicvc
vfio:
- use aperture API
core:
- of: Add data-lane helpers and convert drivers
- connector: Remove deprecated ida_simple_get()
media:
- Add various RGB666 and RGB888 format constants
panel:
- Add HannStar HSD101PWW
- Add ETML0700Y5DHA
dma-buf:
- add sync-file API
- set dma mask for udmabuf devices
fbcon:
- Improve scrolling performance
- Sanitize input
fbdev:
- device unregistering fixes
- vesa: Support COMPILE_TEST
- Disable firmware-device registration when first native driver loads
aperture:
- fix segfault during hot-unplug
- export for use with other subsystems
client:
- use driver validated modes
dp:
- aux: make probing more reliable
- mst: Read extended DPCD capabilities during system resume
- Support waiting for HDP signal
- Port-validation fixes
edid:
- CEA data-block iterators
- struct drm_edid introduction
- implement HF-EEODB extension
gem:
- don't use fb format non-existing planes
probe-helper:
- use 640x480 as displayport fallback
scheduler:
- don't kill jobs in interrupt context
bridge:
- Add support for i.MX8qxp and i.MX8qm
- lots of fixes/cleanups
- Add TI-DLPC3433
- fy07024di26a30d: Optional GPIO reset
- ldb: Add reg and reg-name properties to bindings, Kconfig fixes
- lt9611: Fix display sensing;
- tc358767: DSI/DPI refactoring and DSI-to-eDP support, DSI lane handling
- tc358775: Fix clock settings
- ti-sn65dsi83: Allow GPIO to sleep
- adv7511: I2C fixes
- anx7625: Fix error handling; DPI fixes; Implement HDP timeout via callback
- fsl-ldb: Drop DE flip
- ti-sn65dsi86: Convert to atomic modesetting
amdgpu:
- use atomic fence helpers in DM
- fix VRAM address calculations
- export CRTC bpc via debugfs
- Initial devcoredump support
- Enable high priority gfx queue on asics which support it
- Adjust GART size on newer APUs for S/G display
- Soft reset for GFX 11 / SDMA 6
- Add gfxoff status query for vangogh
- Fix timestamps for cursor only commits
- Adjust GART size on newer APUs for S/G display
- fix buddy memory corruption
amdkfd:
- MMU notifier fixes
- P2P DMA support using dma-buf
- Add available memory IOCTL
- HMM profiler support
- Simplify GPUVM validation
- Unified memory for CWSR save/restore area
i915:
- General driver clean-up
- DG2 enabling (still under force probe)
- DG2 small BAR memory support
- HuC loading support
- DG2 workarounds
- DG2/ATS-M device IDs added
- Ponte Vecchio prep work and new blitter engines
- add Meteorlake support
- Fix sparse warnings
- DMC MMIO range checks
- Audio related fixes
- Runtime PM fixes
- PSR fixes
- Media freq factor and per-gt enhancements
- DSI fixes for ICL+
- Disable DMC flip queue handlers
- ADL_P voltage swing updates
- Use more the VBT for panel information
- Fix on Type-C ports with TBT mode
- Improve fastset and allow seamless M/N changes
- Accept more fixed modes with VRR/DMRRS panels
- Disable connector polling for a headless SKU
- ADL-S display PLL w/a
- Enable THP on Icelake and beyond
- Fix i915_gem_object_ggtt_pin_ww regression on old platforms
- Expose per tile media freq factor in sysfs
- Fix dma_resv fence handling in multi-batch execbuf
- Improve on suspend / resume time with VT-d enabled
- export CRTC bpc settings via debugfs
msm:
- gpu: a619 support
- gpu: Fix for unclocked GMU register access
- gpu: Devcore dump enhancements
- client utilization via fdinfo support
- fix fence rollover issue
- gem: Lockdep false-positive warning fix
- gem: Switch to pfn mappings
- WB support on sc7180
- dp: dropped custom bulk clock implementation
- fix link retraining on resolution change
- hdmi: dropped obsolete GPIO support
tegra:
- context isolation for host1x engines
- tegra234 soc support
mediatek:
- add vdosys0/1 for mt8195
- add MT8195 dp_intf driver
exynos:
- Fix resume function issue of exynos decon driver by calling
clk_disable_unprepare() properly if clk_prepare_enable() failed.
nouveau:
- set of misc fixes/cleanups
- display cleanups
gma500:
- Cleanup connector I2C handling
hyperv:
- Unify VRAM allocation of Gen1 and Gen2
meson:
- Support YUV422 output; Refcount fixes
mgag200:
- Support damage clipping
- Support gamma handling
- Protect concurrent HW access
- Fixes to connector
- Store model-specific limits in device-info structure
- fix PCI register init
panfrost:
- Valhall support
r128:
- Fix bit-shift overflow
rockchip:
- Locking fixes in error path
ssd130x:
- Fix built-in linkage
udl:
- Always advertize VGA connector
ast:
- Support multiple outputs
- fix black screen on resume
sun4i:
- HDMI PHY cleanups
vc4:
- Add support for BCM2711
vkms:
- Allocate output buffer with vmalloc()
mcde:
- Fix ref-count leak
mxsfb/lcdif:
- Support i.MX8MP LCD controller
stm/ltdc:
- Support dynamic Z order
- Support mirroring
ingenic:
- Fix display at maximum resolution"
* tag 'drm-next-2022-08-03' of git://anongit.freedesktop.org/drm/drm: (1480 commits)
drm/amd/display: Fix a compilation failure on PowerPC caused by FPU code
drm/amdgpu: enable support for psp 13.0.4 block
drm/amdgpu: add files for PSP 13.0.4
drm/amdgpu: add header files for MP 13.0.4
drm/amdgpu: correct RLC_RLCS_BOOTLOAD_STATUS offset and index
drm/amdgpu: send msg to IMU for the front-door loading
drm/amdkfd: use time_is_before_jiffies(a + b) to replace "jiffies - a > b"
drm/amdgpu: fix hive reference leak when reflecting psp topology info
drm/amd/pm: enable GFX ULV feature support for SMU13.0.0
drm/amd/pm: update driver if header for SMU 13.0.0
drm/amdgpu: move mes self test after drm sched re-started
drm/amdgpu: drop non-necessary call trace dump
drm/amdgpu: enable VCN cg and JPEG cg/pg
drm/amdgpu: vcn_4_0_2 video codec query
drm/amdgpu: add VCN_4_0_2 firmware support
drm/amdgpu: add VCN function in NBIO v7.7
drm/amdgpu: fix a vcn4 boot poll bug in emulation mode
drm/amd/amdgpu: add memory training support for PSP_V13
drm/amdkfd: remove an unnecessary amdgpu_bo_ref
drm/amd/pm: Add get_gfx_off_status interface for yellow carp
...
882 lines
25 KiB
C
882 lines
25 KiB
C
// SPDX-License-Identifier: MIT
|
|
/*
|
|
* Copyright © 2016-2019 Intel Corporation
|
|
*/
|
|
|
|
#include <linux/bitfield.h>
|
|
#include <linux/firmware.h>
|
|
#include <linux/highmem.h>
|
|
|
|
#include <drm/drm_cache.h>
|
|
#include <drm/drm_print.h>
|
|
|
|
#include "gem/i915_gem_lmem.h"
|
|
#include "intel_uc_fw.h"
|
|
#include "intel_uc_fw_abi.h"
|
|
#include "i915_drv.h"
|
|
#include "i915_reg.h"
|
|
|
|
static inline struct intel_gt *
|
|
____uc_fw_to_gt(struct intel_uc_fw *uc_fw, enum intel_uc_fw_type type)
|
|
{
|
|
if (type == INTEL_UC_FW_TYPE_GUC)
|
|
return container_of(uc_fw, struct intel_gt, uc.guc.fw);
|
|
|
|
GEM_BUG_ON(type != INTEL_UC_FW_TYPE_HUC);
|
|
return container_of(uc_fw, struct intel_gt, uc.huc.fw);
|
|
}
|
|
|
|
static inline struct intel_gt *__uc_fw_to_gt(struct intel_uc_fw *uc_fw)
|
|
{
|
|
GEM_BUG_ON(uc_fw->status == INTEL_UC_FIRMWARE_UNINITIALIZED);
|
|
return ____uc_fw_to_gt(uc_fw, uc_fw->type);
|
|
}
|
|
|
|
#ifdef CONFIG_DRM_I915_DEBUG_GUC
|
|
void intel_uc_fw_change_status(struct intel_uc_fw *uc_fw,
|
|
enum intel_uc_fw_status status)
|
|
{
|
|
uc_fw->__status = status;
|
|
drm_dbg(&__uc_fw_to_gt(uc_fw)->i915->drm,
|
|
"%s firmware -> %s\n",
|
|
intel_uc_fw_type_repr(uc_fw->type),
|
|
status == INTEL_UC_FIRMWARE_SELECTED ?
|
|
uc_fw->path : intel_uc_fw_status_repr(status));
|
|
}
|
|
#endif
|
|
|
|
/*
|
|
* List of required GuC and HuC binaries per-platform.
|
|
* Must be ordered based on platform + revid, from newer to older.
|
|
*
|
|
* Note that RKL and ADL-S have the same GuC/HuC device ID's and use the same
|
|
* firmware as TGL.
|
|
*/
|
|
#define INTEL_GUC_FIRMWARE_DEFS(fw_def, guc_def) \
|
|
fw_def(DG2, 0, guc_def(dg2, 70, 1, 2)) \
|
|
fw_def(ALDERLAKE_P, 0, guc_def(adlp, 70, 1, 1)) \
|
|
fw_def(ALDERLAKE_S, 0, guc_def(tgl, 70, 1, 1)) \
|
|
fw_def(DG1, 0, guc_def(dg1, 70, 1, 1)) \
|
|
fw_def(ROCKETLAKE, 0, guc_def(tgl, 70, 1, 1)) \
|
|
fw_def(TIGERLAKE, 0, guc_def(tgl, 70, 1, 1)) \
|
|
fw_def(JASPERLAKE, 0, guc_def(ehl, 70, 1, 1)) \
|
|
fw_def(ELKHARTLAKE, 0, guc_def(ehl, 70, 1, 1)) \
|
|
fw_def(ICELAKE, 0, guc_def(icl, 70, 1, 1)) \
|
|
fw_def(COMETLAKE, 5, guc_def(cml, 70, 1, 1)) \
|
|
fw_def(COMETLAKE, 0, guc_def(kbl, 70, 1, 1)) \
|
|
fw_def(COFFEELAKE, 0, guc_def(kbl, 70, 1, 1)) \
|
|
fw_def(GEMINILAKE, 0, guc_def(glk, 70, 1, 1)) \
|
|
fw_def(KABYLAKE, 0, guc_def(kbl, 70, 1, 1)) \
|
|
fw_def(BROXTON, 0, guc_def(bxt, 70, 1, 1)) \
|
|
fw_def(SKYLAKE, 0, guc_def(skl, 70, 1, 1))
|
|
|
|
#define INTEL_GUC_FIRMWARE_DEFS_FALLBACK(fw_def, guc_def) \
|
|
fw_def(ALDERLAKE_P, 0, guc_def(adlp, 69, 0, 3)) \
|
|
fw_def(ALDERLAKE_S, 0, guc_def(tgl, 69, 0, 3))
|
|
|
|
#define INTEL_HUC_FIRMWARE_DEFS(fw_def, huc_def) \
|
|
fw_def(ALDERLAKE_P, 0, huc_def(tgl, 7, 9, 3)) \
|
|
fw_def(ALDERLAKE_S, 0, huc_def(tgl, 7, 9, 3)) \
|
|
fw_def(DG1, 0, huc_def(dg1, 7, 9, 3)) \
|
|
fw_def(ROCKETLAKE, 0, huc_def(tgl, 7, 9, 3)) \
|
|
fw_def(TIGERLAKE, 0, huc_def(tgl, 7, 9, 3)) \
|
|
fw_def(JASPERLAKE, 0, huc_def(ehl, 9, 0, 0)) \
|
|
fw_def(ELKHARTLAKE, 0, huc_def(ehl, 9, 0, 0)) \
|
|
fw_def(ICELAKE, 0, huc_def(icl, 9, 0, 0)) \
|
|
fw_def(COMETLAKE, 5, huc_def(cml, 4, 0, 0)) \
|
|
fw_def(COMETLAKE, 0, huc_def(kbl, 4, 0, 0)) \
|
|
fw_def(COFFEELAKE, 0, huc_def(kbl, 4, 0, 0)) \
|
|
fw_def(GEMINILAKE, 0, huc_def(glk, 4, 0, 0)) \
|
|
fw_def(KABYLAKE, 0, huc_def(kbl, 4, 0, 0)) \
|
|
fw_def(BROXTON, 0, huc_def(bxt, 2, 0, 0)) \
|
|
fw_def(SKYLAKE, 0, huc_def(skl, 2, 0, 0))
|
|
|
|
#define __MAKE_UC_FW_PATH(prefix_, name_, major_, minor_, patch_) \
|
|
"i915/" \
|
|
__stringify(prefix_) name_ \
|
|
__stringify(major_) "." \
|
|
__stringify(minor_) "." \
|
|
__stringify(patch_) ".bin"
|
|
|
|
#define MAKE_GUC_FW_PATH(prefix_, major_, minor_, patch_) \
|
|
__MAKE_UC_FW_PATH(prefix_, "_guc_", major_, minor_, patch_)
|
|
|
|
#define MAKE_HUC_FW_PATH(prefix_, major_, minor_, bld_num_) \
|
|
__MAKE_UC_FW_PATH(prefix_, "_huc_", major_, minor_, bld_num_)
|
|
|
|
/* All blobs need to be declared via MODULE_FIRMWARE() */
|
|
#define INTEL_UC_MODULE_FW(platform_, revid_, uc_) \
|
|
MODULE_FIRMWARE(uc_);
|
|
|
|
INTEL_GUC_FIRMWARE_DEFS(INTEL_UC_MODULE_FW, MAKE_GUC_FW_PATH)
|
|
INTEL_GUC_FIRMWARE_DEFS_FALLBACK(INTEL_UC_MODULE_FW, MAKE_GUC_FW_PATH)
|
|
INTEL_HUC_FIRMWARE_DEFS(INTEL_UC_MODULE_FW, MAKE_HUC_FW_PATH)
|
|
|
|
/* The below structs and macros are used to iterate across the list of blobs */
|
|
struct __packed uc_fw_blob {
|
|
u8 major;
|
|
u8 minor;
|
|
const char *path;
|
|
};
|
|
|
|
#define UC_FW_BLOB(major_, minor_, path_) \
|
|
{ .major = major_, .minor = minor_, .path = path_ }
|
|
|
|
#define GUC_FW_BLOB(prefix_, major_, minor_, patch_) \
|
|
UC_FW_BLOB(major_, minor_, \
|
|
MAKE_GUC_FW_PATH(prefix_, major_, minor_, patch_))
|
|
|
|
#define HUC_FW_BLOB(prefix_, major_, minor_, bld_num_) \
|
|
UC_FW_BLOB(major_, minor_, \
|
|
MAKE_HUC_FW_PATH(prefix_, major_, minor_, bld_num_))
|
|
|
|
struct __packed uc_fw_platform_requirement {
|
|
enum intel_platform p;
|
|
u8 rev; /* first platform rev using this FW */
|
|
const struct uc_fw_blob blob;
|
|
};
|
|
|
|
#define MAKE_FW_LIST(platform_, revid_, uc_) \
|
|
{ \
|
|
.p = INTEL_##platform_, \
|
|
.rev = revid_, \
|
|
.blob = uc_, \
|
|
},
|
|
|
|
struct fw_blobs_by_type {
|
|
const struct uc_fw_platform_requirement *blobs;
|
|
u32 count;
|
|
};
|
|
|
|
static void
|
|
__uc_fw_auto_select(struct drm_i915_private *i915, struct intel_uc_fw *uc_fw)
|
|
{
|
|
static const struct uc_fw_platform_requirement blobs_guc[] = {
|
|
INTEL_GUC_FIRMWARE_DEFS(MAKE_FW_LIST, GUC_FW_BLOB)
|
|
};
|
|
static const struct uc_fw_platform_requirement blobs_guc_fallback[] = {
|
|
INTEL_GUC_FIRMWARE_DEFS_FALLBACK(MAKE_FW_LIST, GUC_FW_BLOB)
|
|
};
|
|
static const struct uc_fw_platform_requirement blobs_huc[] = {
|
|
INTEL_HUC_FIRMWARE_DEFS(MAKE_FW_LIST, HUC_FW_BLOB)
|
|
};
|
|
static const struct fw_blobs_by_type blobs_all[INTEL_UC_FW_NUM_TYPES] = {
|
|
[INTEL_UC_FW_TYPE_GUC] = { blobs_guc, ARRAY_SIZE(blobs_guc) },
|
|
[INTEL_UC_FW_TYPE_HUC] = { blobs_huc, ARRAY_SIZE(blobs_huc) },
|
|
};
|
|
const struct uc_fw_platform_requirement *fw_blobs;
|
|
enum intel_platform p = INTEL_INFO(i915)->platform;
|
|
u32 fw_count;
|
|
u8 rev = INTEL_REVID(i915);
|
|
int i;
|
|
|
|
/*
|
|
* The only difference between the ADL GuC FWs is the HWConfig support.
|
|
* ADL-N does not support HWConfig, so we should use the same binary as
|
|
* ADL-S, otherwise the GuC might attempt to fetch a config table that
|
|
* does not exist.
|
|
*/
|
|
if (IS_ADLP_N(i915))
|
|
p = INTEL_ALDERLAKE_S;
|
|
|
|
GEM_BUG_ON(uc_fw->type >= ARRAY_SIZE(blobs_all));
|
|
fw_blobs = blobs_all[uc_fw->type].blobs;
|
|
fw_count = blobs_all[uc_fw->type].count;
|
|
|
|
for (i = 0; i < fw_count && p <= fw_blobs[i].p; i++) {
|
|
if (p == fw_blobs[i].p && rev >= fw_blobs[i].rev) {
|
|
const struct uc_fw_blob *blob = &fw_blobs[i].blob;
|
|
uc_fw->path = blob->path;
|
|
uc_fw->wanted_path = blob->path;
|
|
uc_fw->major_ver_wanted = blob->major;
|
|
uc_fw->minor_ver_wanted = blob->minor;
|
|
break;
|
|
}
|
|
}
|
|
|
|
if (uc_fw->type == INTEL_UC_FW_TYPE_GUC) {
|
|
const struct uc_fw_platform_requirement *blobs = blobs_guc_fallback;
|
|
u32 count = ARRAY_SIZE(blobs_guc_fallback);
|
|
|
|
for (i = 0; i < count && p <= blobs[i].p; i++) {
|
|
if (p == blobs[i].p && rev >= blobs[i].rev) {
|
|
const struct uc_fw_blob *blob = &blobs[i].blob;
|
|
|
|
uc_fw->fallback.path = blob->path;
|
|
uc_fw->fallback.major_ver = blob->major;
|
|
uc_fw->fallback.minor_ver = blob->minor;
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
/* make sure the list is ordered as expected */
|
|
if (IS_ENABLED(CONFIG_DRM_I915_SELFTEST)) {
|
|
for (i = 1; i < fw_count; i++) {
|
|
if (fw_blobs[i].p < fw_blobs[i - 1].p)
|
|
continue;
|
|
|
|
if (fw_blobs[i].p == fw_blobs[i - 1].p &&
|
|
fw_blobs[i].rev < fw_blobs[i - 1].rev)
|
|
continue;
|
|
|
|
pr_err("invalid FW blob order: %s r%u comes before %s r%u\n",
|
|
intel_platform_name(fw_blobs[i - 1].p),
|
|
fw_blobs[i - 1].rev,
|
|
intel_platform_name(fw_blobs[i].p),
|
|
fw_blobs[i].rev);
|
|
|
|
uc_fw->path = NULL;
|
|
}
|
|
}
|
|
}
|
|
|
|
static const char *__override_guc_firmware_path(struct drm_i915_private *i915)
|
|
{
|
|
if (i915->params.enable_guc & ENABLE_GUC_MASK)
|
|
return i915->params.guc_firmware_path;
|
|
return "";
|
|
}
|
|
|
|
static const char *__override_huc_firmware_path(struct drm_i915_private *i915)
|
|
{
|
|
if (i915->params.enable_guc & ENABLE_GUC_LOAD_HUC)
|
|
return i915->params.huc_firmware_path;
|
|
return "";
|
|
}
|
|
|
|
static void __uc_fw_user_override(struct drm_i915_private *i915, struct intel_uc_fw *uc_fw)
|
|
{
|
|
const char *path = NULL;
|
|
|
|
switch (uc_fw->type) {
|
|
case INTEL_UC_FW_TYPE_GUC:
|
|
path = __override_guc_firmware_path(i915);
|
|
break;
|
|
case INTEL_UC_FW_TYPE_HUC:
|
|
path = __override_huc_firmware_path(i915);
|
|
break;
|
|
}
|
|
|
|
if (unlikely(path)) {
|
|
uc_fw->path = path;
|
|
uc_fw->user_overridden = true;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* intel_uc_fw_init_early - initialize the uC object and select the firmware
|
|
* @uc_fw: uC firmware
|
|
* @type: type of uC
|
|
*
|
|
* Initialize the state of our uC object and relevant tracking and select the
|
|
* firmware to fetch and load.
|
|
*/
|
|
void intel_uc_fw_init_early(struct intel_uc_fw *uc_fw,
|
|
enum intel_uc_fw_type type)
|
|
{
|
|
struct drm_i915_private *i915 = ____uc_fw_to_gt(uc_fw, type)->i915;
|
|
|
|
/*
|
|
* we use FIRMWARE_UNINITIALIZED to detect checks against uc_fw->status
|
|
* before we're looked at the HW caps to see if we have uc support
|
|
*/
|
|
BUILD_BUG_ON(INTEL_UC_FIRMWARE_UNINITIALIZED);
|
|
GEM_BUG_ON(uc_fw->status);
|
|
GEM_BUG_ON(uc_fw->path);
|
|
|
|
uc_fw->type = type;
|
|
|
|
if (HAS_GT_UC(i915)) {
|
|
__uc_fw_auto_select(i915, uc_fw);
|
|
__uc_fw_user_override(i915, uc_fw);
|
|
}
|
|
|
|
intel_uc_fw_change_status(uc_fw, uc_fw->path ? *uc_fw->path ?
|
|
INTEL_UC_FIRMWARE_SELECTED :
|
|
INTEL_UC_FIRMWARE_DISABLED :
|
|
INTEL_UC_FIRMWARE_NOT_SUPPORTED);
|
|
}
|
|
|
|
static void __force_fw_fetch_failures(struct intel_uc_fw *uc_fw, int e)
|
|
{
|
|
struct drm_i915_private *i915 = __uc_fw_to_gt(uc_fw)->i915;
|
|
bool user = e == -EINVAL;
|
|
|
|
if (i915_inject_probe_error(i915, e)) {
|
|
/* non-existing blob */
|
|
uc_fw->path = "<invalid>";
|
|
uc_fw->user_overridden = user;
|
|
} else if (i915_inject_probe_error(i915, e)) {
|
|
/* require next major version */
|
|
uc_fw->major_ver_wanted += 1;
|
|
uc_fw->minor_ver_wanted = 0;
|
|
uc_fw->user_overridden = user;
|
|
} else if (i915_inject_probe_error(i915, e)) {
|
|
/* require next minor version */
|
|
uc_fw->minor_ver_wanted += 1;
|
|
uc_fw->user_overridden = user;
|
|
} else if (uc_fw->major_ver_wanted &&
|
|
i915_inject_probe_error(i915, e)) {
|
|
/* require prev major version */
|
|
uc_fw->major_ver_wanted -= 1;
|
|
uc_fw->minor_ver_wanted = 0;
|
|
uc_fw->user_overridden = user;
|
|
} else if (uc_fw->minor_ver_wanted &&
|
|
i915_inject_probe_error(i915, e)) {
|
|
/* require prev minor version - hey, this should work! */
|
|
uc_fw->minor_ver_wanted -= 1;
|
|
uc_fw->user_overridden = user;
|
|
} else if (user && i915_inject_probe_error(i915, e)) {
|
|
/* officially unsupported platform */
|
|
uc_fw->major_ver_wanted = 0;
|
|
uc_fw->minor_ver_wanted = 0;
|
|
uc_fw->user_overridden = true;
|
|
}
|
|
}
|
|
|
|
static int check_gsc_manifest(const struct firmware *fw,
|
|
struct intel_uc_fw *uc_fw)
|
|
{
|
|
u32 *dw = (u32 *)fw->data;
|
|
u32 version = dw[HUC_GSC_VERSION_DW];
|
|
|
|
uc_fw->major_ver_found = FIELD_GET(HUC_GSC_MAJOR_VER_MASK, version);
|
|
uc_fw->minor_ver_found = FIELD_GET(HUC_GSC_MINOR_VER_MASK, version);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int check_ccs_header(struct drm_i915_private *i915,
|
|
const struct firmware *fw,
|
|
struct intel_uc_fw *uc_fw)
|
|
{
|
|
struct uc_css_header *css;
|
|
size_t size;
|
|
|
|
/* Check the size of the blob before examining buffer contents */
|
|
if (unlikely(fw->size < sizeof(struct uc_css_header))) {
|
|
drm_warn(&i915->drm, "%s firmware %s: invalid size: %zu < %zu\n",
|
|
intel_uc_fw_type_repr(uc_fw->type), uc_fw->path,
|
|
fw->size, sizeof(struct uc_css_header));
|
|
return -ENODATA;
|
|
}
|
|
|
|
css = (struct uc_css_header *)fw->data;
|
|
|
|
/* Check integrity of size values inside CSS header */
|
|
size = (css->header_size_dw - css->key_size_dw - css->modulus_size_dw -
|
|
css->exponent_size_dw) * sizeof(u32);
|
|
if (unlikely(size != sizeof(struct uc_css_header))) {
|
|
drm_warn(&i915->drm,
|
|
"%s firmware %s: unexpected header size: %zu != %zu\n",
|
|
intel_uc_fw_type_repr(uc_fw->type), uc_fw->path,
|
|
fw->size, sizeof(struct uc_css_header));
|
|
return -EPROTO;
|
|
}
|
|
|
|
/* uCode size must calculated from other sizes */
|
|
uc_fw->ucode_size = (css->size_dw - css->header_size_dw) * sizeof(u32);
|
|
|
|
/* now RSA */
|
|
uc_fw->rsa_size = css->key_size_dw * sizeof(u32);
|
|
|
|
/* At least, it should have header, uCode and RSA. Size of all three. */
|
|
size = sizeof(struct uc_css_header) + uc_fw->ucode_size + uc_fw->rsa_size;
|
|
if (unlikely(fw->size < size)) {
|
|
drm_warn(&i915->drm, "%s firmware %s: invalid size: %zu < %zu\n",
|
|
intel_uc_fw_type_repr(uc_fw->type), uc_fw->path,
|
|
fw->size, size);
|
|
return -ENOEXEC;
|
|
}
|
|
|
|
/* Sanity check whether this fw is not larger than whole WOPCM memory */
|
|
size = __intel_uc_fw_get_upload_size(uc_fw);
|
|
if (unlikely(size >= i915->wopcm.size)) {
|
|
drm_warn(&i915->drm, "%s firmware %s: invalid size: %zu > %zu\n",
|
|
intel_uc_fw_type_repr(uc_fw->type), uc_fw->path,
|
|
size, (size_t)i915->wopcm.size);
|
|
return -E2BIG;
|
|
}
|
|
|
|
/* Get version numbers from the CSS header */
|
|
uc_fw->major_ver_found = FIELD_GET(CSS_SW_VERSION_UC_MAJOR,
|
|
css->sw_version);
|
|
uc_fw->minor_ver_found = FIELD_GET(CSS_SW_VERSION_UC_MINOR,
|
|
css->sw_version);
|
|
|
|
if (uc_fw->type == INTEL_UC_FW_TYPE_GUC)
|
|
uc_fw->private_data_size = css->private_data_size;
|
|
|
|
return 0;
|
|
}
|
|
|
|
/**
|
|
* intel_uc_fw_fetch - fetch uC firmware
|
|
* @uc_fw: uC firmware
|
|
*
|
|
* Fetch uC firmware into GEM obj.
|
|
*
|
|
* Return: 0 on success, a negative errno code on failure.
|
|
*/
|
|
int intel_uc_fw_fetch(struct intel_uc_fw *uc_fw)
|
|
{
|
|
struct drm_i915_private *i915 = __uc_fw_to_gt(uc_fw)->i915;
|
|
struct device *dev = i915->drm.dev;
|
|
struct drm_i915_gem_object *obj;
|
|
const struct firmware *fw = NULL;
|
|
int err;
|
|
|
|
GEM_BUG_ON(!i915->wopcm.size);
|
|
GEM_BUG_ON(!intel_uc_fw_is_enabled(uc_fw));
|
|
|
|
err = i915_inject_probe_error(i915, -ENXIO);
|
|
if (err)
|
|
goto fail;
|
|
|
|
__force_fw_fetch_failures(uc_fw, -EINVAL);
|
|
__force_fw_fetch_failures(uc_fw, -ESTALE);
|
|
|
|
err = firmware_request_nowarn(&fw, uc_fw->path, dev);
|
|
if (err && !intel_uc_fw_is_overridden(uc_fw) && uc_fw->fallback.path) {
|
|
err = firmware_request_nowarn(&fw, uc_fw->fallback.path, dev);
|
|
if (!err) {
|
|
drm_notice(&i915->drm,
|
|
"%s firmware %s is recommended, but only %s was found\n",
|
|
intel_uc_fw_type_repr(uc_fw->type),
|
|
uc_fw->wanted_path,
|
|
uc_fw->fallback.path);
|
|
drm_info(&i915->drm,
|
|
"Consider updating your linux-firmware pkg or downloading from %s\n",
|
|
INTEL_UC_FIRMWARE_URL);
|
|
|
|
uc_fw->path = uc_fw->fallback.path;
|
|
uc_fw->major_ver_wanted = uc_fw->fallback.major_ver;
|
|
uc_fw->minor_ver_wanted = uc_fw->fallback.minor_ver;
|
|
}
|
|
}
|
|
if (err)
|
|
goto fail;
|
|
|
|
if (uc_fw->loaded_via_gsc)
|
|
err = check_gsc_manifest(fw, uc_fw);
|
|
else
|
|
err = check_ccs_header(i915, fw, uc_fw);
|
|
if (err)
|
|
goto fail;
|
|
|
|
if (uc_fw->major_ver_found != uc_fw->major_ver_wanted ||
|
|
uc_fw->minor_ver_found < uc_fw->minor_ver_wanted) {
|
|
drm_notice(&i915->drm, "%s firmware %s: unexpected version: %u.%u != %u.%u\n",
|
|
intel_uc_fw_type_repr(uc_fw->type), uc_fw->path,
|
|
uc_fw->major_ver_found, uc_fw->minor_ver_found,
|
|
uc_fw->major_ver_wanted, uc_fw->minor_ver_wanted);
|
|
if (!intel_uc_fw_is_overridden(uc_fw)) {
|
|
err = -ENOEXEC;
|
|
goto fail;
|
|
}
|
|
}
|
|
|
|
if (HAS_LMEM(i915)) {
|
|
obj = i915_gem_object_create_lmem_from_data(i915, fw->data, fw->size);
|
|
if (!IS_ERR(obj))
|
|
obj->flags |= I915_BO_ALLOC_PM_EARLY;
|
|
} else {
|
|
obj = i915_gem_object_create_shmem_from_data(i915, fw->data, fw->size);
|
|
}
|
|
|
|
if (IS_ERR(obj)) {
|
|
err = PTR_ERR(obj);
|
|
goto fail;
|
|
}
|
|
|
|
uc_fw->obj = obj;
|
|
uc_fw->size = fw->size;
|
|
intel_uc_fw_change_status(uc_fw, INTEL_UC_FIRMWARE_AVAILABLE);
|
|
|
|
release_firmware(fw);
|
|
return 0;
|
|
|
|
fail:
|
|
intel_uc_fw_change_status(uc_fw, err == -ENOENT ?
|
|
INTEL_UC_FIRMWARE_MISSING :
|
|
INTEL_UC_FIRMWARE_ERROR);
|
|
|
|
i915_probe_error(i915, "%s firmware %s: fetch failed with error %d\n",
|
|
intel_uc_fw_type_repr(uc_fw->type), uc_fw->path, err);
|
|
drm_info(&i915->drm, "%s firmware(s) can be downloaded from %s\n",
|
|
intel_uc_fw_type_repr(uc_fw->type), INTEL_UC_FIRMWARE_URL);
|
|
|
|
release_firmware(fw); /* OK even if fw is NULL */
|
|
return err;
|
|
}
|
|
|
|
static u32 uc_fw_ggtt_offset(struct intel_uc_fw *uc_fw)
|
|
{
|
|
struct i915_ggtt *ggtt = __uc_fw_to_gt(uc_fw)->ggtt;
|
|
struct drm_mm_node *node = &ggtt->uc_fw;
|
|
|
|
GEM_BUG_ON(!drm_mm_node_allocated(node));
|
|
GEM_BUG_ON(upper_32_bits(node->start));
|
|
GEM_BUG_ON(upper_32_bits(node->start + node->size - 1));
|
|
|
|
return lower_32_bits(node->start);
|
|
}
|
|
|
|
static void uc_fw_bind_ggtt(struct intel_uc_fw *uc_fw)
|
|
{
|
|
struct drm_i915_gem_object *obj = uc_fw->obj;
|
|
struct i915_ggtt *ggtt = __uc_fw_to_gt(uc_fw)->ggtt;
|
|
struct i915_vma_resource *dummy = &uc_fw->dummy;
|
|
u32 pte_flags = 0;
|
|
|
|
dummy->start = uc_fw_ggtt_offset(uc_fw);
|
|
dummy->node_size = obj->base.size;
|
|
dummy->bi.pages = obj->mm.pages;
|
|
|
|
GEM_BUG_ON(!i915_gem_object_has_pinned_pages(obj));
|
|
GEM_BUG_ON(dummy->node_size > ggtt->uc_fw.size);
|
|
|
|
/* uc_fw->obj cache domains were not controlled across suspend */
|
|
if (i915_gem_object_has_struct_page(obj))
|
|
drm_clflush_sg(dummy->bi.pages);
|
|
|
|
if (i915_gem_object_is_lmem(obj))
|
|
pte_flags |= PTE_LM;
|
|
|
|
if (ggtt->vm.raw_insert_entries)
|
|
ggtt->vm.raw_insert_entries(&ggtt->vm, dummy, I915_CACHE_NONE, pte_flags);
|
|
else
|
|
ggtt->vm.insert_entries(&ggtt->vm, dummy, I915_CACHE_NONE, pte_flags);
|
|
}
|
|
|
|
static void uc_fw_unbind_ggtt(struct intel_uc_fw *uc_fw)
|
|
{
|
|
struct drm_i915_gem_object *obj = uc_fw->obj;
|
|
struct i915_ggtt *ggtt = __uc_fw_to_gt(uc_fw)->ggtt;
|
|
u64 start = uc_fw_ggtt_offset(uc_fw);
|
|
|
|
ggtt->vm.clear_range(&ggtt->vm, start, obj->base.size);
|
|
}
|
|
|
|
static int uc_fw_xfer(struct intel_uc_fw *uc_fw, u32 dst_offset, u32 dma_flags)
|
|
{
|
|
struct intel_gt *gt = __uc_fw_to_gt(uc_fw);
|
|
struct intel_uncore *uncore = gt->uncore;
|
|
u64 offset;
|
|
int ret;
|
|
|
|
ret = i915_inject_probe_error(gt->i915, -ETIMEDOUT);
|
|
if (ret)
|
|
return ret;
|
|
|
|
intel_uncore_forcewake_get(uncore, FORCEWAKE_ALL);
|
|
|
|
/* Set the source address for the uCode */
|
|
offset = uc_fw_ggtt_offset(uc_fw);
|
|
GEM_BUG_ON(upper_32_bits(offset) & 0xFFFF0000);
|
|
intel_uncore_write_fw(uncore, DMA_ADDR_0_LOW, lower_32_bits(offset));
|
|
intel_uncore_write_fw(uncore, DMA_ADDR_0_HIGH, upper_32_bits(offset));
|
|
|
|
/* Set the DMA destination */
|
|
intel_uncore_write_fw(uncore, DMA_ADDR_1_LOW, dst_offset);
|
|
intel_uncore_write_fw(uncore, DMA_ADDR_1_HIGH, DMA_ADDRESS_SPACE_WOPCM);
|
|
|
|
/*
|
|
* Set the transfer size. The header plus uCode will be copied to WOPCM
|
|
* via DMA, excluding any other components
|
|
*/
|
|
intel_uncore_write_fw(uncore, DMA_COPY_SIZE,
|
|
sizeof(struct uc_css_header) + uc_fw->ucode_size);
|
|
|
|
/* Start the DMA */
|
|
intel_uncore_write_fw(uncore, DMA_CTRL,
|
|
_MASKED_BIT_ENABLE(dma_flags | START_DMA));
|
|
|
|
/* Wait for DMA to finish */
|
|
ret = intel_wait_for_register_fw(uncore, DMA_CTRL, START_DMA, 0, 100);
|
|
if (ret)
|
|
drm_err(>->i915->drm, "DMA for %s fw failed, DMA_CTRL=%u\n",
|
|
intel_uc_fw_type_repr(uc_fw->type),
|
|
intel_uncore_read_fw(uncore, DMA_CTRL));
|
|
|
|
/* Disable the bits once DMA is over */
|
|
intel_uncore_write_fw(uncore, DMA_CTRL, _MASKED_BIT_DISABLE(dma_flags));
|
|
|
|
intel_uncore_forcewake_put(uncore, FORCEWAKE_ALL);
|
|
|
|
return ret;
|
|
}
|
|
|
|
/**
|
|
* intel_uc_fw_upload - load uC firmware using custom loader
|
|
* @uc_fw: uC firmware
|
|
* @dst_offset: destination offset
|
|
* @dma_flags: flags for flags for dma ctrl
|
|
*
|
|
* Loads uC firmware and updates internal flags.
|
|
*
|
|
* Return: 0 on success, non-zero on failure.
|
|
*/
|
|
int intel_uc_fw_upload(struct intel_uc_fw *uc_fw, u32 dst_offset, u32 dma_flags)
|
|
{
|
|
struct intel_gt *gt = __uc_fw_to_gt(uc_fw);
|
|
int err;
|
|
|
|
/* make sure the status was cleared the last time we reset the uc */
|
|
GEM_BUG_ON(intel_uc_fw_is_loaded(uc_fw));
|
|
|
|
err = i915_inject_probe_error(gt->i915, -ENOEXEC);
|
|
if (err)
|
|
return err;
|
|
|
|
if (!intel_uc_fw_is_loadable(uc_fw))
|
|
return -ENOEXEC;
|
|
|
|
/* Call custom loader */
|
|
uc_fw_bind_ggtt(uc_fw);
|
|
err = uc_fw_xfer(uc_fw, dst_offset, dma_flags);
|
|
uc_fw_unbind_ggtt(uc_fw);
|
|
if (err)
|
|
goto fail;
|
|
|
|
intel_uc_fw_change_status(uc_fw, INTEL_UC_FIRMWARE_TRANSFERRED);
|
|
return 0;
|
|
|
|
fail:
|
|
i915_probe_error(gt->i915, "Failed to load %s firmware %s (%d)\n",
|
|
intel_uc_fw_type_repr(uc_fw->type), uc_fw->path,
|
|
err);
|
|
intel_uc_fw_change_status(uc_fw, INTEL_UC_FIRMWARE_LOAD_FAIL);
|
|
return err;
|
|
}
|
|
|
|
static inline bool uc_fw_need_rsa_in_memory(struct intel_uc_fw *uc_fw)
|
|
{
|
|
/*
|
|
* The HW reads the GuC RSA from memory if the key size is > 256 bytes,
|
|
* while it reads it from the 64 RSA registers if it is smaller.
|
|
* The HuC RSA is always read from memory.
|
|
*/
|
|
return uc_fw->type == INTEL_UC_FW_TYPE_HUC || uc_fw->rsa_size > 256;
|
|
}
|
|
|
|
static int uc_fw_rsa_data_create(struct intel_uc_fw *uc_fw)
|
|
{
|
|
struct intel_gt *gt = __uc_fw_to_gt(uc_fw);
|
|
struct i915_vma *vma;
|
|
size_t copied;
|
|
void *vaddr;
|
|
int err;
|
|
|
|
err = i915_inject_probe_error(gt->i915, -ENXIO);
|
|
if (err)
|
|
return err;
|
|
|
|
if (!uc_fw_need_rsa_in_memory(uc_fw))
|
|
return 0;
|
|
|
|
/*
|
|
* uC firmwares will sit above GUC_GGTT_TOP and will not map through
|
|
* GGTT. Unfortunately, this means that the GuC HW cannot perform the uC
|
|
* authentication from memory, as the RSA offset now falls within the
|
|
* GuC inaccessible range. We resort to perma-pinning an additional vma
|
|
* within the accessible range that only contains the RSA signature.
|
|
* The GuC HW can use this extra pinning to perform the authentication
|
|
* since its GGTT offset will be GuC accessible.
|
|
*/
|
|
GEM_BUG_ON(uc_fw->rsa_size > PAGE_SIZE);
|
|
vma = intel_guc_allocate_vma(>->uc.guc, PAGE_SIZE);
|
|
if (IS_ERR(vma))
|
|
return PTR_ERR(vma);
|
|
|
|
vaddr = i915_gem_object_pin_map_unlocked(vma->obj,
|
|
i915_coherent_map_type(gt->i915, vma->obj, true));
|
|
if (IS_ERR(vaddr)) {
|
|
i915_vma_unpin_and_release(&vma, 0);
|
|
err = PTR_ERR(vaddr);
|
|
goto unpin_out;
|
|
}
|
|
|
|
copied = intel_uc_fw_copy_rsa(uc_fw, vaddr, vma->size);
|
|
i915_gem_object_unpin_map(vma->obj);
|
|
|
|
if (copied < uc_fw->rsa_size) {
|
|
err = -ENOMEM;
|
|
goto unpin_out;
|
|
}
|
|
|
|
uc_fw->rsa_data = vma;
|
|
|
|
return 0;
|
|
|
|
unpin_out:
|
|
i915_vma_unpin_and_release(&vma, 0);
|
|
return err;
|
|
}
|
|
|
|
static void uc_fw_rsa_data_destroy(struct intel_uc_fw *uc_fw)
|
|
{
|
|
i915_vma_unpin_and_release(&uc_fw->rsa_data, 0);
|
|
}
|
|
|
|
int intel_uc_fw_init(struct intel_uc_fw *uc_fw)
|
|
{
|
|
int err;
|
|
|
|
/* this should happen before the load! */
|
|
GEM_BUG_ON(intel_uc_fw_is_loaded(uc_fw));
|
|
|
|
if (!intel_uc_fw_is_available(uc_fw))
|
|
return -ENOEXEC;
|
|
|
|
err = i915_gem_object_pin_pages_unlocked(uc_fw->obj);
|
|
if (err) {
|
|
DRM_DEBUG_DRIVER("%s fw pin-pages err=%d\n",
|
|
intel_uc_fw_type_repr(uc_fw->type), err);
|
|
goto out;
|
|
}
|
|
|
|
err = uc_fw_rsa_data_create(uc_fw);
|
|
if (err) {
|
|
DRM_DEBUG_DRIVER("%s fw rsa data creation failed, err=%d\n",
|
|
intel_uc_fw_type_repr(uc_fw->type), err);
|
|
goto out_unpin;
|
|
}
|
|
|
|
return 0;
|
|
|
|
out_unpin:
|
|
i915_gem_object_unpin_pages(uc_fw->obj);
|
|
out:
|
|
intel_uc_fw_change_status(uc_fw, INTEL_UC_FIRMWARE_INIT_FAIL);
|
|
return err;
|
|
}
|
|
|
|
void intel_uc_fw_fini(struct intel_uc_fw *uc_fw)
|
|
{
|
|
uc_fw_rsa_data_destroy(uc_fw);
|
|
|
|
if (i915_gem_object_has_pinned_pages(uc_fw->obj))
|
|
i915_gem_object_unpin_pages(uc_fw->obj);
|
|
|
|
intel_uc_fw_change_status(uc_fw, INTEL_UC_FIRMWARE_AVAILABLE);
|
|
}
|
|
|
|
/**
|
|
* intel_uc_fw_cleanup_fetch - cleanup uC firmware
|
|
* @uc_fw: uC firmware
|
|
*
|
|
* Cleans up uC firmware by releasing the firmware GEM obj.
|
|
*/
|
|
void intel_uc_fw_cleanup_fetch(struct intel_uc_fw *uc_fw)
|
|
{
|
|
if (!intel_uc_fw_is_available(uc_fw))
|
|
return;
|
|
|
|
i915_gem_object_put(fetch_and_zero(&uc_fw->obj));
|
|
|
|
intel_uc_fw_change_status(uc_fw, INTEL_UC_FIRMWARE_SELECTED);
|
|
}
|
|
|
|
/**
|
|
* intel_uc_fw_copy_rsa - copy fw RSA to buffer
|
|
*
|
|
* @uc_fw: uC firmware
|
|
* @dst: dst buffer
|
|
* @max_len: max number of bytes to copy
|
|
*
|
|
* Return: number of copied bytes.
|
|
*/
|
|
size_t intel_uc_fw_copy_rsa(struct intel_uc_fw *uc_fw, void *dst, u32 max_len)
|
|
{
|
|
struct intel_memory_region *mr = uc_fw->obj->mm.region;
|
|
u32 size = min_t(u32, uc_fw->rsa_size, max_len);
|
|
u32 offset = sizeof(struct uc_css_header) + uc_fw->ucode_size;
|
|
struct sgt_iter iter;
|
|
size_t count = 0;
|
|
int idx;
|
|
|
|
/* Called during reset handling, must be atomic [no fs_reclaim] */
|
|
GEM_BUG_ON(!intel_uc_fw_is_available(uc_fw));
|
|
|
|
idx = offset >> PAGE_SHIFT;
|
|
offset = offset_in_page(offset);
|
|
if (i915_gem_object_has_struct_page(uc_fw->obj)) {
|
|
struct page *page;
|
|
|
|
for_each_sgt_page(page, iter, uc_fw->obj->mm.pages) {
|
|
u32 len = min_t(u32, size, PAGE_SIZE - offset);
|
|
void *vaddr;
|
|
|
|
if (idx > 0) {
|
|
idx--;
|
|
continue;
|
|
}
|
|
|
|
vaddr = kmap_atomic(page);
|
|
memcpy(dst, vaddr + offset, len);
|
|
kunmap_atomic(vaddr);
|
|
|
|
offset = 0;
|
|
dst += len;
|
|
size -= len;
|
|
count += len;
|
|
if (!size)
|
|
break;
|
|
}
|
|
} else {
|
|
dma_addr_t addr;
|
|
|
|
for_each_sgt_daddr(addr, iter, uc_fw->obj->mm.pages) {
|
|
u32 len = min_t(u32, size, PAGE_SIZE - offset);
|
|
void __iomem *vaddr;
|
|
|
|
if (idx > 0) {
|
|
idx--;
|
|
continue;
|
|
}
|
|
|
|
vaddr = io_mapping_map_atomic_wc(&mr->iomap,
|
|
addr - mr->region.start);
|
|
memcpy_fromio(dst, vaddr + offset, len);
|
|
io_mapping_unmap_atomic(vaddr);
|
|
|
|
offset = 0;
|
|
dst += len;
|
|
size -= len;
|
|
count += len;
|
|
if (!size)
|
|
break;
|
|
}
|
|
}
|
|
|
|
return count;
|
|
}
|
|
|
|
/**
|
|
* intel_uc_fw_dump - dump information about uC firmware
|
|
* @uc_fw: uC firmware
|
|
* @p: the &drm_printer
|
|
*
|
|
* Pretty printer for uC firmware.
|
|
*/
|
|
void intel_uc_fw_dump(const struct intel_uc_fw *uc_fw, struct drm_printer *p)
|
|
{
|
|
drm_printf(p, "%s firmware: %s\n",
|
|
intel_uc_fw_type_repr(uc_fw->type), uc_fw->wanted_path);
|
|
if (uc_fw->fallback.path) {
|
|
drm_printf(p, "%s firmware fallback: %s\n",
|
|
intel_uc_fw_type_repr(uc_fw->type), uc_fw->fallback.path);
|
|
drm_printf(p, "fallback selected: %s\n",
|
|
str_yes_no(uc_fw->path == uc_fw->fallback.path));
|
|
}
|
|
drm_printf(p, "\tstatus: %s\n",
|
|
intel_uc_fw_status_repr(uc_fw->status));
|
|
drm_printf(p, "\tversion: wanted %u.%u, found %u.%u\n",
|
|
uc_fw->major_ver_wanted, uc_fw->minor_ver_wanted,
|
|
uc_fw->major_ver_found, uc_fw->minor_ver_found);
|
|
drm_printf(p, "\tuCode: %u bytes\n", uc_fw->ucode_size);
|
|
drm_printf(p, "\tRSA: %u bytes\n", uc_fw->rsa_size);
|
|
}
|