leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
b59ea3efba4889ece81056883193d78b51db11d1
linux/drivers/edac
History
Borislav Petkov b49777c656 EDAC, mc_sysfs: Fix freeing bus' name 
commit 12e26969b3 upstream.

I get the splat below when modprobing/rmmoding EDAC drivers. It happens
because bus->name is invalid after bus_unregister() has run. The Code: section
below corresponds to:

  .loc 1 1108 0
  movq    672(%rbx), %rax # mci_1(D)->bus, mci_1(D)->bus
  .loc 1 1109 0
  popq    %rbx    #

  .loc 1 1108 0
  movq    (%rax), %rdi    # _7->name,
  jmp     kfree   #

and %rax has some funky stuff 2030203020312030 which looks a lot like
something walked over it.

Fix that by saving the name ptr before doing stuff to string it points to.

  general protection fault: 0000 [#1] SMP
  Modules linked in: ...
  CPU: 4 PID: 10318 Comm: modprobe Tainted: G          I EN  3.12.51-11-default+ #48
  Hardware name: HP ProLiant DL380 G7, BIOS P67 05/05/2011
  task: ffff880311320280 ti: ffff88030da3e000 task.ti: ffff88030da3e000
  RIP: 0010:[<ffffffffa019da92>]  [<ffffffffa019da92>] edac_unregister_sysfs+0x22/0x30 [edac_core]
  RSP: 0018:ffff88030da3fe28  EFLAGS: 00010292
  RAX: 2030203020312030 RBX: ffff880311b4e000 RCX: 000000000000095c
  RDX: 0000000000000001 RSI: ffff880327bb9600 RDI: 0000000000000286
  RBP: ffff880311b4e750 R08: 0000000000000000 R09: ffffffff81296110
  R10: 0000000000000400 R11: 0000000000000000 R12: ffff88030ba1ac68
  R13: 0000000000000001 R14: 00000000011b02f0 R15: 0000000000000000
  FS:  00007fc9bf8f5700(0000) GS:ffff8801a7c40000(0000) knlGS:0000000000000000
  CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
  CR2: 0000000000403c90 CR3: 000000019ebdf000 CR4: 00000000000007e0
  Stack:
  Call Trace:
    i7core_unregister_mci.isra.9
    i7core_remove
    pci_device_remove
    __device_release_driver
    driver_detach
    bus_remove_driver
    pci_unregister_driver
    i7core_exit
    SyS_delete_module
    system_call_fastpath
    0x7fc9bf426536
  Code: 2e 0f 1f 84 00 00 00 00 00 66 66 66 66 90 53 48 89 fb e8 52 2a 1f e1 48 8b bb a0 02 00 00 e8 46 59 1f e1 48 8b 83 a0 02 00 00 5b <48> 8b 38 e9 26 9a fe e0 66 0f 1f 44 00 00 66 66 66 66 90 48 8b
  RIP  [<ffffffffa019da92>] edac_unregister_sysfs+0x22/0x30 [edac_core]
   RSP <ffff88030da3fe28>

Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Fixes: 7a623c0390 ("edac: rewrite the sysfs code to use struct device")
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-03-03 15:07:17 -08:00
..
altera_edac.c
EDAC, altera: Convert to debugfs wrappers
2015-09-22 18:20:56 +02:00
altera_edac.h
EDAC, altera: SoCFPGA EDAC should not look for ECC_CORR_EN
2015-10-15 11:57:23 +02:00
amd64_edac_dbg.c
EDAC: amd64: Use static attribute groups
2015-02-23 13:08:09 +01:00
amd64_edac_inj.c
EDAC: amd64: Use static attribute groups
2015-02-23 13:08:09 +01:00
amd64_edac.c
Merge branch 'ras-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2015-11-03 17:51:33 -08:00
amd64_edac.h
EDAC, amd64_edac: Update copyright and remove changelog
2015-09-29 13:41:04 +02:00
amd76x_edac.c
EDAC: Remove DEFINE_PCI_DEVICE_TABLE macro
2013-12-06 10:23:41 +01:00
amd8111_edac.c
amd8111_edac: Fix leaks in probe error paths
2014-02-25 10:09:09 +01:00
amd8111_edac.h
…
amd8131_edac.c
…
amd8131_edac.h
…
cell_edac.c
edac: drop owner assignment from platform_drivers
2014-10-20 16:20:30 +02:00
cpc925_edac.c
cpc925_edac: Report UE events properly
2014-10-22 22:58:45 +02:00
debugfs.c
EDAC: Use edac_debugfs_remove_recursive()
2015-10-14 18:50:32 +02:00
e7xxx_edac.c
e7xxx_edac: Report CE events properly
2014-10-22 22:59:00 +02:00
e752x_edac.c
e752x_edac: Drop pvt->bridge_ck
2014-02-25 10:01:30 +01:00
edac_core.h
EDAC: Carve out debugfs functionality
2015-09-22 12:29:46 +02:00
edac_device_sysfs.c
…
edac_device.c
EDAC: Robustify workqueues destruction
2016-03-03 15:07:17 -08:00
edac_mc_sysfs.c
EDAC, mc_sysfs: Fix freeing bus' name
2016-03-03 15:07:17 -08:00
edac_mc.c
EDAC: Robustify workqueues destruction
2016-03-03 15:07:17 -08:00
edac_module.c
EDAC: Properly unwind on failure path in edac_init()
2015-02-23 13:13:07 +01:00
edac_module.h
EDAC: Add debugfs wrappers
2015-09-22 18:10:22 +02:00
edac_pci_sysfs.c
EDAC, pci_sysfs: remove unneccessary ifdef around entire file
2014-11-11 18:17:57 +01:00
edac_pci.c
EDAC: Robustify workqueues destruction
2016-03-03 15:07:17 -08:00
edac_stub.c
EDAC, edac_stub: Drop arch-specific include
2015-05-29 22:01:00 +02:00
ghes_edac.c
EDAC: Fix PAGES_TO_MiB macro misuse
2015-10-22 22:57:30 +02:00
highbank_l2_edac.c
edac, highbank: Improve and unify naming
2013-11-04 17:01:07 -06:00
highbank_mc_edac.c
EDAC: Constify of_device_id array
2015-03-20 17:50:07 +01:00
i7core_edac.c
x86/mce: Kill drain_mcelog_buffer()
2015-08-13 10:12:52 +02:00
i3000_edac.c
EDAC: Delete unnecessary check before calling pci_dev_put()
2014-11-19 16:33:48 +01:00
i3200_edac.c
move io-64-nonatomic*.h out of asm-generic
2015-10-15 00:21:07 +02:00
i5000_edac.c
EDAC: Remove DEFINE_PCI_DEVICE_TABLE macro
2013-12-06 10:23:41 +01:00
i5100_edac.c
EDAC, i5100: Convert to debugfs wrappers
2015-09-22 18:21:12 +02:00
i5400_edac.c
Merge branch 'v4l_for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media
2014-04-04 09:50:07 -07:00
i7300_edac.c
Merge tag 'v3.14-rc5' into patchwork
2014-03-11 06:55:49 -03:00
i82443bxgx_edac.c
EDAC, i82443bxgx: Don't export static symbol
2015-03-11 20:39:15 +01:00
i82860_edac.c
EDAC: Delete unnecessary checks before pci_dev_put()
2015-02-23 13:06:23 +01:00
i82875p_edac.c
EDAC: Delete unnecessary checks before pci_dev_put()
2015-02-23 13:06:23 +01:00
i82975x_edac.c
EDAC: Delete unnecessary checks before pci_dev_put()
2015-02-23 13:06:23 +01:00
ie31200_edac.c
move io-64-nonatomic*.h out of asm-generic
2015-10-15 00:21:07 +02:00
Kconfig
x86/ras: Move AMD MCE injector to arch/x86/ras/
2015-08-13 10:12:54 +02:00
Makefile
EDAC: Carve out debugfs functionality
2015-09-22 12:29:46 +02:00
mce_amd.c
x86/mce: Kill drain_mcelog_buffer()
2015-08-13 10:12:52 +02:00
mce_amd.h
x86, mce, severity: Extend the the mce_severity mechanism to handle UCNA/DEFERRED error
2014-11-19 10:55:43 -08:00
mpc85xx_edac.c
EDAC, mpc85xx: Extend error address to 64 bit
2015-05-31 12:51:08 +02:00
mpc85xx_edac.h
EDAC, mpc85xx: Extend error address to 64 bit
2015-05-31 12:51:08 +02:00
mv64x60_edac.c
EDAC, mv64x60_edac: Fix an error code in probe()
2015-01-30 17:00:43 +01:00
mv64x60_edac.h
…
octeon_edac-l2c.c
EDAC, octeon: Fix broken build due to model helper renames
2015-07-02 10:46:28 +02:00
octeon_edac-lmc.c
EDAC, octeon: Fix broken build due to model helper renames
2015-07-02 10:46:28 +02:00
octeon_edac-pc.c
EDAC, octeon: Fix broken build due to model helper renames
2015-07-02 10:46:28 +02:00
octeon_edac-pci.c
…
pasemi_edac.c
…
ppc4xx_edac.c
EDAC, ppc4xx_edac: Fix module autoload for OF platform driver
2015-10-03 12:19:42 +02:00
ppc4xx_edac.h
…
r82600_edac.c
EDAC: Remove DEFINE_PCI_DEVICE_TABLE macro
2013-12-06 10:23:41 +01:00
sb_edac.c
EDAC, sb_edac: Fix TAD presence check for sbridge_mci_bind_devs()
2015-09-24 20:40:50 +02:00
synopsys_edac.c
EDAC: Constify of_device_id array
2015-03-20 17:50:07 +01:00
tile_edac.c
edac: drop owner assignment from platform_drivers
2014-10-20 16:20:30 +02:00
x38_edac.c
move io-64-nonatomic*.h out of asm-generic
2015-10-15 00:21:07 +02:00
xgene_edac.c
EDAC, xgene: Add SoC support
2015-09-25 15:41:46 +02:00