linux/drivers/net/can/usb
Ahmed S. Darwish b442723fce can: kvaser_usb: Don't free packets when tight on URBs
Flooding the Kvaser CAN to USB dongle with multiple reads and
writes in high frequency caused seemingly-random panics in the
kernel.

On further inspection, it seems the driver erroneously freed the
to-be-transmitted packet upon getting tight on URBs and returning
NETDEV_TX_BUSY, leading to invalid memory writes and double frees
at a later point in time.

Note:

Finding no more URBs/transmit-contexts and returning NETDEV_TX_BUSY
is a driver bug in and out of itself: it means that our start/stop
queue flow control is broken.

This patch only fixes the (buggy) error handling code; the root
cause shall be fixed in a later commit.

Acked-by: Olivier Sobrie <olivier@sobrie.be>
Signed-off-by: Ahmed S. Darwish <ahmed.darwish@valeo.com>
Cc: linux-stable <stable@vger.kernel.org>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
2015-01-15 16:58:00 +01:00
..
peak_usb can: peak_usb: fix multi-byte values endianess 2014-12-07 21:04:03 +01:00
ems_usb.c can: remove unused variable 2014-11-18 16:52:18 +01:00
esd_usb2.c can: remove unused variable 2014-11-18 16:52:18 +01:00
gs_usb.c can: gs_usb: add .ndo_change_mtu function 2014-11-18 21:34:59 +01:00
Kconfig can: gs_usb: Added support for the GS_USB CAN devices 2014-05-19 09:38:25 +02:00
kvaser_usb.c can: kvaser_usb: Don't free packets when tight on URBs 2015-01-15 16:58:00 +01:00
Makefile net: can: use kbuild magic to inherit debug settings 2014-08-18 01:03:38 +02:00
usb_8dev.c linux-can-fixes-for-3.15-20140401 2014-04-01 17:49:50 -04:00