forked from Minki/linux
2ad6e0c339
Fixes the following W=1 kernel build warning(s): drivers/scsi/bnx2i/bnx2i_sysfs.c:40: warning: Function parameter or member 'attr' not described in 'bnx2i_show_sq_info' drivers/scsi/bnx2i/bnx2i_sysfs.c:60: warning: Function parameter or member 'attr' not described in 'bnx2i_set_sq_info' drivers/scsi/bnx2i/bnx2i_sysfs.c:96: warning: Function parameter or member 'attr' not described in 'bnx2i_show_ccell_info' drivers/scsi/bnx2i/bnx2i_sysfs.c:114: warning: Function parameter or member 'attr' not described in 'bnx2i_set_ccell_info' Link: https://lore.kernel.org/r/20200723122446.1329773-9-lee.jones@linaro.org Cc: QLogic-Storage-Upstream@qlogic.com Cc: Anil Veerabhadrappa <anilgv@broadcom.com> Cc: Eddie Wai <eddie.wai@broadcom.com> Signed-off-by: Lee Jones <lee.jones@linaro.org> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
150 lines
3.8 KiB
C
150 lines
3.8 KiB
C
/* bnx2i_sysfs.c: QLogic NetXtreme II iSCSI driver.
|
|
*
|
|
* Copyright (c) 2004 - 2013 Broadcom Corporation
|
|
* Copyright (c) 2014, QLogic Corporation
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation.
|
|
*
|
|
* Written by: Anil Veerabhadrappa (anilgv@broadcom.com)
|
|
* Previously Maintained by: Eddie Wai (eddie.wai@broadcom.com)
|
|
* Maintained by: QLogic-Storage-Upstream@qlogic.com
|
|
*/
|
|
|
|
#include "bnx2i.h"
|
|
|
|
/**
|
|
* bnx2i_dev_to_hba - maps dev pointer to adapter struct
|
|
* @dev: device pointer
|
|
*
|
|
* Map device to hba structure
|
|
*/
|
|
static inline struct bnx2i_hba *bnx2i_dev_to_hba(struct device *dev)
|
|
{
|
|
struct Scsi_Host *shost = class_to_shost(dev);
|
|
return iscsi_host_priv(shost);
|
|
}
|
|
|
|
|
|
/**
|
|
* bnx2i_show_sq_info - return(s currently configured send queue (SQ) size
|
|
* @dev: device pointer
|
|
* @attr: device attribute (unused)
|
|
* @buf: buffer to return current SQ size parameter
|
|
*
|
|
* Returns current SQ size parameter, this paramater determines the number
|
|
* outstanding iSCSI commands supported on a connection
|
|
*/
|
|
static ssize_t bnx2i_show_sq_info(struct device *dev,
|
|
struct device_attribute *attr, char *buf)
|
|
{
|
|
struct bnx2i_hba *hba = bnx2i_dev_to_hba(dev);
|
|
|
|
return sprintf(buf, "0x%x\n", hba->max_sqes);
|
|
}
|
|
|
|
|
|
/**
|
|
* bnx2i_set_sq_info - update send queue (SQ) size parameter
|
|
* @dev: device pointer
|
|
* @attr: device attribute (unused)
|
|
* @buf: buffer to return current SQ size parameter
|
|
* @count: parameter buffer size
|
|
*
|
|
* Interface for user to change shared queue size allocated for each conn
|
|
* Must be within SQ limits and a power of 2. For the latter this is needed
|
|
* because of how libiscsi preallocates tasks.
|
|
*/
|
|
static ssize_t bnx2i_set_sq_info(struct device *dev,
|
|
struct device_attribute *attr,
|
|
const char *buf, size_t count)
|
|
{
|
|
struct bnx2i_hba *hba = bnx2i_dev_to_hba(dev);
|
|
u32 val;
|
|
int max_sq_size;
|
|
|
|
if (hba->ofld_conns_active)
|
|
goto skip_config;
|
|
|
|
if (test_bit(BNX2I_NX2_DEV_57710, &hba->cnic_dev_type))
|
|
max_sq_size = BNX2I_5770X_SQ_WQES_MAX;
|
|
else
|
|
max_sq_size = BNX2I_570X_SQ_WQES_MAX;
|
|
|
|
if (sscanf(buf, " 0x%x ", &val) > 0) {
|
|
if ((val >= BNX2I_SQ_WQES_MIN) && (val <= max_sq_size) &&
|
|
(is_power_of_2(val)))
|
|
hba->max_sqes = val;
|
|
}
|
|
|
|
return count;
|
|
|
|
skip_config:
|
|
printk(KERN_ERR "bnx2i: device busy, cannot change SQ size\n");
|
|
return 0;
|
|
}
|
|
|
|
|
|
/**
|
|
* bnx2i_show_ccell_info - returns command cell (HQ) size
|
|
* @dev: device pointer
|
|
* @attr: device attribute (unused)
|
|
* @buf: buffer to return current SQ size parameter
|
|
*
|
|
* returns per-connection TCP history queue size parameter
|
|
*/
|
|
static ssize_t bnx2i_show_ccell_info(struct device *dev,
|
|
struct device_attribute *attr, char *buf)
|
|
{
|
|
struct bnx2i_hba *hba = bnx2i_dev_to_hba(dev);
|
|
|
|
return sprintf(buf, "0x%x\n", hba->num_ccell);
|
|
}
|
|
|
|
|
|
/**
|
|
* bnx2i_get_link_state - set command cell (HQ) size
|
|
* @dev: device pointer
|
|
* @attr: device attribute (unused)
|
|
* @buf: buffer to return current SQ size parameter
|
|
* @count: parameter buffer size
|
|
*
|
|
* updates per-connection TCP history queue size parameter
|
|
*/
|
|
static ssize_t bnx2i_set_ccell_info(struct device *dev,
|
|
struct device_attribute *attr,
|
|
const char *buf, size_t count)
|
|
{
|
|
u32 val;
|
|
struct bnx2i_hba *hba = bnx2i_dev_to_hba(dev);
|
|
|
|
if (hba->ofld_conns_active)
|
|
goto skip_config;
|
|
|
|
if (sscanf(buf, " 0x%x ", &val) > 0) {
|
|
if ((val >= BNX2I_CCELLS_MIN) &&
|
|
(val <= BNX2I_CCELLS_MAX)) {
|
|
hba->num_ccell = val;
|
|
}
|
|
}
|
|
|
|
return count;
|
|
|
|
skip_config:
|
|
printk(KERN_ERR "bnx2i: device busy, cannot change CCELL size\n");
|
|
return 0;
|
|
}
|
|
|
|
|
|
static DEVICE_ATTR(sq_size, S_IRUGO | S_IWUSR,
|
|
bnx2i_show_sq_info, bnx2i_set_sq_info);
|
|
static DEVICE_ATTR(num_ccell, S_IRUGO | S_IWUSR,
|
|
bnx2i_show_ccell_info, bnx2i_set_ccell_info);
|
|
|
|
struct device_attribute *bnx2i_dev_attributes[] = {
|
|
&dev_attr_sq_size,
|
|
&dev_attr_num_ccell,
|
|
NULL
|
|
};
|