Linus Torvalds 353f7988dd
watchqueue: make sure to serialize 'wqueue->defunct' properly ...
When the pipe is closed, we mark the associated watchqueue defunct by
calling watch_queue_clear(). However, while that is protected by the
watchqueue lock, new watchqueue entries aren't actually added under that
lock at all: they use the pipe->rd_wait.lock instead, and looking up
that pipe happens without any locking.
The watchqueue code uses the RCU read-side section to make sure that the
wqueue entry itself hasn't disappeared, but that does not protect the
pipe_info in any way.
So make sure to actually hold the wqueue lock when posting watch events,
properly serializing against the pipe being torn down.
Reported-by: Noam Rathaus <noamr@ssd-disclosure.com >
Cc: Greg KH <gregkh@linuxfoundation.org >
Cc: David Howells <dhowells@redhat.com >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2022-07-20 10:46:07 -07:00
2022-07-08 10:55:53 +02:00
2022-06-16 09:37:02 -10:00
2022-04-06 19:56:29 +02:00
2022-05-26 17:13:43 -07:00
2022-06-23 15:26:59 +02:00
2022-06-08 09:16:31 -07:00
2022-07-13 11:29:12 +02:00
2022-05-25 16:18:27 -07:00
2021-12-02 17:25:21 +09:00
2022-06-09 15:58:13 +01:00
2022-05-25 11:32:53 -07:00
2022-06-02 08:55:01 -07:00
2022-06-13 10:29:57 +02:00
2022-07-11 10:19:09 -07:00
2022-06-21 20:57:30 +02:00
2022-07-15 10:52:11 +02:00
2022-06-23 19:11:28 +02:00
2022-06-13 10:15:07 +02:00
2022-07-11 09:52:59 -07:00
2022-07-12 16:36:34 -04:00
2022-04-06 13:43:44 -07:00
2022-02-03 11:20:34 -08:00
2022-04-25 14:37:18 +02:00
2022-04-25 14:37:28 +02:00
2022-04-25 14:37:12 +02:00
2022-01-25 13:22:51 -05:00
2022-02-22 13:51:40 -05:00
2022-01-11 13:08:21 -08:00
2022-06-15 19:28:44 -04:00
2022-03-09 10:32:06 -08:00
2022-06-13 09:18:46 -07:00
2022-05-23 17:51:12 -07:00
2022-05-27 11:22:03 -07:00
2022-03-15 10:32:44 +01:00
2022-06-01 15:55:25 -07:00
2022-07-11 09:52:59 -07:00
2022-02-16 23:25:12 +11:00
2022-06-03 16:03:05 -07:00
2022-05-08 03:16:59 +09:00
2022-06-23 19:11:28 +02:00
2022-04-15 14:49:55 -07:00
2022-05-10 14:42:06 -07:00
2022-03-31 10:36:55 +02:00
2022-05-25 13:05:42 -07:00
2022-05-27 11:22:03 -07:00
2022-07-13 10:13:41 -04:00
2022-05-29 10:31:36 -07:00
2022-03-23 19:00:33 -07:00
2022-06-16 19:11:30 -07:00
2022-04-21 11:40:59 -07:00
2022-06-06 08:06:00 +02:00
2022-05-19 19:30:30 +02:00
2022-01-31 11:21:46 +11:00
2022-06-23 19:11:28 +02:00
2021-12-28 11:26:18 +01:00
2022-04-29 14:38:00 -07:00
2022-06-06 08:06:00 +02:00
2022-01-08 12:43:57 -06:00
2022-07-09 11:06:19 -07:00
2022-06-23 19:11:28 +02:00
2022-05-12 20:38:37 -07:00
2022-03-23 19:00:35 -07:00
2022-02-02 13:11:34 +01:00
2022-04-11 17:07:29 -07:00
2022-03-24 19:06:48 -07:00
2022-05-03 14:11:58 -07:00
2022-07-07 09:53:43 -07:00
2022-05-24 11:11:13 -07:00
2022-04-12 14:13:01 +02:00
2022-05-01 10:03:43 +02:00
2022-05-08 01:33:09 -07:00
2022-02-25 09:36:06 +01:00
2022-04-05 09:59:38 +02:00
2022-04-05 09:59:38 +02:00
2022-05-24 11:11:13 -07:00
2022-01-15 16:30:30 +02:00
2022-04-22 18:50:54 +01:00
2022-07-15 09:52:35 -07:00
2022-04-30 08:39:32 -06:00
2022-04-29 14:38:03 -07:00
2022-02-01 17:24:39 -08:00
2022-04-29 14:38:03 -07:00
2022-02-17 09:11:57 -06:00
2022-05-06 14:49:44 -05:00
2022-02-25 10:40:14 -06:00
2022-05-19 23:25:47 -04:00
2022-07-20 10:46:07 -07:00
2022-06-23 18:41:40 +02:00
2022-06-23 19:11:28 +02:00
2022-06-07 07:07:14 -10:00
353f7988dd