linux/net/l2tp
Tom Parkin ab6934e084 l2tp: WARN_ON rather than BUG_ON in l2tp_session_free
l2tp_session_free called BUG_ON if the tunnel magic feather value wasn't
correct.  The intent of this was to catch lifetime bugs; for example
early tunnel free due to incorrect use of reference counts.

Since the tunnel magic feather being wrong indicates either early free
or structure corruption, we can avoid doing more damage by simply
leaving the tunnel structure alone.  If the tunnel refcount isn't
dropped when it should be, the tunnel instance will remain in the
kernel, resulting in the tunnel structure and socket leaking.

Signed-off-by: Tom Parkin <tparkin@katalix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2020-07-24 17:19:14 -07:00
..
Kconfig treewide: replace '---help---' in Kconfig files with 'help' 2020-06-14 01:57:21 +09:00
l2tp_core.c l2tp: WARN_ON rather than BUG_ON in l2tp_session_free 2020-07-24 17:19:14 -07:00
l2tp_core.h l2tp: prefer using BIT macro 2020-07-22 18:08:39 -07:00
l2tp_debugfs.c l2tp: WARN_ON rather than BUG_ON in l2tp_dfs_seq_start 2020-07-24 17:19:14 -07:00
l2tp_eth.c l2tp: cleanup comments 2020-07-22 18:08:39 -07:00
l2tp_ip6.c l2tp: avoid multiple assignments 2020-07-24 17:19:14 -07:00
l2tp_ip.c l2tp: avoid multiple assignments 2020-07-24 17:19:14 -07:00
l2tp_netlink.c l2tp: cleanup netlink tunnel create address handling 2020-07-23 11:54:40 -07:00
l2tp_ppp.c l2tp: don't BUG_ON seqfile checks in l2tp_ppp 2020-07-24 17:19:14 -07:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00