6166174afc
After converting to builtin driver, the probe function should not call
__init functions anymore:
>> WARNING: modpost: vmlinux.o(.text+0x8884d4):
Section mismatch in reference from the function exynos_chipid_probe() to the function .init.text:product_id_to_soc_id()
Reported-by: kernel test robot <lkp@intel.com>
Fixes: 352bfbb3e0 ("soc: samsung: exynos-chipid: convert to driver and merge exynos-asv")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20210105174440.120041-1-krzk@kernel.org
142 lines
3.4 KiB
C
142 lines
3.4 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Copyright (c) 2019 Samsung Electronics Co., Ltd.
|
|
* http://www.samsung.com/
|
|
* Copyright (c) 2020 Krzysztof Kozlowski <krzk@kernel.org>
|
|
*
|
|
* Exynos - CHIP ID support
|
|
* Author: Pankaj Dubey <pankaj.dubey@samsung.com>
|
|
* Author: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
|
|
* Author: Krzysztof Kozlowski <krzk@kernel.org>
|
|
*
|
|
* Samsung Exynos SoC Adaptive Supply Voltage and Chip ID support
|
|
*/
|
|
|
|
#include <linux/device.h>
|
|
#include <linux/errno.h>
|
|
#include <linux/mfd/syscon.h>
|
|
#include <linux/of.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/regmap.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/soc/samsung/exynos-chipid.h>
|
|
#include <linux/sys_soc.h>
|
|
|
|
#include "exynos-asv.h"
|
|
|
|
static const struct exynos_soc_id {
|
|
const char *name;
|
|
unsigned int id;
|
|
} soc_ids[] = {
|
|
/* List ordered by SoC name */
|
|
{ "EXYNOS3250", 0xE3472000 },
|
|
{ "EXYNOS4210", 0x43200000 }, /* EVT0 revision */
|
|
{ "EXYNOS4210", 0x43210000 },
|
|
{ "EXYNOS4212", 0x43220000 },
|
|
{ "EXYNOS4412", 0xE4412000 },
|
|
{ "EXYNOS5250", 0x43520000 },
|
|
{ "EXYNOS5260", 0xE5260000 },
|
|
{ "EXYNOS5410", 0xE5410000 },
|
|
{ "EXYNOS5420", 0xE5420000 },
|
|
{ "EXYNOS5433", 0xE5433000 },
|
|
{ "EXYNOS5440", 0xE5440000 },
|
|
{ "EXYNOS5800", 0xE5422000 },
|
|
{ "EXYNOS7420", 0xE7420000 },
|
|
};
|
|
|
|
static const char *product_id_to_soc_id(unsigned int product_id)
|
|
{
|
|
int i;
|
|
|
|
for (i = 0; i < ARRAY_SIZE(soc_ids); i++)
|
|
if ((product_id & EXYNOS_MASK) == soc_ids[i].id)
|
|
return soc_ids[i].name;
|
|
return NULL;
|
|
}
|
|
|
|
static int exynos_chipid_probe(struct platform_device *pdev)
|
|
{
|
|
struct soc_device_attribute *soc_dev_attr;
|
|
struct soc_device *soc_dev;
|
|
struct device_node *root;
|
|
struct regmap *regmap;
|
|
u32 product_id;
|
|
u32 revision;
|
|
int ret;
|
|
|
|
regmap = device_node_to_regmap(pdev->dev.of_node);
|
|
if (IS_ERR(regmap))
|
|
return PTR_ERR(regmap);
|
|
|
|
ret = regmap_read(regmap, EXYNOS_CHIPID_REG_PRO_ID, &product_id);
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
revision = product_id & EXYNOS_REV_MASK;
|
|
|
|
soc_dev_attr = devm_kzalloc(&pdev->dev, sizeof(*soc_dev_attr),
|
|
GFP_KERNEL);
|
|
if (!soc_dev_attr)
|
|
return -ENOMEM;
|
|
|
|
soc_dev_attr->family = "Samsung Exynos";
|
|
|
|
root = of_find_node_by_path("/");
|
|
of_property_read_string(root, "model", &soc_dev_attr->machine);
|
|
of_node_put(root);
|
|
|
|
soc_dev_attr->revision = devm_kasprintf(&pdev->dev, GFP_KERNEL,
|
|
"%x", revision);
|
|
soc_dev_attr->soc_id = product_id_to_soc_id(product_id);
|
|
if (!soc_dev_attr->soc_id) {
|
|
pr_err("Unknown SoC\n");
|
|
return -ENODEV;
|
|
}
|
|
|
|
/* please note that the actual registration will be deferred */
|
|
soc_dev = soc_device_register(soc_dev_attr);
|
|
if (IS_ERR(soc_dev))
|
|
return PTR_ERR(soc_dev);
|
|
|
|
ret = exynos_asv_init(&pdev->dev, regmap);
|
|
if (ret)
|
|
goto err;
|
|
|
|
platform_set_drvdata(pdev, soc_dev);
|
|
|
|
dev_info(soc_device_to_device(soc_dev),
|
|
"Exynos: CPU[%s] PRO_ID[0x%x] REV[0x%x] Detected\n",
|
|
soc_dev_attr->soc_id, product_id, revision);
|
|
|
|
return 0;
|
|
|
|
err:
|
|
soc_device_unregister(soc_dev);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int exynos_chipid_remove(struct platform_device *pdev)
|
|
{
|
|
struct soc_device *soc_dev = platform_get_drvdata(pdev);
|
|
|
|
soc_device_unregister(soc_dev);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct of_device_id exynos_chipid_of_device_ids[] = {
|
|
{ .compatible = "samsung,exynos4210-chipid" },
|
|
{}
|
|
};
|
|
|
|
static struct platform_driver exynos_chipid_driver = {
|
|
.driver = {
|
|
.name = "exynos-chipid",
|
|
.of_match_table = exynos_chipid_of_device_ids,
|
|
},
|
|
.probe = exynos_chipid_probe,
|
|
.remove = exynos_chipid_remove,
|
|
};
|
|
builtin_platform_driver(exynos_chipid_driver);
|