Hans de Goede a5aca20574 staging: vboxvideo: Fix modeset / page_flip error handling ... The default settings for Linux vms created in VirtualBox allocate only 16M of videomem. When running fullscreen on a 1920x1080 (or bigger) monitor this is not a lot. When using GNOME3 on Wayland we have already been seeing out of video memory errors for a while now. After commit 2408898e3b ("staging: vboxvideo: Add page-flip support") this has become much worse as now multiple buffers are used. There is nothing we can do about there not being enough video-mem, but we should handle running out of video-mem properly, currently there are 2 problems with this: 1) vbox_crtc_mode_set() does not check if vbox_crtc_mode_set_base() fails at all and does not properly propagate the oom error. 2) vbox_crtc_do_set_base() unpins the old fb too soon: 2.1) It unpins it before pinning the new fb, so if the pinning of the new fb fails (which it will when we run out of video-mem), then we also cannot fall back to the old-fb as it has been already unpinned. We could try to re-pin it but there is no guarantee that will succeed. 2.2) It unpins it before reprogramming the hardware to scan out from the new-fb, which could lead to some ugliness where the hw is scanning out the oldfb while it is being replaced with something else. Fixing this requires to do things in this order: 1) Pin the new fb 2) Program the hw 3) Unpin the oldfb This needs to be done for both a mode_set and for a page_flip so this commit re-writes vbox_crtc_do_set_base() into vbox_crtc_set_base_and_mode() which does this in the correct order, putting the hardware programming which was duplicated between the mode_set and page_flip code inside the new function. Signed-off-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2018-09-18 13:22:59 +02:00
..
hgsmi_base.c
hgsmi_ch_setup.h
hgsmi_channels.h
hgsmi_defs.h
Kconfig	staging: vboxvideo: select DRM_TTM	2017-08-18 15:57:15 -07:00
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
modesetting.c
TODO	staging: vboxvideo: Update driver to use drm_dev_register.	2018-06-17 09:05:13 +02:00
vbox_drv.c	staging: vboxvideo: Fix IRQs no longer working	2018-09-11 18:39:54 +02:00
vbox_drv.h	staging: vboxvideo: Update driver to use drm_dev_register.	2018-06-17 09:05:13 +02:00
vbox_err.h
vbox_fb.c	vboxvideo: Fix incorrect type in assignment sparse warning	2018-01-08 16:03:45 +01:00
vbox_hgsmi.c
vbox_irq.c	staging: vboxvideo: Fix reporting invalid suggested-offset-properties	2017-10-18 16:44:00 +02:00
vbox_main.c	staging/vboxvideo: Replace ttm_bo_unref with ttm_bo_put	2018-09-10 17:02:52 +02:00
vbox_mode.c	staging: vboxvideo: Fix modeset / page_flip error handling	2018-09-18 13:22:59 +02:00
vbox_prime.c
vbox_ttm.c	drm/ttm: add bo as parameter to the ttm_tt_create callback	2018-03-14 14:38:27 -05:00
vboxvideo_guest.h
vboxvideo_vbe.h
vboxvideo.h
vbva_base.c