leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
9f4bc8cf3f
linux/drivers/staging/rtl8712
History
Larry Finger 9f4bc8cf3f staging: r8712u: Fix regression introduced by commit a5ee652 
In commit a5ee652 "staging: r8712u: Interface-state not fully tracked",
the private boolean "bup" was set false when the interface was brought down,
as that seemed appropriate. This change has not caused any problems when
using NetworkManager or manual control of the device; however, when wicd
control is used, there is a locking problem in wpa_supplicant, as shown in
https://bugzilla.kernel.org/show_bug.cgi?id=42818.

This fix reverts the only code change in commit a5ee652. My
analysis is that "bup" is badly named. In its present form, it
seems to indicate the up/down state of the device, but its usage
is more consistent with an initialized/uninitialized state. That
problem will be addressed in a later patch.

Note: Commit 8c213fa, which introdued asynchronous firmware loading
for this driver, exposed this bug to a greater extent. That bug
is addressed in the next patch in this series.

This bug is also responsible for the bug in
https://bugzilla.kernel.org/show_bug.cgi?id=42815. and this bug is
also part of the problems discussed at https://bugs.archlinux.org/task/27996#comment89950.

Tested-by: Alberto Lago Ballesteros <saniukeokusainaya@gmail.com>
Tested-by: Adrian <agib@gmx.de>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Stable <stable@vger.kernel.org> [3.2+]
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-02-29 16:28:50 -08:00
..
basic_types.h staging: r8712u: Merging Realtek's latest (v2.6.6). Copyright banners. 2011-09-06 17:00:29 -07:00
big_endian.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added Larry's copyright. 2011-08-23 12:53:52 -07:00
drv_types.h Merge tag 'staging-3.3-rc3' into staging-next 2012-02-10 10:58:25 -08:00
ethernet.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added Larry's copyright. 2011-08-23 12:53:52 -07:00
generic.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added Larry's copyright. 2011-08-23 12:53:52 -07:00
hal_init.c staging: r8712u: Use asynchronous firmware loading 2012-02-08 14:14:15 -08:00
ieee80211.c staging: r8712u: Merging Realtek's latest (v2.6.6). Various fixes. 2011-09-06 17:00:35 -07:00
ieee80211.h staging: r8712u: Merging Realtek's latest (v2.6.6). Various fixes. 2011-09-06 17:00:35 -07:00
if_ether.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added Larry's copyright. 2011-08-23 12:53:52 -07:00
ip.h staging: rtl8712: fixed coding style issues 2011-04-20 14:13:31 -07:00
Kconfig staging: r8712u: Add missing initialization and remove configuration parameter CONFIG_R8712_AP 2012-02-10 09:57:28 -08:00
little_endian.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added Larry's copyright. 2011-08-23 12:53:52 -07:00
Makefile Staging: rtl8712: Makefile: replace the use of <module>-objs with <module>-y 2010-10-08 07:23:45 -07:00
mlme_linux.c
mlme_osdep.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added Larry's copyright. 2011-08-23 12:53:52 -07:00
mp_custom_oid.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added Larry's copyright. 2011-08-23 12:53:52 -07:00
os_intfs.c staging: r8712u: Fix regression introduced by commit a5ee652 2012-02-29 16:28:50 -08:00
osdep_intf.h staging: r8712u: Merging Realtek's latest (v2.6.6). Copyright banners. 2011-09-06 17:00:29 -07:00
osdep_service.h staging: r8712u: Simplify semaphores 2012-02-09 09:12:55 -08:00
recv_linux.c staging: r8712u: Merging Realtek's latest (v2.6.6). Updated include directives. 2011-09-06 17:00:32 -07:00
recv_osdep.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added Larry's copyright. 2011-08-23 12:53:52 -07:00
rtl871x_byteorder.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added copyright banners. 2011-08-23 12:53:52 -07:00
rtl871x_cmd.c staging: r8712u: Merging Realtek's latest (v2.6.6). Various fixes. 2011-09-06 17:00:35 -07:00
rtl871x_cmd.h staging: r8712u: Merging Realtek's latest (v2.6.6). Various fixes. 2011-09-06 17:00:35 -07:00
rtl871x_debug.h staging: r8712u: Merging Realtek's latest (v2.6.6). Copyright banners. 2011-09-06 17:00:29 -07:00
rtl871x_eeprom.c
rtl871x_eeprom.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added copyright banners. 2011-08-23 12:53:52 -07:00
rtl871x_event.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added Larry's copyright. 2011-08-23 12:53:52 -07:00
rtl871x_ht.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added Larry's copyright. 2011-08-23 12:53:52 -07:00
rtl871x_io.c staging: r8712u: Simplify semaphores 2012-02-09 09:12:55 -08:00
rtl871x_io.h staging: r8712u: Simplify semaphores 2012-02-09 09:12:55 -08:00
rtl871x_ioctl_linux.c staging: r8712u: Most return-values changed from -1 to proper errno macros. 2011-09-06 17:00:36 -07:00
rtl871x_ioctl_rtl.c staging: rtl8712: fixed coding style issues 2011-04-20 14:13:31 -07:00
rtl871x_ioctl_rtl.h staging: r8712u: Merging Realtek's latest (v2.6.6). Copyright banners. 2011-09-06 17:00:29 -07:00
rtl871x_ioctl_set.c staging: r8712u: Most return-values changed from -1 to proper errno macros. 2011-09-06 17:00:36 -07:00
rtl871x_ioctl_set.h staging: r8712u: Most return-values changed from -1 to proper errno macros. 2011-09-06 17:00:36 -07:00
rtl871x_ioctl.h
rtl871x_led.h staging: r8712u: Merging Realtek's latest (v2.6.6). Copyright banners. 2011-09-06 17:00:29 -07:00
rtl871x_mlme.c drivers/staging/rtl8712/rtl871x_mlme.c: eliminate a null pointer dereference 2011-11-26 17:19:23 -08:00
rtl871x_mlme.h staging: r8712u: Merging Realtek's latest (v2.6.6). Various fixes. 2011-09-06 17:00:35 -07:00
rtl871x_mp_ioctl.c staging: r8712u: Fix sparse message 2011-01-21 12:22:19 -08:00
rtl871x_mp_ioctl.h staging: r8712u: Merging Realtek's latest (v2.6.6). No power tracking OID. 2011-09-06 17:00:33 -07:00
rtl871x_mp_phy_regdef.h Fix common misspellings 2011-03-31 11:26:23 -03:00
rtl871x_mp.c staging: r8712u: Merging Realtek's latest (v2.6.6). Copyright banners. 2011-09-06 17:00:29 -07:00
rtl871x_mp.h staging: r8712u: Merging Realtek's latest (v2.6.6). Removed redundant .mem. 2011-09-06 17:00:32 -07:00
rtl871x_pwrctrl.c staging: r8712u: Simplify semaphores 2012-02-09 09:12:55 -08:00
rtl871x_pwrctrl.h staging: r8712u: Simplify semaphores 2012-02-09 09:12:55 -08:00
rtl871x_recv.c staging: r8712u: Simplify semaphores 2012-02-09 09:12:55 -08:00
rtl871x_recv.h staging: r8712u: Simplify semaphores 2012-02-09 09:12:55 -08:00
rtl871x_rf.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added Larry's copyright. 2011-08-23 12:53:52 -07:00
rtl871x_security.c staging: r8712u: Merging Realtek's latest (v2.6.6). Updated include directives. 2011-09-06 17:00:32 -07:00
rtl871x_security.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added Larry's copyright. 2011-08-23 12:53:52 -07:00
rtl871x_sta_mgt.c staging: r8712u: Add missing initialization and remove configuration parameter CONFIG_R8712_AP 2012-02-10 09:57:28 -08:00
rtl871x_wlan_sme.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added Larry's copyright. 2011-08-23 12:53:52 -07:00
rtl871x_xmit.c staging: r8712u: Simplify semaphores 2012-02-09 09:12:55 -08:00
rtl871x_xmit.h staging: r8712u: Simplify semaphores 2012-02-09 09:12:55 -08:00
rtl8712_bitdef.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added copyright banners. 2011-08-23 12:53:52 -07:00
rtl8712_cmd.c staging: r8712u: Merging Realtek's latest (v2.6.6). Updated include directives. 2011-09-06 17:00:32 -07:00
rtl8712_cmd.h staging: r8712u: Merging Realtek's latest (v2.6.6). New decl's and defines. 2011-09-06 17:00:35 -07:00
rtl8712_cmdctrl_bitdef.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added copyright banners. 2011-08-23 12:53:52 -07:00
rtl8712_cmdctrl_regdef.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added copyright banners. 2011-08-23 12:53:52 -07:00
rtl8712_debugctrl_bitdef.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added copyright banners. 2011-08-23 12:53:52 -07:00
rtl8712_debugctrl_regdef.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added copyright banners. 2011-08-23 12:53:52 -07:00
rtl8712_edcasetting_bitdef.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added Larry's copyright. 2011-08-23 12:53:52 -07:00
rtl8712_edcasetting_regdef.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added copyright banners. 2011-08-23 12:53:52 -07:00
rtl8712_efuse.c staging: r8712u: Merging Realtek's latest (v2.6.6). Rework efuse data handling. 2011-09-06 17:00:34 -07:00
rtl8712_efuse.h
rtl8712_event.h staging: r8712u: Merging Realtek's latest (v2.6.6). Copyright banners. 2011-09-06 17:00:29 -07:00
rtl8712_fifoctrl_bitdef.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added copyright banners. 2011-08-23 12:53:52 -07:00
rtl8712_fifoctrl_regdef.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added copyright banners. 2011-08-23 12:53:52 -07:00
rtl8712_gp_bitdef.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added Larry's copyright. 2011-08-23 12:53:52 -07:00
rtl8712_gp_regdef.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added Larry's copyright. 2011-08-23 12:53:52 -07:00
rtl8712_hal.h staging: r8712u: Use asynchronous firmware loading 2012-02-08 14:14:15 -08:00
rtl8712_interrupt_bitdef.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added copyright banners. 2011-08-23 12:53:52 -07:00
rtl8712_io.c
rtl8712_led.c staging: r8712u: Merging Realtek's latest (v2.6.6). Redundant NULL check. 2011-09-06 17:00:31 -07:00
rtl8712_macsetting_bitdef.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added copyright banners. 2011-08-23 12:53:52 -07:00
rtl8712_macsetting_regdef.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added copyright banners. 2011-08-23 12:53:52 -07:00
rtl8712_powersave_bitdef.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added copyright banners. 2011-08-23 12:53:52 -07:00
rtl8712_powersave_regdef.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added copyright banners. 2011-08-23 12:53:52 -07:00
rtl8712_ratectrl_bitdef.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added copyright banners. 2011-08-23 12:53:52 -07:00
rtl8712_ratectrl_regdef.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added Larry's copyright. 2011-08-23 12:53:52 -07:00
rtl8712_recv.c staging: r8712u: Simplify semaphores 2012-02-09 09:12:55 -08:00
rtl8712_recv.h staging: r8712u: Merging Realtek's latest (v2.6.6). Various fixes. 2011-09-06 17:00:35 -07:00
rtl8712_regdef.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added Larry's copyright. 2011-08-23 12:53:52 -07:00
rtl8712_security_bitdef.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added copyright banners. 2011-08-23 12:53:52 -07:00
rtl8712_spec.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added Larry's copyright. 2011-08-23 12:53:52 -07:00
rtl8712_syscfg_bitdef.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added Larry's copyright. 2011-08-23 12:53:52 -07:00
rtl8712_syscfg_regdef.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added Larry's copyright. 2011-08-23 12:53:52 -07:00
rtl8712_timectrl_bitdef.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added copyright banners. 2011-08-23 12:53:52 -07:00
rtl8712_timectrl_regdef.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added copyright banners. 2011-08-23 12:53:52 -07:00
rtl8712_wmac_bitdef.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added Larry's copyright. 2011-08-23 12:53:52 -07:00
rtl8712_wmac_regdef.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added Larry's copyright. 2011-08-23 12:53:52 -07:00
rtl8712_xmit.c staging: r8712u: Merging Realtek's latest (v2.6.6). Tx aggregation. 2011-09-06 17:00:35 -07:00
rtl8712_xmit.h staging: r8712u: Merging Realtek's latest (v2.6.6). Tx aggregation. 2011-09-06 17:00:35 -07:00
sta_info.h staging: r8712u: Add missing initialization and remove configuration parameter CONFIG_R8712_AP 2012-02-10 09:57:28 -08:00
swab.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added Larry's copyright. 2011-08-23 12:53:52 -07:00
TODO staging: r8712u: Switch driver to use external firmware from linux-firmware 2011-01-21 12:23:30 -08:00
usb_halinit.c Fix common misspellings 2011-03-31 11:26:23 -03:00
usb_intf.c Merge tag 'staging-3.3-rc3' into staging-next 2012-02-10 10:58:25 -08:00
usb_ops_linux.c staging: r8712u: Merging Realtek's latest (v2.6.6). Various fixes. 2011-09-06 17:00:35 -07:00
usb_ops.c
usb_ops.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added Larry's copyright. 2011-08-23 12:53:52 -07:00
usb_osintf.h staging: r8712u: Merging Realtek's latest (v2.6.6). stop_drv_timers moved. 2011-09-06 17:00:33 -07:00
usb_vendor_req.h staging: r8712u: Merging Realtek's latest (v2.6.6). Added Larry's copyright. 2011-08-23 12:53:52 -07:00
wifi.h staging: r8712u: Merging Realtek's latest (v2.6.6). Copyright banners. 2011-09-06 17:00:29 -07:00
wlan_bssdef.h staging: r8712u: Merging Realtek's latest (v2.6.6). Copyright banners. 2011-09-06 17:00:29 -07:00
xmit_linux.c staging: r8712u: Merging Realtek's latest (v2.6.6). tx: NULL _in_ spin lock. 2011-09-06 17:00:34 -07:00
xmit_osdep.h staging: r8712u: Merging Realtek's latest (v2.6.6). tx: NULL _in_ spin lock. 2011-09-06 17:00:34 -07:00