linux/tools/perf/util/intel-pt-decoder
Adrian Hunter 9992c2d50a perf intel-pt: Fix potential loop forever
TSC packets contain only 7 bytes of TSC.  The 8th byte is assumed to
change so infrequently that its value can be inferred.  However the
logic must cater for a 7 byte wraparound, which it does by adding 1 to
the top byte.

The existing code was doing that with a while loop even though the
addition should only need to be done once.  That logic won't work (will
loop forever) if TSC wraps around at the 8th byte.  Theoretically that
would take at least 10 years, unless something else went wrong.

And what else could go wrong.  Well, if the chunks of trace data are
processed out of order, it will make it look like the 7-byte TSC has
gone backwards (i.e. wrapped).  If that happens 256 times then stuck in
the while loop it will be.

Fix that by getting rid of the unnecessary while loop.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Link: http://lkml.kernel.org/r/1443186956-18718-4-git-send-email-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2015-09-28 16:44:31 -03:00
..
Build perf tools: Display build warning if x86 instruction decoder differs from kernel 2015-09-04 12:01:01 -03:00
gen-insn-attr-x86.awk perf tools: Add Intel PT instruction decoder 2015-08-17 11:11:36 -03:00
inat_types.h perf tools: Fix tarball build broken by pt/bts 2015-08-22 12:27:07 -03:00
inat.c perf tools: Fix tarball build broken by pt/bts 2015-08-22 12:27:07 -03:00
inat.h perf tools: Fix tarball build broken by pt/bts 2015-08-22 12:27:07 -03:00
insn.c perf tools: Fix tarball build broken by pt/bts 2015-08-22 12:27:07 -03:00
insn.h perf tools: Fix tarball build broken by pt/bts 2015-08-22 12:27:07 -03:00
intel-pt-decoder.c perf intel-pt: Fix potential loop forever 2015-09-28 16:44:31 -03:00
intel-pt-decoder.h perf tools: Add Intel PT support for decoding MTC packets 2015-08-24 17:46:56 -03:00
intel-pt-insn-decoder.c perf tools: Fix build on powerpc broken by pt/bts 2015-08-31 15:47:33 -03:00
intel-pt-insn-decoder.h perf tools: Add Intel PT instruction decoder 2015-08-17 11:11:36 -03:00
intel-pt-log.c perf tools: Add Intel PT log 2015-08-17 11:11:36 -03:00
intel-pt-log.h perf tools: Add Intel PT log 2015-08-17 11:11:36 -03:00
intel-pt-pkt-decoder.c perf tools: Add new Intel PT packet definitions 2015-08-24 17:46:06 -03:00
intel-pt-pkt-decoder.h perf tools: Add new Intel PT packet definitions 2015-08-24 17:46:06 -03:00
x86-opcode-map.txt x86/insn: perf tools: Add new xsave instructions 2015-09-04 12:01:04 -03:00