linux/drivers/scsi/mpt3sas
Calvin Owens 8bbb1cf63f mpt3sas: Fix warnings exposed by W=1
Trivial non-functional changes for a couple annoying things:

  1) Functions local to files are not declared static, which is
  frustrating when reading the code because it's non-obvious at first
  glance what's actually called from other files.

  2) Set-but-unused variables abound, presumably to mask -Wunused-result
  errors in the past. None of these are flagged today though (with one
  exception noted below), so remove them.

Fixing (2) exposed the fact that we improperly ignore the return value
of scsi_device_reprobe() in _scsih_reprobe_lun(). Fixing the calling
code to deal with the potential error is non-trivial, so for now just
WARN().

Signed-off-by: Calvin Owens <calvinowens@fb.com>
Acked-by: Chaitra P B <chaitra.basappa@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2016-08-08 21:15:32 -04:00
..
mpi mpt3sas: Update MPI header to 2.00.42 2016-05-11 16:10:56 -04:00
Kconfig mpt3sas: fix Kconfig dependency problem for mpt2sas back compatibility 2015-12-03 09:31:23 -08:00
Makefile mpt3sas: Single driver module which supports both SAS 2.0 & SAS 3.0 HBAs 2015-11-11 19:50:11 -05:00
mpt3sas_base.c mpt3sas: Fix warnings exposed by W=1 2016-08-08 21:15:32 -04:00
mpt3sas_base.h mpt3sas: Eliminate dead sleep_flag code 2016-08-08 21:13:48 -04:00
mpt3sas_config.c mpt3sas: Fix warnings exposed by W=1 2016-08-08 21:15:32 -04:00
mpt3sas_ctl.c mpt3sas: Fix warnings exposed by W=1 2016-08-08 21:15:32 -04:00
mpt3sas_ctl.h mpt3sas: Ported WarpDrive product SSS6200 support 2015-11-11 18:56:10 -05:00
mpt3sas_debug.h mpt2sas, mpt3sas: Remove SCSI_MPTXSAS_LOGGING entry from Kconfig 2015-11-11 18:31:14 -05:00
mpt3sas_scsih.c mpt3sas: Fix warnings exposed by W=1 2016-08-08 21:15:32 -04:00
mpt3sas_transport.c mpt3sas: Fix warnings exposed by W=1 2016-08-08 21:15:32 -04:00
mpt3sas_trigger_diag.c mpt2sas, mpt3sas: Update attribution language to Avago 2015-01-13 16:27:27 +01:00
mpt3sas_trigger_diag.h mpt2sas, mpt3sas: Update attribution language to Avago 2015-01-13 16:27:27 +01:00
mpt3sas_warpdrive.c mpt3sas: Single driver module which supports both SAS 2.0 & SAS 3.0 HBAs 2015-11-11 19:50:11 -05:00