Maarten Lankhorst
12235da8c8
kernel/locking: Add context to ww_mutex_trylock()
...
i915 will soon gain an eviction path that trylock a whole lot of locks
for eviction, getting dmesg failures like below:
BUG: MAX_LOCK_DEPTH too low!
turning off the locking correctness validator.
depth: 48 max: 48!
48 locks held by i915_selftest/5776:
#0 : ffff888101a79240 (&dev->mutex){....}-{3:3}, at: __driver_attach+0x88/0x160
#1 : ffffc900009778c0 (reservation_ww_class_acquire){+.+.}-{0:0}, at: i915_vma_pin.constprop.63+0x39/0x1b0 [i915]
#2 : ffff88800cf74de8 (reservation_ww_class_mutex){+.+.}-{3:3}, at: i915_vma_pin.constprop.63+0x5f/0x1b0 [i915]
#3 : ffff88810c7f9e38 (&vm->mutex/1){+.+.}-{3:3}, at: i915_vma_pin_ww+0x1c4/0x9d0 [i915]
#4 : ffff88810bad5768 (reservation_ww_class_mutex){+.+.}-{3:3}, at: i915_gem_evict_something+0x110/0x860 [i915]
#5 : ffff88810bad60e8 (reservation_ww_class_mutex){+.+.}-{3:3}, at: i915_gem_evict_something+0x110/0x860 [i915]
...
#46 : ffff88811964d768 (reservation_ww_class_mutex){+.+.}-{3:3}, at: i915_gem_evict_something+0x110/0x860 [i915]
#47 : ffff88811964e0e8 (reservation_ww_class_mutex){+.+.}-{3:3}, at: i915_gem_evict_something+0x110/0x860 [i915]
INFO: lockdep is turned off.
Fixing eviction to nest into ww_class_acquire is a high priority, but
it requires a rework of the entire driver, which can only be done one
step at a time.
As an intermediate solution, add an acquire context to
ww_mutex_trylock, which allows us to do proper nesting annotations on
the trylocks, making the above lockdep splat disappear.
This is also useful in regulator_lock_nested, which may avoid dropping
regulator_nesting_mutex in the uncontended path, so use it there.
TTM may be another user for this, where we could lock a buffer in a
fastpath with list locks held, without dropping all locks we hold.
[peterz: rework actual ww_mutex_trylock() implementations]
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com >
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org >
Link: https://lkml.kernel.org/r/YUBGPdDDjKlxAuXJ@hirez.programming.kicks-ass.net
2021-09-17 15:08:41 +02:00
..
2020-08-10 01:32:59 +09:00
2021-07-30 10:58:30 +08:00
2020-11-18 14:15:17 -06:00
2021-07-08 11:48:20 -07:00
2021-09-03 15:33:47 -07:00
2020-08-09 14:10:26 -07:00
2021-07-01 11:06:05 -07:00
2020-12-15 22:46:19 -08:00
2021-09-08 11:50:26 -07:00
2021-08-12 19:17:00 +08:00
2021-07-08 11:48:20 -07:00
2021-01-04 10:38:11 +09:00
2021-07-08 11:48:20 -07:00
2021-04-14 23:04:44 +10:00
2021-07-01 11:06:05 -07:00
2020-08-10 01:32:59 +09:00
2020-12-29 15:36:49 -08:00
2021-07-01 11:06:05 -07:00
2021-07-01 11:06:05 -07:00
2021-05-02 00:43:35 +09:00
2018-06-12 16:19:22 -07:00
2019-05-24 17:39:02 +02:00
2019-05-24 17:39:02 +02:00
2020-11-18 14:15:17 -06:00
2021-07-08 11:48:20 -07:00
2020-11-18 14:15:17 -06:00
2019-05-30 11:26:32 -07:00
2021-05-26 13:20:50 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2021-05-06 19:24:12 -07:00
2020-10-16 13:25:14 -06:00
2021-08-13 10:27:50 +02:00
2019-05-21 10:50:45 +02:00
2021-09-09 19:14:33 -04:00
2020-06-11 15:14:53 +02:00
2019-06-05 17:37:16 +02:00
2018-08-16 12:14:42 -07:00
2021-04-01 09:54:37 +01:00
2019-05-24 17:27:11 +02:00
2021-07-08 11:48:22 -07:00
2018-11-30 07:22:05 +01:00
2017-11-02 11:10:55 +01:00
2020-08-20 15:45:14 -04:00
2019-06-19 17:09:55 +02:00
2017-11-02 11:10:55 +01:00
2021-06-23 16:41:41 -06:00
2021-05-05 16:07:40 +02:00
2019-05-24 17:39:02 +02:00
2017-11-02 11:10:55 +01:00
2019-10-18 15:01:57 +02:00
2021-02-05 23:28:29 +01:00
2019-06-19 17:09:06 +02:00
2021-01-21 14:06:00 -07:00
2021-05-06 19:24:12 -07:00
2019-06-19 17:09:06 +02:00
2020-10-16 11:11:20 -07:00
2018-07-27 19:04:33 +08:00
2020-11-02 12:14:19 -08:00
2021-06-05 08:58:12 -07:00
2019-06-19 17:09:06 +02:00
2019-06-19 17:09:06 +02:00
2020-06-18 17:26:43 +10:00
2017-11-02 11:10:55 +01:00
2021-08-19 09:02:55 +09:00
2021-06-22 13:56:43 +02:00
2021-08-13 10:07:44 +02:00
2018-06-12 23:33:24 +02:00
2021-07-01 11:06:05 -07:00
2020-01-31 10:30:40 -08:00
2021-07-01 11:06:06 -07:00
2021-05-06 19:24:12 -07:00
2021-07-01 11:06:06 -07:00
2021-07-01 11:06:05 -07:00
2021-07-01 11:06:05 -07:00
2020-07-31 11:49:08 +02:00
2021-08-13 14:09:32 -10:00
2021-07-08 11:48:20 -07:00
2020-11-20 14:45:33 +11:00
2021-09-08 11:50:26 -07:00
2021-07-08 11:48:20 -07:00
2020-10-16 11:11:20 -07:00
2021-04-16 16:10:37 -07:00
2020-12-15 22:46:15 -08:00
2020-12-15 22:46:19 -08:00
2020-12-15 22:46:15 -08:00
2021-01-03 20:05:18 -05:00
2020-10-16 11:11:22 -07:00
2020-04-15 21:36:41 +01:00
2020-01-08 16:59:19 +00:00
2019-06-05 17:36:38 +02:00
2021-05-06 19:24:12 -07:00
2020-06-04 19:06:25 -07:00
2018-07-27 19:04:33 +08:00
2018-12-29 11:36:44 -08:00
2021-05-06 19:24:12 -07:00
2019-10-14 15:04:00 -07:00
2020-11-18 14:15:17 -06:00
2020-10-16 11:11:19 -07:00
2019-05-13 11:07:33 +02:00
2020-10-20 14:39:37 -07:00
2017-11-02 11:10:55 +01:00
2019-05-21 10:50:45 +02:00
2019-05-21 10:50:45 +02:00
2019-06-19 17:09:56 +02:00
2020-08-14 19:56:57 -07:00
2018-05-09 06:55:44 +02:00
2021-09-08 11:50:26 -07:00
2019-02-19 20:52:19 -07:00
2019-05-30 11:26:32 -07:00
2019-05-24 17:27:11 +02:00
2021-08-19 09:02:55 +09:00
2021-09-01 15:13:02 -07:00
2021-09-08 12:55:35 -07:00
2021-06-29 10:53:53 -07:00
2021-07-20 13:49:44 -07:00
2021-05-05 11:27:27 -07:00
2020-09-28 12:14:08 +01:00
2021-02-26 09:41:05 -08:00
2021-07-08 11:48:20 -07:00
2019-06-19 17:09:08 +02:00
2021-04-10 11:09:41 +02:00
2020-09-07 11:24:17 +02:00
2021-07-02 12:08:10 -07:00
2021-05-19 15:05:11 +02:00
2020-10-16 11:11:19 -07:00
2021-08-13 18:37:38 +02:00
2018-04-11 10:28:35 -07:00
2021-07-08 11:48:20 -07:00
2020-03-25 16:38:39 -06:00
2019-06-05 17:37:06 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2021-09-17 15:08:41 +02:00
2019-06-07 13:15:06 -07:00
2021-08-26 22:28:02 +02:00
2021-02-17 17:31:06 -06:00
2021-04-16 16:10:37 -07:00
2019-05-24 17:39:02 +02:00
2021-07-09 10:19:13 -07:00
2018-10-16 13:45:44 +02:00
2019-05-21 10:50:45 +02:00
2020-09-26 10:33:57 -07:00
2017-11-02 11:10:55 +01:00
2019-05-24 17:39:02 +02:00
2017-11-02 11:10:55 +01:00
2019-05-21 10:50:45 +02:00
2021-07-08 11:48:20 -07:00
2021-07-30 09:25:34 +02:00
2017-11-02 11:10:55 +01:00
2019-07-03 16:57:18 +02:00
2017-11-02 11:10:55 +01:00
2020-02-16 18:33:00 -08:00
2019-05-21 10:50:45 +02:00
2021-07-08 11:48:20 -07:00
2021-08-08 13:00:20 +01:00
2020-06-28 20:45:27 -07:00
2021-04-16 16:10:37 -07:00
2021-07-01 11:06:05 -07:00
2018-01-26 11:45:16 -06:00
2021-05-06 19:24:12 -07:00
2019-05-21 10:50:45 +02:00
2021-05-13 03:27:38 +00:00
2019-05-21 11:28:45 +02:00
2019-05-21 10:50:45 +02:00
2021-04-16 16:10:37 -07:00
2020-10-24 20:21:57 +02:00
2019-06-05 17:37:16 +02:00
2019-09-25 17:51:39 -07:00
2020-08-12 10:58:00 -07:00
2021-07-08 11:48:20 -07:00
2021-07-08 11:48:20 -07:00
2021-07-08 11:48:20 -07:00
2021-09-03 10:08:28 -07:00
2021-07-08 11:48:20 -07:00
2021-08-24 19:52:40 -03:00
2019-08-08 07:45:01 -06:00
2020-11-20 14:45:33 +11:00
2019-09-24 15:54:09 -07:00
2020-11-18 14:15:17 -06:00
2021-06-29 10:53:46 -07:00
2021-05-19 10:51:40 +02:00
2021-07-08 11:48:20 -07:00
2021-07-08 11:48:20 -07:00
2019-05-30 11:26:32 -07:00
2021-07-19 11:39:28 +02:00
2021-08-30 07:50:56 -07:00
2020-11-19 11:56:16 -08:00
2020-05-01 12:35:21 +10:00
2021-06-18 11:43:09 +02:00
2021-08-13 10:27:49 +02:00
2021-07-08 11:48:20 -07:00
2020-08-12 10:58:00 -07:00
2019-07-01 19:34:46 -07:00
2021-08-17 00:45:07 +02:00
2019-05-21 10:50:45 +02:00
2021-05-13 16:14:45 +02:00
2021-01-18 11:03:26 +01:00
2020-12-15 22:46:16 -08:00
2019-05-21 10:50:45 +02:00
2018-11-30 12:13:15 -08:00
2021-07-01 11:06:03 -07:00
2021-07-15 10:13:49 -07:00
2018-10-15 16:31:29 -04:00
2021-09-03 09:58:15 -07:00
2021-09-03 10:08:28 -07:00
2021-07-08 11:48:20 -07:00
2020-05-08 18:18:12 +01:00
2021-06-25 11:31:03 -06:00
2021-08-17 19:05:33 +02:00
2018-10-16 13:45:44 +02:00
2019-12-04 19:44:13 -08:00
2020-03-06 11:56:59 +01:00
2019-05-21 10:50:45 +02:00
2020-06-15 13:32:11 -07:00
2019-07-16 19:23:22 -07:00
2021-09-08 12:55:35 -07:00
2021-03-24 15:16:09 -07:00
2021-09-06 11:04:03 -07:00
2021-09-08 11:50:26 -07:00
2021-08-22 00:21:36 -07:00
2019-06-05 17:36:37 +02:00
2019-06-05 17:36:37 +02:00
2021-07-01 11:06:05 -07:00
2019-04-08 16:44:21 -06:00
2020-10-16 11:11:20 -07:00
2021-02-26 09:41:05 -08:00
2019-10-16 14:56:21 +02:00
2017-07-21 09:38:30 +02:00
2021-09-03 09:58:14 -07:00
2021-03-30 13:42:33 -04:00
2021-07-19 11:39:28 +02:00
2019-10-03 12:12:23 -04:00
2021-02-17 14:08:01 +01:00
2020-08-12 10:58:00 -07:00
2020-11-18 14:15:17 -06:00
2020-04-07 10:43:43 -07:00
2021-08-13 13:19:06 -06:00
2021-02-05 11:03:47 -08:00
2019-05-24 17:39:02 +02:00
2018-06-07 17:34:39 -07:00
2020-10-16 11:11:22 -07:00
2020-03-23 17:01:47 +01:00
2021-09-08 12:55:35 -07:00
2017-11-02 11:10:55 +01:00
2021-03-30 13:42:33 -04:00
2020-08-12 10:58:00 -07:00