linux/drivers/i2c
Jean Delvare 849be516c5 i2c-ali1563: Fix device initialization
The i2c-ali1563 initialization looks quite broken to me:
* If the I/O space isn't enabled, we forcibly set 3 bits in
  the PCI configuration space instead of just the one enabling
  the I/O space.
* After that we pretend to check if the write worked, but we
  don't actually read the new value from the register.
* It's probably not a good idea to enable the I/O space if no
  base address has been set.

So I propose the following changes to that part of the driver:
* Merge ali1563_enable() into ali1563_setup().
* Check the base address before the I/O space enabled bit.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Acked-by: Rudolf Marek <r.marek@assembler.cz>
2007-02-13 22:08:57 +01:00
..
algos i2c: Discard the i2c algo del_bus wrappers 2006-12-10 21:21:33 +01:00
busses i2c-ali1563: Fix device initialization 2007-02-13 22:08:57 +01:00
chips [PATCH] mark struct file_operations const 3 2007-02-12 09:48:45 -08:00
i2c-core.c i2c: Migration aids for i2c_adapter.dev removal 2007-01-04 13:07:04 +01:00
i2c-dev.c [PATCH] mark struct file_operations const 3 2007-02-12 09:48:45 -08:00
Kconfig i2c: Fix copy-n-paste in subsystem Kconfig 2006-09-26 15:38:51 -07:00
Makefile [PATCH] hwmon: hwmon vs i2c, second round (07/11) 2005-09-05 09:14:22 -07:00