715bd9d12f
The syscall fallbacks in the vDSO have incorrect asm constraints.
They are not marked as writing to their outputs -- instead, they are
marked as clobbering "memory", which is useless. In particular, gcc
is smart enough to know that the timespec parameter hasn't escaped,
so a memory clobber doesn't clobber it. And passing a pointer as an
asm *input* does not tell gcc that the pointed-to value is changed.
Add in the fact that the asm instructions weren't volatile, and gcc
was free to omit them entirely unless their sole output (the return
value) is used. Which it is (phew!), but that stops happening with
some upcoming patches.
As a trivial example, the following code:
void test_fallback(struct timespec *ts)
{
vdso_fallback_gettime(CLOCK_MONOTONIC, ts);
}
compiles to:
00000000000000c0 <test_fallback>:
c0: c3 retq
To add insult to injury, the RCX and R11 clobbers on 64-bit
builds were missing.
The "memory" clobber is also unnecessary -- no ordering with respect to
other memory operations is needed, but that's going to be fixed in a
separate not-for-stable patch.
Fixes:
|
||
|---|---|---|
| .. | ||
| vdso32 | ||
| .gitignore | ||
| checkundef.sh | ||
| Makefile | ||
| vclock_gettime.c | ||
| vdso2c.c | ||
| vdso2c.h | ||
| vdso32-setup.c | ||
| vdso-layout.lds.S | ||
| vdso-note.S | ||
| vdso.lds.S | ||
| vdsox32.lds.S | ||
| vgetcpu.c | ||
| vma.c | ||