leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
6cc7e5a9c6b02507b9be5a99b51e970afa91c85f
linux/arch/x86/mm
History
NeilBrown 3d2fc4c082 x86: fix seq_file iteration for pat/memtype.c 
The memtype seq_file iterator allocates a buffer in the ->start and ->next
functions and frees it in the ->show function.  The preferred handling for
such resources is to free them in the subsequent ->next or ->stop function
call.

Since Commit 1f4aace60b ("fs/seq_file.c: simplify seq_file iteration
code and interface") there is no guarantee that ->show will be called
after ->next, so this function can now leak memory.

So move the freeing of the buffer to ->next and ->stop.

Link: https://lkml.kernel.org/r/161248539022.21478.13874455485854739066.stgit@noble1
Fixes: 1f4aace60b ("fs/seq_file.c: simplify seq_file iteration code and interface")
Signed-off-by: NeilBrown <neilb@suse.de>
Cc: Xin Long <lucien.xin@gmail.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Cc: Neil Horman <nhorman@tuxdriver.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Vlad Yasevich <vyasevich@gmail.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2021-02-26 09:41:05 -08:00
..
pat
x86: fix seq_file iteration for pat/memtype.c
2021-02-26 09:41:05 -08:00
amdtopology.c
mm: remove include/linux/bootmem.h
2018-10-31 08:54:16 -07:00
cpu_entry_area.c
x86/dumpstack/64: Add noinstr version of get_stack_info()
2020-09-09 11:33:19 +02:00
debug_pagetables.c
mm: introduce include/linux/pgtable.h
2020-06-09 09:39:13 -07:00
dump_pagetables.c
mm: don't include asm/pgtable.h if linux/mm.h is already included
2020-06-09 09:39:13 -07:00
extable.c
Merge tag 'x86_seves_for_v5.10' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2020-10-14 10:21:34 -07:00
fault.c
kfence: add test suite
2021-02-26 09:41:02 -08:00
highmem_32.c
x86/mm/highmem: Use generic kmap atomic implementation
2020-11-06 23:14:55 +01:00
hugetlbpage.c
mm: remove unneeded includes of <asm/pgalloc.h>
2020-08-07 11:33:26 -07:00
ident_map.c
x86/mm/ident_map: Check for errors from ident_pud_init()
2020-10-28 14:48:30 +01:00
init_32.c
x86/mm/highmem: Use generic kmap atomic implementation
2020-11-06 23:14:55 +01:00
init_64.c
x86/mm/64: Update comment in preallocate_vmalloc_pages()
2020-08-15 13:56:16 +02:00
init.c
x86/mm: Increase pgt_buf size for 5-level page tables
2021-01-04 18:07:50 +01:00
iomap_32.c
io-mapping: Cleanup atomic iomap
2020-11-06 23:14:58 +01:00
ioremap.c
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
kasan_init_64.c
mm: don't include asm/pgtable.h if linux/mm.h is already included
2020-06-09 09:39:13 -07:00
kaslr.c
mm: remove unneeded includes of <asm/pgalloc.h>
2020-08-07 11:33:26 -07:00
kmmio.c
Merge tag 'x86-mm-2020-06-05' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2020-06-05 11:18:53 -07:00
maccess.c
maccess: rename probe_kernel_{read,write} to copy_{from,to}_kernel_nofault
2020-06-17 10:57:41 -07:00
Makefile
kbuild: remove cc-option test of -fno-stack-protector
2020-07-07 11:13:10 +09:00
mem_encrypt_boot.S
mm: introduce include/linux/pgtable.h
2020-06-09 09:39:13 -07:00
mem_encrypt_identity.c
x86/mm/mem_encrypt: Fix definition of PMD_FLAGS_DEC_WP
2020-12-10 12:28:06 +01:00
mem_encrypt.c
Merge tag 'x86_seves_for_v5.12' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2021-02-20 19:16:02 -08:00
mm_internal.h
x86/mm: thread pgprot_t through init_memory_mapping()
2020-04-10 15:36:21 -07:00
mmap.c
x86/mm/mmap: Fix -Wmissing-prototypes warnings
2020-04-22 20:19:48 +02:00
mmio-mod.c
x86: Remove definition of DEBUG
2021-01-15 08:23:10 +01:00
numa_32.c
x86/mm: Drop deprecated DISCONTIGMEM support for 32-bit
2020-05-28 18:34:30 +02:00
numa_64.c
mm: remove include/linux/bootmem.h
2018-10-31 08:54:16 -07:00
numa_emulation.c
x86/numa: cleanup configuration dependent command-line options
2020-10-13 18:38:27 -07:00
numa_internal.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
numa.c
mm: fix phys_to_target_node() and memory_add_physaddr_to_nid() exports
2020-11-22 10:48:22 -08:00
pf_in.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
2019-05-30 11:26:35 -07:00
pf_in.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
2019-05-30 11:26:35 -07:00
pgtable_32.c
mm: remove unneeded includes of <asm/pgalloc.h>
2020-08-07 11:33:26 -07:00
pgtable.c
x86/mm: Fix leak of pmd ptlock
2021-01-05 11:40:23 +01:00
physaddr.c
mm, x86/mm: Untangle address space layout definitions from basic pgtable type definitions
2019-12-10 10:12:55 +01:00
physaddr.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
pkeys.c
mm/vma: introduce VM_ACCESS_FLAGS
2020-04-10 15:36:21 -07:00
pti.c
mm: remove unneeded includes of <asm/pgalloc.h>
2020-08-07 11:33:26 -07:00
setup_nx.c
mm: reorder includes after introduction of linux/pgtable.h
2020-06-09 09:39:13 -07:00
srat.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
testmmiotrace.c
remove ioremap_nocache and devm_ioremap_nocache
2020-01-06 09:45:59 +01:00
tlb.c
x86/membarrier: Get rid of a dubious optimization
2020-12-09 09:37:42 +01:00