Wang Nan 6bb536cc4b perf probe: Fix segfault when glob matching function without debuginfo ... Commit 4c85935122 ("perf probe: Support glob wildcards for function name") introduces segfault problems when debuginfo is not available: # perf probe 'sys_w*' Added new events: Segmentation fault The first problem resides in find_probe_trace_events_from_map(). In that function, find_probe_functions() is called to match each symbol against glob to find the number of matching functions, but still use map__for_each_symbol_by_name() to find 'struct symbol' for matching functions. Unfortunately, map__for_each_symbol_by_name() does exact matching by searching in an rbtree. It doesn't know glob matching, and not easy for it to support it because it use rbtree based binary search, but we are unable to ensure all names matched by the glob (any glob passed by user) reside in one subtree. This patch drops map__for_each_symbol_by_name(). Since there is no rbtree again, re-matching all symbols costs a lot. This patch avoid it by saving all matching results into an array (syms). The second problem is the lost of tp->realname. In __add_probe_trace_events(), if pev->point.function is glob, the event name should be set to tev->point.realname. This patch ensures its existence by strdup sym->name instead of leaving a NULL pointer there. After this patch: # perf probe 'sys_w*' Added new events: probe:sys_waitid (on sys_w*) probe:sys_wait4 (on sys_w*) probe:sys_waitpid (on sys_w*) probe:sys_write (on sys_w*) probe:sys_writev (on sys_w*) You can now use it in all perf tools, such as: perf record -e probe:sys_writev -aR sleep 1 Signed-off-by: Wang Nan <wangnan0@huawei.com> Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Zefan Li <lizefan@huawei.com> Link: http://lkml.kernel.org/r/1432892747-232506-1-git-send-email-wangnan0@huawei.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>		2015-05-30 11:08:52 -03:00
..
arch	tools include: Add basic atomic.h implementation from the kernel sources	2015-05-08 16:11:05 -03:00
build	perf build: Do not fail on missing Build file	2015-05-29 12:44:25 -03:00
cgroup
firewire
hv	hv: hypervvssd: call endmntent before call setmntent again	2015-03-25 11:53:54 +01:00
iio	tools: iio: generic_buffer: Fix generic scale extraction	2015-03-28 11:01:49 +00:00
include	tools include: add __aligned_u64 to types.h.	2015-05-18 10:17:32 -03:00
lguest	tools/lguest: don't use legacy definitions for net device in example launcher.	2015-02-13 17:15:55 +10:30
lib	Merge branch 'perf/urgent' into perf/core, before applying dependent patches	2015-05-27 09:17:21 +02:00
net	tools: bpf_asm: cleanup vlan extension related token	2015-03-24 21:21:41 -04:00
nfsd
perf	perf probe: Fix segfault when glob matching function without debuginfo	2015-05-30 11:08:52 -03:00
power	More power management and ACPI updates for v4.1-rc1	2015-04-26 13:56:35 -07:00
scripts	tools lib traceevent: Add global QUIET_CC_FPIC build output	2013-12-19 16:18:10 -03:00
testing	linux-kselftest-4.1-rc4	2015-05-16 15:03:52 -07:00
thermal/tmon	tools/thermal: tmon: fixed the 'make install' command	2015-05-09 13:36:58 +08:00
time	tools: add script to test udelay	2014-07-23 10:16:38 -07:00
usb	tools: ffs-aio-example: use endpoint addresses from descriptors	2015-01-15 09:41:49 -06:00
virtio	tools/virtio: add virtio 1.0 in vringh_test	2014-12-15 23:49:22 +02:00
vm	tools: Fix tools/vm build	2015-05-12 18:11:06 -03:00
Makefile	tools build: Fix Makefile(s) to properly invoke tools build	2015-04-29 10:37:46 -03:00