devlink reload destroys resources and allocates resources again.
So, when devices and ports resources are being used, devlink reload
function should not be executed. In order to avoid this race, a new
lock is added and new_port() and del_port() call devlink_reload_disable()
and devlink_reload_enable().
Thread0 Thread1
{new/del}_port() {new/del}_port()
devlink_reload_disable()
devlink_reload_disable()
devlink_reload_enable()
//here
devlink_reload_enable()
Before Thread1's devlink_reload_enable(), the devlink is already allowed
to execute reload because Thread0 allows it. devlink reload disable/enable
variable type is bool. So the above case would exist.
So, disable/enable should be executed atomically.
In order to do that, a new lock is used.
Test commands:
modprobe netdevsim
echo 1 > /sys/bus/netdevsim/new_device
while :
do
echo 1 > /sys/devices/netdevsim1/new_port &
echo 1 > /sys/devices/netdevsim1/del_port &
devlink dev reload netdevsim/netdevsim1 &
done
Splat looks like:
[ 23.342145][ T932] DEBUG_LOCKS_WARN_ON(mutex_is_locked(lock))
[ 23.342159][ T932] WARNING: CPU: 0 PID: 932 at kernel/locking/mutex-debug.c:103 mutex_destroy+0xc7/0xf0
[ 23.344182][ T932] Modules linked in: netdevsim openvswitch nsh nf_conncount nf_nat nf_conntrack nf_defrag_ipv6 nf_dx
[ 23.346485][ T932] CPU: 0 PID: 932 Comm: devlink Not tainted 5.5.0+ #322
[ 23.347696][ T932] Hardware name: innotek GmbH VirtualBox/VirtualBox, BIOS VirtualBox 12/01/2006
[ 23.348893][ T932] RIP: 0010:mutex_destroy+0xc7/0xf0
[ 23.349505][ T932] Code: e0 07 83 c0 03 38 d0 7c 04 84 d2 75 2e 8b 05 00 ac b0 02 85 c0 75 8b 48 c7 c6 00 5e 07 96 40
[ 23.351887][ T932] RSP: 0018:ffff88806208f810 EFLAGS: 00010286
[ 23.353963][ T932] RAX: dffffc0000000008 RBX: ffff888067f6f2c0 RCX: ffffffff942c4bd4
[ 23.355222][ T932] RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffffffff96dac5b4
[ 23.356169][ T932] RBP: ffff888067f6f000 R08: fffffbfff2d235a5 R09: fffffbfff2d235a5
[ 23.357160][ T932] R10: 0000000000000001 R11: fffffbfff2d235a4 R12: ffff888067f6f208
[ 23.358288][ T932] R13: ffff88806208fa70 R14: ffff888067f6f000 R15: ffff888069ce3800
[ 23.359307][ T932] FS: 00007fe2a3876740(0000) GS:ffff88806c000000(0000) knlGS:0000000000000000
[ 23.360473][ T932] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 23.361319][ T932] CR2: 00005561357aa000 CR3: 000000005227a006 CR4: 00000000000606f0
[ 23.362323][ T932] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 23.363417][ T932] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[ 23.364414][ T932] Call Trace:
[ 23.364828][ T932] nsim_dev_reload_destroy+0x77/0xb0 [netdevsim]
[ 23.365655][ T932] nsim_dev_reload_down+0x84/0xb0 [netdevsim]
[ 23.366433][ T932] devlink_reload+0xb1/0x350
[ 23.367010][ T932] genl_rcv_msg+0x580/0xe90
[ ...]
[ 23.531729][ T1305] kernel BUG at lib/list_debug.c:53!
[ 23.532523][ T1305] invalid opcode: 0000 [#1] SMP DEBUG_PAGEALLOC KASAN PTI
[ 23.533467][ T1305] CPU: 2 PID: 1305 Comm: bash Tainted: G W 5.5.0+ #322
[ 23.534962][ T1305] Hardware name: innotek GmbH VirtualBox/VirtualBox, BIOS VirtualBox 12/01/2006
[ 23.536503][ T1305] RIP: 0010:__list_del_entry_valid+0xe6/0x150
[ 23.538346][ T1305] Code: 89 ea 48 c7 c7 00 73 1e 96 e8 df f7 4c ff 0f 0b 48 c7 c7 60 73 1e 96 e8 d1 f7 4c ff 0f 0b 44
[ 23.541068][ T1305] RSP: 0018:ffff888047c27b58 EFLAGS: 00010282
[ 23.542001][ T1305] RAX: 0000000000000054 RBX: ffff888067f6f318 RCX: 0000000000000000
[ 23.543051][ T1305] RDX: 0000000000000054 RSI: 0000000000000008 RDI: ffffed1008f84f61
[ 23.544072][ T1305] RBP: ffff88804aa0fca0 R08: ffffed100d940539 R09: ffffed100d940539
[ 23.545085][ T1305] R10: 0000000000000001 R11: ffffed100d940538 R12: ffff888047c27cb0
[ 23.546422][ T1305] R13: ffff88806208b840 R14: ffffffff981976c0 R15: ffff888067f6f2c0
[ 23.547406][ T1305] FS: 00007f76c0431740(0000) GS:ffff88806c800000(0000) knlGS:0000000000000000
[ 23.548527][ T1305] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 23.549389][ T1305] CR2: 00007f5048f1a2f8 CR3: 000000004b310006 CR4: 00000000000606e0
[ 23.550636][ T1305] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 23.551578][ T1305] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[ 23.552597][ T1305] Call Trace:
[ 23.553004][ T1305] mutex_remove_waiter+0x101/0x520
[ 23.553646][ T1305] __mutex_lock+0xac7/0x14b0
[ 23.554218][ T1305] ? nsim_dev_port_del+0x4e/0x140 [netdevsim]
[ 23.554908][ T1305] ? mutex_lock_io_nested+0x1380/0x1380
[ 23.555570][ T1305] ? _parse_integer+0xf0/0xf0
[ 23.556043][ T1305] ? kstrtouint+0x86/0x110
[ 23.556504][ T1305] ? nsim_dev_port_del+0x4e/0x140 [netdevsim]
[ 23.557133][ T1305] nsim_dev_port_del+0x4e/0x140 [netdevsim]
[ 23.558024][ T1305] del_port_store+0xcc/0xf0 [netdevsim]
[ ... ]
Fixes: 75ba029f3c
("netdevsim: implement proper devlink reload")
Signed-off-by: Taehee Yoo <ap420073@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
399 lines
9.3 KiB
C
399 lines
9.3 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/* Copyright (C) 2017 Netronome Systems, Inc.
|
|
* Copyright (C) 2019 Mellanox Technologies. All rights reserved
|
|
*/
|
|
|
|
#include <linux/device.h>
|
|
#include <linux/idr.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/list.h>
|
|
#include <linux/mutex.h>
|
|
#include <linux/rtnetlink.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/sysfs.h>
|
|
|
|
#include "netdevsim.h"
|
|
|
|
static DEFINE_IDA(nsim_bus_dev_ids);
|
|
static LIST_HEAD(nsim_bus_dev_list);
|
|
static DEFINE_MUTEX(nsim_bus_dev_list_lock);
|
|
static bool nsim_bus_enable;
|
|
|
|
static struct nsim_bus_dev *to_nsim_bus_dev(struct device *dev)
|
|
{
|
|
return container_of(dev, struct nsim_bus_dev, dev);
|
|
}
|
|
|
|
static int nsim_bus_dev_vfs_enable(struct nsim_bus_dev *nsim_bus_dev,
|
|
unsigned int num_vfs)
|
|
{
|
|
nsim_bus_dev->vfconfigs = kcalloc(num_vfs,
|
|
sizeof(struct nsim_vf_config),
|
|
GFP_KERNEL);
|
|
if (!nsim_bus_dev->vfconfigs)
|
|
return -ENOMEM;
|
|
nsim_bus_dev->num_vfs = num_vfs;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void nsim_bus_dev_vfs_disable(struct nsim_bus_dev *nsim_bus_dev)
|
|
{
|
|
kfree(nsim_bus_dev->vfconfigs);
|
|
nsim_bus_dev->vfconfigs = NULL;
|
|
nsim_bus_dev->num_vfs = 0;
|
|
}
|
|
|
|
static ssize_t
|
|
nsim_bus_dev_numvfs_store(struct device *dev, struct device_attribute *attr,
|
|
const char *buf, size_t count)
|
|
{
|
|
struct nsim_bus_dev *nsim_bus_dev = to_nsim_bus_dev(dev);
|
|
unsigned int num_vfs;
|
|
int ret;
|
|
|
|
ret = kstrtouint(buf, 0, &num_vfs);
|
|
if (ret)
|
|
return ret;
|
|
|
|
rtnl_lock();
|
|
if (nsim_bus_dev->num_vfs == num_vfs)
|
|
goto exit_good;
|
|
if (nsim_bus_dev->num_vfs && num_vfs) {
|
|
ret = -EBUSY;
|
|
goto exit_unlock;
|
|
}
|
|
|
|
if (num_vfs) {
|
|
ret = nsim_bus_dev_vfs_enable(nsim_bus_dev, num_vfs);
|
|
if (ret)
|
|
goto exit_unlock;
|
|
} else {
|
|
nsim_bus_dev_vfs_disable(nsim_bus_dev);
|
|
}
|
|
exit_good:
|
|
ret = count;
|
|
exit_unlock:
|
|
rtnl_unlock();
|
|
|
|
return ret;
|
|
}
|
|
|
|
static ssize_t
|
|
nsim_bus_dev_numvfs_show(struct device *dev,
|
|
struct device_attribute *attr, char *buf)
|
|
{
|
|
struct nsim_bus_dev *nsim_bus_dev = to_nsim_bus_dev(dev);
|
|
|
|
return sprintf(buf, "%u\n", nsim_bus_dev->num_vfs);
|
|
}
|
|
|
|
static struct device_attribute nsim_bus_dev_numvfs_attr =
|
|
__ATTR(sriov_numvfs, 0664, nsim_bus_dev_numvfs_show,
|
|
nsim_bus_dev_numvfs_store);
|
|
|
|
static ssize_t
|
|
new_port_store(struct device *dev, struct device_attribute *attr,
|
|
const char *buf, size_t count)
|
|
{
|
|
struct nsim_bus_dev *nsim_bus_dev = to_nsim_bus_dev(dev);
|
|
struct nsim_dev *nsim_dev = dev_get_drvdata(dev);
|
|
struct devlink *devlink;
|
|
unsigned int port_index;
|
|
int ret;
|
|
|
|
/* Prevent to use nsim_bus_dev before initialization. */
|
|
if (!smp_load_acquire(&nsim_bus_dev->init))
|
|
return -EBUSY;
|
|
ret = kstrtouint(buf, 0, &port_index);
|
|
if (ret)
|
|
return ret;
|
|
|
|
devlink = priv_to_devlink(nsim_dev);
|
|
|
|
mutex_lock(&nsim_bus_dev->nsim_bus_reload_lock);
|
|
devlink_reload_disable(devlink);
|
|
ret = nsim_dev_port_add(nsim_bus_dev, port_index);
|
|
devlink_reload_enable(devlink);
|
|
mutex_unlock(&nsim_bus_dev->nsim_bus_reload_lock);
|
|
return ret ? ret : count;
|
|
}
|
|
|
|
static struct device_attribute nsim_bus_dev_new_port_attr = __ATTR_WO(new_port);
|
|
|
|
static ssize_t
|
|
del_port_store(struct device *dev, struct device_attribute *attr,
|
|
const char *buf, size_t count)
|
|
{
|
|
struct nsim_bus_dev *nsim_bus_dev = to_nsim_bus_dev(dev);
|
|
struct nsim_dev *nsim_dev = dev_get_drvdata(dev);
|
|
struct devlink *devlink;
|
|
unsigned int port_index;
|
|
int ret;
|
|
|
|
/* Prevent to use nsim_bus_dev before initialization. */
|
|
if (!smp_load_acquire(&nsim_bus_dev->init))
|
|
return -EBUSY;
|
|
ret = kstrtouint(buf, 0, &port_index);
|
|
if (ret)
|
|
return ret;
|
|
|
|
devlink = priv_to_devlink(nsim_dev);
|
|
|
|
mutex_lock(&nsim_bus_dev->nsim_bus_reload_lock);
|
|
devlink_reload_disable(devlink);
|
|
ret = nsim_dev_port_del(nsim_bus_dev, port_index);
|
|
devlink_reload_enable(devlink);
|
|
mutex_unlock(&nsim_bus_dev->nsim_bus_reload_lock);
|
|
return ret ? ret : count;
|
|
}
|
|
|
|
static struct device_attribute nsim_bus_dev_del_port_attr = __ATTR_WO(del_port);
|
|
|
|
static struct attribute *nsim_bus_dev_attrs[] = {
|
|
&nsim_bus_dev_numvfs_attr.attr,
|
|
&nsim_bus_dev_new_port_attr.attr,
|
|
&nsim_bus_dev_del_port_attr.attr,
|
|
NULL,
|
|
};
|
|
|
|
static const struct attribute_group nsim_bus_dev_attr_group = {
|
|
.attrs = nsim_bus_dev_attrs,
|
|
};
|
|
|
|
static const struct attribute_group *nsim_bus_dev_attr_groups[] = {
|
|
&nsim_bus_dev_attr_group,
|
|
NULL,
|
|
};
|
|
|
|
static void nsim_bus_dev_release(struct device *dev)
|
|
{
|
|
struct nsim_bus_dev *nsim_bus_dev = to_nsim_bus_dev(dev);
|
|
|
|
nsim_bus_dev_vfs_disable(nsim_bus_dev);
|
|
}
|
|
|
|
static struct device_type nsim_bus_dev_type = {
|
|
.groups = nsim_bus_dev_attr_groups,
|
|
.release = nsim_bus_dev_release,
|
|
};
|
|
|
|
static struct nsim_bus_dev *
|
|
nsim_bus_dev_new(unsigned int id, unsigned int port_count);
|
|
|
|
static ssize_t
|
|
new_device_store(struct bus_type *bus, const char *buf, size_t count)
|
|
{
|
|
struct nsim_bus_dev *nsim_bus_dev;
|
|
unsigned int port_count;
|
|
unsigned int id;
|
|
int err;
|
|
|
|
err = sscanf(buf, "%u %u", &id, &port_count);
|
|
switch (err) {
|
|
case 1:
|
|
port_count = 1;
|
|
/* fall through */
|
|
case 2:
|
|
if (id > INT_MAX) {
|
|
pr_err("Value of \"id\" is too big.\n");
|
|
return -EINVAL;
|
|
}
|
|
break;
|
|
default:
|
|
pr_err("Format for adding new device is \"id port_count\" (uint uint).\n");
|
|
return -EINVAL;
|
|
}
|
|
|
|
mutex_lock(&nsim_bus_dev_list_lock);
|
|
/* Prevent to use resource before initialization. */
|
|
if (!smp_load_acquire(&nsim_bus_enable)) {
|
|
err = -EBUSY;
|
|
goto err;
|
|
}
|
|
|
|
nsim_bus_dev = nsim_bus_dev_new(id, port_count);
|
|
if (IS_ERR(nsim_bus_dev)) {
|
|
err = PTR_ERR(nsim_bus_dev);
|
|
goto err;
|
|
}
|
|
|
|
/* Allow using nsim_bus_dev */
|
|
smp_store_release(&nsim_bus_dev->init, true);
|
|
|
|
list_add_tail(&nsim_bus_dev->list, &nsim_bus_dev_list);
|
|
mutex_unlock(&nsim_bus_dev_list_lock);
|
|
|
|
return count;
|
|
err:
|
|
mutex_unlock(&nsim_bus_dev_list_lock);
|
|
return err;
|
|
}
|
|
static BUS_ATTR_WO(new_device);
|
|
|
|
static void nsim_bus_dev_del(struct nsim_bus_dev *nsim_bus_dev);
|
|
|
|
static ssize_t
|
|
del_device_store(struct bus_type *bus, const char *buf, size_t count)
|
|
{
|
|
struct nsim_bus_dev *nsim_bus_dev, *tmp;
|
|
unsigned int id;
|
|
int err;
|
|
|
|
err = sscanf(buf, "%u", &id);
|
|
switch (err) {
|
|
case 1:
|
|
if (id > INT_MAX) {
|
|
pr_err("Value of \"id\" is too big.\n");
|
|
return -EINVAL;
|
|
}
|
|
break;
|
|
default:
|
|
pr_err("Format for deleting device is \"id\" (uint).\n");
|
|
return -EINVAL;
|
|
}
|
|
|
|
err = -ENOENT;
|
|
mutex_lock(&nsim_bus_dev_list_lock);
|
|
/* Prevent to use resource before initialization. */
|
|
if (!smp_load_acquire(&nsim_bus_enable)) {
|
|
mutex_unlock(&nsim_bus_dev_list_lock);
|
|
return -EBUSY;
|
|
}
|
|
list_for_each_entry_safe(nsim_bus_dev, tmp, &nsim_bus_dev_list, list) {
|
|
if (nsim_bus_dev->dev.id != id)
|
|
continue;
|
|
list_del(&nsim_bus_dev->list);
|
|
nsim_bus_dev_del(nsim_bus_dev);
|
|
err = 0;
|
|
break;
|
|
}
|
|
mutex_unlock(&nsim_bus_dev_list_lock);
|
|
return !err ? count : err;
|
|
}
|
|
static BUS_ATTR_WO(del_device);
|
|
|
|
static struct attribute *nsim_bus_attrs[] = {
|
|
&bus_attr_new_device.attr,
|
|
&bus_attr_del_device.attr,
|
|
NULL
|
|
};
|
|
ATTRIBUTE_GROUPS(nsim_bus);
|
|
|
|
static int nsim_bus_probe(struct device *dev)
|
|
{
|
|
struct nsim_bus_dev *nsim_bus_dev = to_nsim_bus_dev(dev);
|
|
|
|
return nsim_dev_probe(nsim_bus_dev);
|
|
}
|
|
|
|
static int nsim_bus_remove(struct device *dev)
|
|
{
|
|
struct nsim_bus_dev *nsim_bus_dev = to_nsim_bus_dev(dev);
|
|
|
|
nsim_dev_remove(nsim_bus_dev);
|
|
return 0;
|
|
}
|
|
|
|
static int nsim_num_vf(struct device *dev)
|
|
{
|
|
struct nsim_bus_dev *nsim_bus_dev = to_nsim_bus_dev(dev);
|
|
|
|
return nsim_bus_dev->num_vfs;
|
|
}
|
|
|
|
static struct bus_type nsim_bus = {
|
|
.name = DRV_NAME,
|
|
.dev_name = DRV_NAME,
|
|
.bus_groups = nsim_bus_groups,
|
|
.probe = nsim_bus_probe,
|
|
.remove = nsim_bus_remove,
|
|
.num_vf = nsim_num_vf,
|
|
};
|
|
|
|
static struct nsim_bus_dev *
|
|
nsim_bus_dev_new(unsigned int id, unsigned int port_count)
|
|
{
|
|
struct nsim_bus_dev *nsim_bus_dev;
|
|
int err;
|
|
|
|
nsim_bus_dev = kzalloc(sizeof(*nsim_bus_dev), GFP_KERNEL);
|
|
if (!nsim_bus_dev)
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
err = ida_alloc_range(&nsim_bus_dev_ids, id, id, GFP_KERNEL);
|
|
if (err < 0)
|
|
goto err_nsim_bus_dev_free;
|
|
nsim_bus_dev->dev.id = err;
|
|
nsim_bus_dev->dev.bus = &nsim_bus;
|
|
nsim_bus_dev->dev.type = &nsim_bus_dev_type;
|
|
nsim_bus_dev->port_count = port_count;
|
|
nsim_bus_dev->initial_net = current->nsproxy->net_ns;
|
|
mutex_init(&nsim_bus_dev->nsim_bus_reload_lock);
|
|
/* Disallow using nsim_bus_dev */
|
|
smp_store_release(&nsim_bus_dev->init, false);
|
|
|
|
err = device_register(&nsim_bus_dev->dev);
|
|
if (err)
|
|
goto err_nsim_bus_dev_id_free;
|
|
return nsim_bus_dev;
|
|
|
|
err_nsim_bus_dev_id_free:
|
|
ida_free(&nsim_bus_dev_ids, nsim_bus_dev->dev.id);
|
|
err_nsim_bus_dev_free:
|
|
kfree(nsim_bus_dev);
|
|
return ERR_PTR(err);
|
|
}
|
|
|
|
static void nsim_bus_dev_del(struct nsim_bus_dev *nsim_bus_dev)
|
|
{
|
|
/* Disallow using nsim_bus_dev */
|
|
smp_store_release(&nsim_bus_dev->init, false);
|
|
device_unregister(&nsim_bus_dev->dev);
|
|
ida_free(&nsim_bus_dev_ids, nsim_bus_dev->dev.id);
|
|
kfree(nsim_bus_dev);
|
|
}
|
|
|
|
static struct device_driver nsim_driver = {
|
|
.name = DRV_NAME,
|
|
.bus = &nsim_bus,
|
|
.owner = THIS_MODULE,
|
|
};
|
|
|
|
int nsim_bus_init(void)
|
|
{
|
|
int err;
|
|
|
|
err = bus_register(&nsim_bus);
|
|
if (err)
|
|
return err;
|
|
err = driver_register(&nsim_driver);
|
|
if (err)
|
|
goto err_bus_unregister;
|
|
/* Allow using resources */
|
|
smp_store_release(&nsim_bus_enable, true);
|
|
return 0;
|
|
|
|
err_bus_unregister:
|
|
bus_unregister(&nsim_bus);
|
|
return err;
|
|
}
|
|
|
|
void nsim_bus_exit(void)
|
|
{
|
|
struct nsim_bus_dev *nsim_bus_dev, *tmp;
|
|
|
|
/* Disallow using resources */
|
|
smp_store_release(&nsim_bus_enable, false);
|
|
|
|
mutex_lock(&nsim_bus_dev_list_lock);
|
|
list_for_each_entry_safe(nsim_bus_dev, tmp, &nsim_bus_dev_list, list) {
|
|
list_del(&nsim_bus_dev->list);
|
|
nsim_bus_dev_del(nsim_bus_dev);
|
|
}
|
|
mutex_unlock(&nsim_bus_dev_list_lock);
|
|
|
|
driver_unregister(&nsim_driver);
|
|
bus_unregister(&nsim_bus);
|
|
}
|