forked from Minki/linux
f6f8285132
The buf_lock cannot be held while populating the inodes, so make the backend pass forward an allocated and filled buffer instead. This solves the following backtrace. The effect is that "buf" is only ever used to notify the backends that something was written to it, and shouldn't be used in the read path. To replace the buf_lock during the read path, isolate the open/read/close loop with a separate mutex to maintain serialized access to the backend. Note that is is up to the pstore backend to cope if the (*write)() path is called in the middle of the read path. [ 59.691019] BUG: sleeping function called from invalid context at .../mm/slub.c:847 [ 59.691019] in_atomic(): 0, irqs_disabled(): 1, pid: 1819, name: mount [ 59.691019] Pid: 1819, comm: mount Not tainted 3.0.8 #1 [ 59.691019] Call Trace: [ 59.691019] [<810252d5>] __might_sleep+0xc3/0xca [ 59.691019] [<810a26e6>] kmem_cache_alloc+0x32/0xf3 [ 59.691019] [<810b53ac>] ? __d_lookup_rcu+0x6f/0xf4 [ 59.691019] [<810b68b1>] alloc_inode+0x2a/0x64 [ 59.691019] [<810b6903>] new_inode+0x18/0x43 [ 59.691019] [<81142447>] pstore_get_inode.isra.1+0x11/0x98 [ 59.691019] [<81142623>] pstore_mkfile+0xae/0x26f [ 59.691019] [<810a2a66>] ? kmem_cache_free+0x19/0xb1 [ 59.691019] [<8116c821>] ? ida_get_new_above+0x140/0x158 [ 59.691019] [<811708ea>] ? __init_rwsem+0x1e/0x2c [ 59.691019] [<810b67e8>] ? inode_init_always+0x111/0x1b0 [ 59.691019] [<8102127e>] ? should_resched+0xd/0x27 [ 59.691019] [<8137977f>] ? _cond_resched+0xd/0x21 [ 59.691019] [<81142abf>] pstore_get_records+0x52/0xa7 [ 59.691019] [<8114254b>] pstore_fill_super+0x7d/0x91 [ 59.691019] [<810a7ff5>] mount_single+0x46/0x82 [ 59.691019] [<8114231a>] pstore_mount+0x15/0x17 [ 59.691019] [<811424ce>] ? pstore_get_inode.isra.1+0x98/0x98 [ 59.691019] [<810a8199>] mount_fs+0x5a/0x12d [ 59.691019] [<810b9174>] ? alloc_vfsmnt+0xa4/0x14a [ 59.691019] [<810b9474>] vfs_kern_mount+0x4f/0x7d [ 59.691019] [<810b9d7e>] do_kern_mount+0x34/0xb2 [ 59.691019] [<810bb15f>] do_mount+0x5fc/0x64a [ 59.691019] [<810912fb>] ? strndup_user+0x2e/0x3f [ 59.691019] [<810bb3cb>] sys_mount+0x66/0x99 [ 59.691019] [<8137b537>] sysenter_do_call+0x12/0x26 Signed-off-by: Kees Cook <keescook@chromium.org> Signed-off-by: Tony Luck <tony.luck@intel.com>
276 lines
6.6 KiB
C
276 lines
6.6 KiB
C
/*
|
|
* Persistent Storage - platform driver interface parts.
|
|
*
|
|
* Copyright (C) 2010 Intel Corporation <tony.luck@intel.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
* published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
*/
|
|
|
|
#include <linux/atomic.h>
|
|
#include <linux/types.h>
|
|
#include <linux/errno.h>
|
|
#include <linux/init.h>
|
|
#include <linux/kmsg_dump.h>
|
|
#include <linux/module.h>
|
|
#include <linux/pstore.h>
|
|
#include <linux/string.h>
|
|
#include <linux/timer.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/uaccess.h>
|
|
#include <linux/hardirq.h>
|
|
#include <linux/workqueue.h>
|
|
|
|
#include "internal.h"
|
|
|
|
/*
|
|
* We defer making "oops" entries appear in pstore - see
|
|
* whether the system is actually still running well enough
|
|
* to let someone see the entry
|
|
*/
|
|
#define PSTORE_INTERVAL (60 * HZ)
|
|
|
|
static int pstore_new_entry;
|
|
|
|
static void pstore_timefunc(unsigned long);
|
|
static DEFINE_TIMER(pstore_timer, pstore_timefunc, 0, 0);
|
|
|
|
static void pstore_dowork(struct work_struct *);
|
|
static DECLARE_WORK(pstore_work, pstore_dowork);
|
|
|
|
/*
|
|
* pstore_lock just protects "psinfo" during
|
|
* calls to pstore_register()
|
|
*/
|
|
static DEFINE_SPINLOCK(pstore_lock);
|
|
static struct pstore_info *psinfo;
|
|
|
|
static char *backend;
|
|
|
|
/* How much of the console log to snapshot */
|
|
static unsigned long kmsg_bytes = 10240;
|
|
|
|
void pstore_set_kmsg_bytes(int bytes)
|
|
{
|
|
kmsg_bytes = bytes;
|
|
}
|
|
|
|
/* Tag each group of saved records with a sequence number */
|
|
static int oopscount;
|
|
|
|
static char *reason_str[] = {
|
|
"Oops", "Panic", "Kexec", "Restart", "Halt", "Poweroff", "Emergency"
|
|
};
|
|
|
|
/*
|
|
* callback from kmsg_dump. (s2,l2) has the most recently
|
|
* written bytes, older bytes are in (s1,l1). Save as much
|
|
* as we can from the end of the buffer.
|
|
*/
|
|
static void pstore_dump(struct kmsg_dumper *dumper,
|
|
enum kmsg_dump_reason reason,
|
|
const char *s1, unsigned long l1,
|
|
const char *s2, unsigned long l2)
|
|
{
|
|
unsigned long s1_start, s2_start;
|
|
unsigned long l1_cpy, l2_cpy;
|
|
unsigned long size, total = 0;
|
|
char *dst, *why;
|
|
u64 id;
|
|
int hsize, ret;
|
|
unsigned int part = 1;
|
|
unsigned long flags = 0;
|
|
int is_locked = 0;
|
|
|
|
if (reason < ARRAY_SIZE(reason_str))
|
|
why = reason_str[reason];
|
|
else
|
|
why = "Unknown";
|
|
|
|
if (in_nmi()) {
|
|
is_locked = spin_trylock(&psinfo->buf_lock);
|
|
if (!is_locked)
|
|
pr_err("pstore dump routine blocked in NMI, may corrupt error record\n");
|
|
} else
|
|
spin_lock_irqsave(&psinfo->buf_lock, flags);
|
|
oopscount++;
|
|
while (total < kmsg_bytes) {
|
|
dst = psinfo->buf;
|
|
hsize = sprintf(dst, "%s#%d Part%d\n", why, oopscount, part);
|
|
size = psinfo->bufsize - hsize;
|
|
dst += hsize;
|
|
|
|
l2_cpy = min(l2, size);
|
|
l1_cpy = min(l1, size - l2_cpy);
|
|
|
|
if (l1_cpy + l2_cpy == 0)
|
|
break;
|
|
|
|
s2_start = l2 - l2_cpy;
|
|
s1_start = l1 - l1_cpy;
|
|
|
|
memcpy(dst, s1 + s1_start, l1_cpy);
|
|
memcpy(dst + l1_cpy, s2 + s2_start, l2_cpy);
|
|
|
|
ret = psinfo->write(PSTORE_TYPE_DMESG, &id, part,
|
|
hsize + l1_cpy + l2_cpy, psinfo);
|
|
if (ret == 0 && reason == KMSG_DUMP_OOPS && pstore_is_mounted())
|
|
pstore_new_entry = 1;
|
|
l1 -= l1_cpy;
|
|
l2 -= l2_cpy;
|
|
total += l1_cpy + l2_cpy;
|
|
part++;
|
|
}
|
|
if (in_nmi()) {
|
|
if (is_locked)
|
|
spin_unlock(&psinfo->buf_lock);
|
|
} else
|
|
spin_unlock_irqrestore(&psinfo->buf_lock, flags);
|
|
}
|
|
|
|
static struct kmsg_dumper pstore_dumper = {
|
|
.dump = pstore_dump,
|
|
};
|
|
|
|
/*
|
|
* platform specific persistent storage driver registers with
|
|
* us here. If pstore is already mounted, call the platform
|
|
* read function right away to populate the file system. If not
|
|
* then the pstore mount code will call us later to fill out
|
|
* the file system.
|
|
*
|
|
* Register with kmsg_dump to save last part of console log on panic.
|
|
*/
|
|
int pstore_register(struct pstore_info *psi)
|
|
{
|
|
struct module *owner = psi->owner;
|
|
|
|
spin_lock(&pstore_lock);
|
|
if (psinfo) {
|
|
spin_unlock(&pstore_lock);
|
|
return -EBUSY;
|
|
}
|
|
|
|
if (backend && strcmp(backend, psi->name)) {
|
|
spin_unlock(&pstore_lock);
|
|
return -EINVAL;
|
|
}
|
|
|
|
psinfo = psi;
|
|
mutex_init(&psinfo->read_mutex);
|
|
spin_unlock(&pstore_lock);
|
|
|
|
if (owner && !try_module_get(owner)) {
|
|
psinfo = NULL;
|
|
return -EINVAL;
|
|
}
|
|
|
|
if (pstore_is_mounted())
|
|
pstore_get_records(0);
|
|
|
|
kmsg_dump_register(&pstore_dumper);
|
|
|
|
pstore_timer.expires = jiffies + PSTORE_INTERVAL;
|
|
add_timer(&pstore_timer);
|
|
|
|
return 0;
|
|
}
|
|
EXPORT_SYMBOL_GPL(pstore_register);
|
|
|
|
/*
|
|
* Read all the records from the persistent store. Create
|
|
* files in our filesystem. Don't warn about -EEXIST errors
|
|
* when we are re-scanning the backing store looking to add new
|
|
* error records.
|
|
*/
|
|
void pstore_get_records(int quiet)
|
|
{
|
|
struct pstore_info *psi = psinfo;
|
|
char *buf = NULL;
|
|
ssize_t size;
|
|
u64 id;
|
|
enum pstore_type_id type;
|
|
struct timespec time;
|
|
int failed = 0, rc;
|
|
|
|
if (!psi)
|
|
return;
|
|
|
|
mutex_lock(&psi->read_mutex);
|
|
rc = psi->open(psi);
|
|
if (rc)
|
|
goto out;
|
|
|
|
while ((size = psi->read(&id, &type, &time, &buf, psi)) > 0) {
|
|
rc = pstore_mkfile(type, psi->name, id, buf, (size_t)size,
|
|
time, psi);
|
|
kfree(buf);
|
|
buf = NULL;
|
|
if (rc && (rc != -EEXIST || !quiet))
|
|
failed++;
|
|
}
|
|
psi->close(psi);
|
|
out:
|
|
mutex_unlock(&psi->read_mutex);
|
|
|
|
if (failed)
|
|
printk(KERN_WARNING "pstore: failed to load %d record(s) from '%s'\n",
|
|
failed, psi->name);
|
|
}
|
|
|
|
static void pstore_dowork(struct work_struct *work)
|
|
{
|
|
pstore_get_records(1);
|
|
}
|
|
|
|
static void pstore_timefunc(unsigned long dummy)
|
|
{
|
|
if (pstore_new_entry) {
|
|
pstore_new_entry = 0;
|
|
schedule_work(&pstore_work);
|
|
}
|
|
|
|
mod_timer(&pstore_timer, jiffies + PSTORE_INTERVAL);
|
|
}
|
|
|
|
/*
|
|
* Call platform driver to write a record to the
|
|
* persistent store.
|
|
*/
|
|
int pstore_write(enum pstore_type_id type, char *buf, size_t size)
|
|
{
|
|
u64 id;
|
|
int ret;
|
|
unsigned long flags;
|
|
|
|
if (!psinfo)
|
|
return -ENODEV;
|
|
|
|
if (size > psinfo->bufsize)
|
|
return -EFBIG;
|
|
|
|
spin_lock_irqsave(&psinfo->buf_lock, flags);
|
|
memcpy(psinfo->buf, buf, size);
|
|
ret = psinfo->write(type, &id, 0, size, psinfo);
|
|
if (ret == 0 && pstore_is_mounted())
|
|
pstore_mkfile(PSTORE_TYPE_DMESG, psinfo->name, id, psinfo->buf,
|
|
size, CURRENT_TIME, psinfo);
|
|
spin_unlock_irqrestore(&psinfo->buf_lock, flags);
|
|
|
|
return 0;
|
|
}
|
|
EXPORT_SYMBOL_GPL(pstore_write);
|
|
|
|
module_param(backend, charp, 0444);
|
|
MODULE_PARM_DESC(backend, "Pstore backend to use");
|