leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
52eb74339a
linux/arch/x86/kernel/cpu/resctrl
History
Reinette Chatre 52eb74339a x86/resctrl: Fix rdt_find_domain() return value and checks 
rdt_find_domain() returns an ERR_PTR() that is generated from a provided
domain id when the value is negative.

Care needs to be taken when creating an ERR_PTR() from this value
because a subsequent check using IS_ERR() expects the error to
be within the MAX_ERRNO range. Using an invalid domain id as an
ERR_PTR() does work at this time since this is currently always -1.
Using this undocumented assumption is fragile since future users of
rdt_find_domain() may not be aware of thus assumption.

Two related issues are addressed:

- Ensure that rdt_find_domain() always returns a valid error value by
forcing the error to be -ENODEV when a negative domain id is provided.

- In a few instances the return value of rdt_find_domain() is just
checked for NULL - fix these to include a check of ERR_PTR.

Fixes: d89b737901 ("x86/intel_rdt/cqm: Add mon_data")
Fixes: 521348b011 ("x86/intel_rdt: Introduce utility to obtain CDP peer")
Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Tony Luck <tony.luck@intel.com>
Cc: fenghua.yu@intel.com
Cc: gavin.hindman@intel.com
Cc: jithu.joseph@intel.com
Cc: x86-ml <x86@kernel.org>
Link: https://lkml.kernel.org/r/b88cd4ff6a75995bf8db9b0ea546908fe50f69f3.1544479852.git.reinette.chatre@intel.com
2018-12-11 22:09:28 +01:00
..
core.c x86/resctrl: Fix rdt_find_domain() return value and checks 2018-12-11 22:09:28 +01:00
ctrlmondata.c x86/resctrl: Fix rdt_find_domain() return value and checks 2018-12-11 22:09:28 +01:00
internal.h x86/resctrl: Introduce AMD QOS feature 2018-11-22 20:16:20 +01:00
Makefile x86/resctrl: Rename the config option INTEL_RDT to RESCTRL 2018-11-22 20:16:19 +01:00
monitor.c x86/resctrl: Move all the macros to resctrl/internal.h 2018-11-22 20:16:19 +01:00
pseudo_lock_event.h
pseudo_lock.c x86/resctrl: Fixup the user-visible strings 2018-11-22 20:16:20 +01:00
rdtgroup.c x86/resctrl: Fix rdt_find_domain() return value and checks 2018-12-11 22:09:28 +01:00