3dc2154166
Clang warns:
In file included from drivers/net/ethernet/intel/iavf/iavf_main.c:4:
In file included from drivers/net/ethernet/intel/iavf/iavf.h:37:
In file included from drivers/net/ethernet/intel/iavf/iavf_type.h:8:
drivers/net/ethernet/intel/iavf/iavf_osdep.h:49:18: warning: 'format' attribute argument not supported: gnu_printf [-Wignored-attributes]
__attribute__ ((format(gnu_printf, 3, 4)));
^
1 warning generated.
We can convert from gnu_printf to printf without any side effects for
two reasons:
1. All iavf_debug instances use standard printf formats, as pointed out
by Miguel Ojeda at the below link, meaning gnu_printf is not strictly
required.
2. However, GCC has aliased printf to gnu_printf on Linux since at least
2010 based on git history.
From gcc/c-family/c-format.c:
/* Attributes such as "printf" are equivalent to those such as
"gnu_printf" unless this is overridden by a target. */
static const target_ovr_attr gnu_target_overrides_format_attributes[] =
{
{ "gnu_printf", "printf" },
{ "gnu_scanf", "scanf" },
{ "gnu_strftime", "strftime" },
{ "gnu_strfmon", "strfmon" },
{ NULL, NULL }
};
The mentioned override only happens on Windows (mingw32). Changing from
gnu_printf to printf is a no-op for GCC and stops Clang from warning.
Link: https://github.com/ClangBuiltLinux/linux/issues/111
Suggested-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
53 lines
1.4 KiB
C
53 lines
1.4 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/* Copyright(c) 2013 - 2018 Intel Corporation. */
|
|
|
|
#ifndef _IAVF_OSDEP_H_
|
|
#define _IAVF_OSDEP_H_
|
|
|
|
#include <linux/types.h>
|
|
#include <linux/if_ether.h>
|
|
#include <linux/if_vlan.h>
|
|
#include <linux/tcp.h>
|
|
#include <linux/pci.h>
|
|
|
|
/* get readq/writeq support for 32 bit kernels, use the low-first version */
|
|
#include <linux/io-64-nonatomic-lo-hi.h>
|
|
|
|
/* File to be the magic between shared code and
|
|
* actual OS primitives
|
|
*/
|
|
|
|
#define hw_dbg(hw, S, A...) do {} while (0)
|
|
|
|
#define wr32(a, reg, value) writel((value), ((a)->hw_addr + (reg)))
|
|
#define rd32(a, reg) readl((a)->hw_addr + (reg))
|
|
|
|
#define wr64(a, reg, value) writeq((value), ((a)->hw_addr + (reg)))
|
|
#define rd64(a, reg) readq((a)->hw_addr + (reg))
|
|
#define iavf_flush(a) readl((a)->hw_addr + IAVF_VFGEN_RSTAT)
|
|
|
|
/* memory allocation tracking */
|
|
struct iavf_dma_mem {
|
|
void *va;
|
|
dma_addr_t pa;
|
|
u32 size;
|
|
};
|
|
|
|
#define iavf_allocate_dma_mem(h, m, unused, s, a) \
|
|
iavf_allocate_dma_mem_d(h, m, s, a)
|
|
#define iavf_free_dma_mem(h, m) iavf_free_dma_mem_d(h, m)
|
|
|
|
struct iavf_virt_mem {
|
|
void *va;
|
|
u32 size;
|
|
};
|
|
#define iavf_allocate_virt_mem(h, m, s) iavf_allocate_virt_mem_d(h, m, s)
|
|
#define iavf_free_virt_mem(h, m) iavf_free_virt_mem_d(h, m)
|
|
|
|
#define iavf_debug(h, m, s, ...) iavf_debug_d(h, m, s, ##__VA_ARGS__)
|
|
extern void iavf_debug_d(void *hw, u32 mask, char *fmt_str, ...)
|
|
__printf(3, 4);
|
|
|
|
typedef enum iavf_status_code iavf_status;
|
|
#endif /* _IAVF_OSDEP_H_ */
|