leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity
3ca7aea041
linux/net/dccp
History
Gerrit Renker 3ca7aea041 dccp tfrc: Return type of update_i_mean is void 
This changes the return type of tfrc_lh_update_i_mean() to void, since that 
function returns always `false'. This is due to 

 	len = dccp_delta_seqno(cur->li_seqno, DCCP_SKB_CB(skb)->dccpd_seq) + 1;
 
 	if (len - (s64)cur->li_length <= 0)	/* duplicate or reordered */
		return 0;

which means that update_i_mean can only increase the length of the open loss
interval I_0, and hence the value of I_tot0 (RFC 3448, 5.4). Consequently the
test `i_mean < old_i_mean' at the end of the function always evaluates to false.

There is no known way by which a loss interval can suddenly become shorter,
therefore the return type of the function is changed to void. (That is, under
the given circumstances step (3) in RFC 3448, 6.1 will not occur.)

Further changes:
----------------
 * the function is now called from tfrc_rx_handle_loss, which is equivalent
   to the previous way of calling from rx_packet_recv (it was called whenever
   there was no new or pending loss, now  it is also updated when there is
   a pending loss - this increases the accuracy a bit);
 * added a FIXME to possibly consider NDP counting as per RFC 4342 (this is
   not implemented yet).

Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
2008-09-04 07:45:41 +02:00
..
ccids dccp tfrc: Return type of update_i_mean is void 2008-09-04 07:45:41 +02:00
ackvec.c dccp ccid-2: Separate option parsing from CCID processing 2008-09-04 07:45:37 +02:00
ackvec.h dccp ccid-2: Separate option parsing from CCID processing 2008-09-04 07:45:37 +02:00
ccid.c dccp: Auto-load (when supported) CCID plugins for negotiation 2008-09-04 07:45:31 +02:00
ccid.h dccp: Return-value convention of hc_tx_send_packet() 2008-09-04 07:45:38 +02:00
dccp.h dccp ccid-3: Runtime verification of timer resolution 2008-09-04 07:45:40 +02:00
diag.c dccp ccid-2: Phase out the use of boolean Ack Vector sysctl 2008-09-04 07:45:31 +02:00
feat.c dccp ccid-2: Use feature-negotiation to report Ack Ratio changes 2008-09-04 07:45:32 +02:00
feat.h dccp: Debugging functions for feature negotiation 2008-09-04 07:45:32 +02:00
input.c dccp: Clean up slow-path input processing 2008-09-04 07:45:39 +02:00
ipv4.c dccp: Cleanup routines for feature negotiation 2008-09-04 07:45:26 +02:00
ipv6.c dccp: Cleanup routines for feature negotiation 2008-09-04 07:45:26 +02:00
ipv6.h Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
Kconfig dccp ccid-2: Remove old infrastructure 2008-09-04 07:45:37 +02:00
Makefile dccp: Policy-based packet dequeueing infrastructure 2008-09-04 07:45:39 +02:00
minisocks.c dccp: Fix the adjustments to AWL and SWL 2008-09-04 07:45:35 +02:00
options.c dccp ccid-2: Separate option parsing from CCID processing 2008-09-04 07:45:37 +02:00
output.c dccp: Policy-based packet dequeueing infrastructure 2008-09-04 07:45:39 +02:00
probe.c dccp: Reduce noise in output and convert to ktime_t 2008-09-04 07:45:36 +02:00
proto.c dccp qpolicy: Parameter checking of cmsg qpolicy parameters 2008-09-04 07:45:40 +02:00
qpolicy.c dccp qpolicy: Parameter checking of cmsg qpolicy parameters 2008-09-04 07:45:40 +02:00
sysctl.c dccp: Initialisation and type-checking of feature sysctls 2008-09-04 07:45:32 +02:00
timer.c dccp ccid-3: Runtime verification of timer resolution 2008-09-04 07:45:40 +02:00